Bug 1714177 - python-ruamel-yaml fails to build with Python 3.8
Summary: python-ruamel-yaml fails to build with Python 3.8
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: python-ruamel-yaml
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
high
Target Milestone: ---
Assignee: Chandan Kumar
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1700334
Blocks: PYTHON38 1731535
TreeView+ depends on / blocked
 
Reported: 2019-05-27 10:08 UTC by Miro Hrončok
Modified: 2019-09-04 22:00 UTC (History)
4 users (show)

Fixed In Version: python-ruamel-yaml-0.15.41-6.fc32
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-09-04 22:00:15 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
Full log from Copr (101.04 KB, text/plain)
2019-05-27 10:08 UTC, Miro Hrončok
no flags Details

Description Miro Hrončok 2019-05-27 10:08:48 UTC
Created attachment 1573872 [details]
Full log from Copr

python-ruamel-yaml 0.15.41-5.fc31 fails to build with Python 3.8.0a4:

Executing(%build): /bin/sh -e /var/tmp/rpm-tmp.cMd6ku
+ umask 022
+ cd /builddir/build/BUILD
+ cd ruamel-yaml-75b1b39341d9
+ CFLAGS='-O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection'
+ LDFLAGS='-Wl,-z,relro -Wl,--as-needed  -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld'
+ /usr/bin/python3 setup.py build '--executable=/usr/bin/python3 -s'
Traceback (most recent call last):
  File "setup.py", line 185, in <module>
    pkg_data = _package_data(__file__.replace('setup.py', '__init__.py'))
  File "setup.py", line 163, in _package_data
    data = literal_eval(u''.join(lines))
  File "setup.py", line 135, in literal_eval
    return _convert(node_or_string)
  File "setup.py", line 82, in _convert
    if isinstance(node, (Str, Bytes)):
NameError: name 'Str' is not defined

Full log attached.


This blocks other packages, like ansible-lint, borgmatic, buildstream or conda.

Comment 1 Miro Hrončok 2019-05-27 10:11:15 UTC
setup.py has:

from _ast import *

And _ast.Str used to be, but it is no more. it got renamed to _ast.Constant and there are some backwards compatibility shims in the ast module (that is an API), but not in the _ast module (that is not an API).

Comment 2 Miro Hrončok 2019-05-27 10:12:48 UTC
This is already fixed in upstream since November:

https://bitbucket.org/ruamel/yaml/commits/c4f22d89a9e22cb5b8c75daaa5c655fae975c84a

Comment 3 Miro Hrončok 2019-07-01 07:57:22 UTC
This issue is blocking the Python 3.8 rebuilds. If this package won't build with 3.8, it won't be installable, along with all its dependent packages, after the side tag is merged.
Furthermore, as it fails to install, its dependent packages will fail to install and/or build as well. The fix should be pushed on the master branch and no release bump is required.

Testing and mass rebuild of packages is happening in copr. You can follow these instructions to test locally in mock if your package builds with Python 3.8: https://copr.fedorainfracloud.org/coprs/g/python/python3.8/

If you don't have free cycles to dedicate fixing your package, notify us and we'll try to help. Let us know if we can push a fix directly without a pull request, in the case we happen to have one before you do.

Comment 4 Miro Hrončok 2019-07-10 11:55:50 UTC
Please respond.

Comment 5 Chandan Kumar 2019-07-22 07:28:06 UTC
Helo Miro,

Sorry for the late reply, I am looking into the issue.

Thanks,

Chandan Kumar

Comment 6 Ben Cotton 2019-08-13 17:00:31 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 31 development cycle.
Changing version to '31'.

Comment 7 Ben Cotton 2019-08-13 18:58:43 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 31 development cycle.
Changing version to 31.

Comment 8 Miro Hrončok 2019-08-14 22:24:39 UTC
The coordinated rebuild of Python 3.8 has started in the `f32-python` side tag.

If you figure out how to rebuild this package, please don't rebuild it in regular rawhide, but use the side tag instead:

    on branch master:
    $ fedpkg build --target=f32-python

To wait for a build to show up in the side tag, do:

    $ koji wait-repo f32-python --build=<nvr>

Where <nvr> is name-version-release of the source package, e.g. python-foo-1.1-2.fc32.

An updated mock config is posted at:
http://copr.fedorainfracloud.org/coprs/g/python/python3.8/

Note that it will take a while before the essential packages are rebuilt, so don't expect all your dependencies to be available right away.

Thanks. Let us know if you need up to date info, or if you have any questions.



PS this message is mass posted to all the bugs that block the PYTHON38 bug. If this is also a Fedora 31 FTBFS bug and you manage to fix it, you can do a f31 build as usual:

    on branch f31:
    $ fedpkg build

Comment 9 Miro Hrončok 2019-08-20 23:23:14 UTC
This issue is blocking the Python 3.8 rebuilds. If this package won't build with 3.8, it won't be installable, along with all its dependent packages, after the side tag is merged.
Furthermore, as it fails to install, its dependent packages will fail to install and/or build as well. The fix should be pushed on the master branch and no release bump is required.

$ repoquery --repo=rawhide{,-source} --whatrequires python3-ruamel-yaml
ansible-lint-0:4.1.0-2.fc31.src
borgmatic-0:1.2.0-4.fc31.src
borgmatic-0:1.2.0-4.fc31.x86_64
buildstream-0:1.2.8-2.fc31.noarch
buildstream-0:1.2.8-2.fc31.src
conda-0:4.7.10-1.fc31.src
python-hdmf-0:1.0.5-2.fc31.src
python-pynwb-0:1.0.3-1.fc31.src
python3-ansible-lint-0:4.1.1a0-1.fc32.noarch
python3-anyconfig-0:0.9.7-4.fc31.noarch
python3-conda-0:4.7.11-1.fc32.noarch
python3-hdmf-0:1.1.2-1.fc32.noarch
python3-openshift-1:0.8.8-2.fc31.noarch
python3-pynwb-0:1.0.3-1.fc31.noarch
translate-toolkit-0:2.4.0-2.fc31.noarch
translate-toolkit-0:2.4.0-2.fc31.src

Comment 10 Miro Hrončok 2019-08-21 16:35:23 UTC
The f32-python side tag has been merged. In order to rebuild the package, do it in regular rawhide, but please wait until python3-3.8 is tagged:

  $ koji wait-repo f32-build --build python3-3.8.0~b3-3.fc32


If your built already started in f32-python, after it is finished, please tag it to rawhide with:

  $ koji tag-build f32-pending <nvr>

For example:

  $ koji tag-build f32-pending libreoffice-6.3.0.4-3.fc32

Thanks!

(This comment is mass posted to all bugzillas blocking the PYTHON38 tracking bug.)

Comment 11 Miro Hrončok 2019-08-21 17:29:25 UTC
(Python 3.8 has landed in the rawhide buildroot.)

Comment 12 Miro Hrončok 2019-08-28 15:19:29 UTC
Chandan, could you please update the package?

Comment 13 Chandan Kumar 2019-08-30 08:18:43 UTC
Hello Miro,

I will be updating ruamel.yaml to 0.16.5 as per https://pypi.org/project/ruamel.yaml/ but it requires a new package ruamel.yaml.clib.
I have added the package review here https://bugzilla.redhat.com/show_bug.cgi?id=1747361 for the same.
Once it is available. The package will be built soon.

Thanks,

Chandan Kumar

Comment 14 Chandan Kumar 2019-08-30 18:06:24 UTC
Hello Miro,

The package is now fixed https://koji.fedoraproject.org/koji/buildinfo?buildID=1360177.

Thanks,

Chandan Kumar

Comment 15 Miro Hrončok 2019-09-04 22:00:15 UTC
Thanks.


Note You need to log in before you can comment on or make changes to this bug.