RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1715081 - Unify interfaces to determine number of cpus and make use of it everywhere
Summary: Unify interfaces to determine number of cpus and make use of it everywhere
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 8
Classification: Red Hat
Component: rteval
Version: 8.2
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: rc
: 8.2
Assignee: John Kacur
QA Contact: Mike Stowell
URL:
Whiteboard:
Depends On:
Blocks: 1722609
TreeView+ depends on / blocked
 
Reported: 2019-05-29 14:28 UTC by John Kacur
Modified: 2020-04-28 15:29 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-04-28 15:29:01 UTC
Type: Bug
Target Upstream Version:
Embargoed:
pm-rhel: mirror+


Attachments (Terms of Use)
use systopology for hackbench online-cpus (2.80 KB, patch)
2019-11-19 11:43 UTC, John Kacur
no flags Details | Diff
check whether cpu is online before adding to list (4.19 KB, patch)
2019-11-19 11:48 UTC, John Kacur
no flags Details | Diff


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2020:1571 0 None None None 2020-04-28 15:29:18 UTC

Description John Kacur 2019-05-29 14:28:09 UTC
There are at LEAST 3 interfaces that calculate the number of cpus on a system

misc.py, systopology.py, and cputopology.py

Despite that there are code paths that don't even make use of the interfaces and calculate this information on the spot.

We should unify all of these interfaces into one and make sure they are used everywhere.

Then when you fix a problem, it only needs to be fixed in one spot, and it simplifies the code by hiding implementation details in the interface.

The unified interface should fix a few problems, such as checking whether the cpus it reports are online or not. There are some assumptions that are also not true that need to be fixed. Fox example, the code often assumes that ou cannot make cpu0 offline, while that it sometimes the case, it is not always the case.

Comment 1 John Kacur 2019-05-29 14:33:20 UTC
Note, see https://bugzilla.redhat.com/show_bug.cgi?id=1698238 for a relevant bugzilla that starts doing this to fix a problem trying to put workloads on offline cpus

Comment 4 John Kacur 2019-11-19 11:43:39 UTC
Created attachment 1637617 [details]
use systopology for hackbench online-cpus

Comment 5 John Kacur 2019-11-19 11:48:26 UTC
Created attachment 1637618 [details]
check whether cpu is online before adding to list

Comment 8 errata-xmlrpc 2020-04-28 15:29:01 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:1571


Note You need to log in before you can comment on or make changes to this bug.