Bug 1715358 - Can't hotplug virtio-scsi disk to guest which the bootable disk is virtio-scsi disk
Summary: Can't hotplug virtio-scsi disk to guest which the bootable disk is virtio-scs...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: BLL.Virt
Version: 4.3.3.7
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
: ---
Assignee: Michal Skrivanek
QA Contact: meital avital
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-05-30 07:59 UTC by Meina Li
Modified: 2020-04-01 14:39 UTC (History)
4 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2020-04-01 14:39:10 UTC
oVirt Team: Virt
Embargoed:
pm-rhel: ovirt-4.4+


Attachments (Terms of Use)
engine.log (55.84 KB, text/plain)
2019-06-03 03:13 UTC, Meina Li
no flags Details

Description Meina Li 2019-05-30 07:59:24 UTC
Description of problem:
Can't hotplug virtio-scsi disk to rhel8 q35 guest which the bootable disk is virtio-scsi disk

Version-Release number of selected component (if applicable):
RHV server:
rhvm-4.3.3.7-0.1.el7.noarch

RHV host:
vdsm-4.30.15-1.el7ev.x86_64
qemu-kvm-rhev-2.12.0-28.el7.x86_64
libvirt-4.5.0-17.el7.x86_64
kernel-3.10.0-1048.el7.x86_64

How reproducible:
100%

Steps to Reproduce:
1. Create and start a vm with a virtio-scsi bootable disk.
2. Click 'System' and then select 'Disks' label, click 'New' to create a new virtual disk.
3. In the pop-up sub-webpage in step2, fill in legal values for 'Size(GB)' and 'Alias' parameters, such as create a 1G named 'test' virtual disk, and then click 'OK'.
4. Select the VM and click the 'Disks' option of VM, click 'Attach', select 'test' virtual disk with 'virtio-scsi' interface, then click 'OK'.

Actual results:
Can't hotplug successfully with error: Failed to plug a disk
Events:
VDSM intel_2 command HotPlugDiskVDS failed: Requested operation is not valid: Domain already contains a disk with that address

Expected results:
Can hotplug disk successfully

Additional info:
engine.log
2019-05-30 00:41:35,693-04 ERROR [org.ovirt.engine.core.bll.storage.disk.HotPlugDiskToVmCommand] (EE-ManagedThreadFactory-engineScheduled-Thread-38) [2938af8d] Command 'org.ovirt.engine.core.bll.storage.disk.HotPlugDiskToVmCommand' failed: EngineException: org.ovirt.engine.core.vdsbroker.vdsbroker.VDSErrorException: VDSGenericException: VDSErrorException: Failed to HotPlugDiskVDS, error = Requested operation is not valid: Domain already contains a disk with that address, code = 45 (Failed with error FailedToPlugDisk and code 45)
2019-05-30 00:41:35,696-04 INFO  [org.ovirt.engine.core.bll.storage.disk.HotPlugDiskToVmCommand] (EE-ManagedThreadFactory-engineScheduled-Thread-38) [2938af8d] Lock freed to object 'EngineLock:{exclusiveLocks='[c561b2bb-ade5-451f-a163-fe8d7d18d1f9=DISK]', sharedLocks='[adbfc0f6-554f-45ec-9167-ec4662ab8b2a=VM]'}'
2019-05-30 00:41:35,729-04 ERROR [org.ovirt.engine.core.dal.dbbroker.auditloghandling.AuditLogDirector] (EE-ManagedThreadFactory-engineScheduled-Thread-38) [2938af8d] EVENT_ID: USER_FAILED_HOTPLUG_DISK(2,001), Failed to plug disk jiyan_80_Disk1 to VM jiyan_80 (User: admin@internal-authz).

Comment 1 Meina Li 2019-05-30 08:59:34 UTC
Additional info:
This bug happens both on i440fx and q35 vm.

Comment 2 Ryan Barry 2019-05-31 01:45:25 UTC
Logs? The generated XML in particular would be helpful, but complete engine log if possible

Comment 4 Meina Li 2019-06-03 03:13:42 UTC
Created attachment 1576460 [details]
engine.log

Comment 6 Michal Skrivanek 2020-03-18 15:43:58 UTC
This bug didn't get any attention for a while, we didn't have the capacity to make any progress. If you deeply care about it or want to work on it please assign/target accordingly

Comment 7 Michal Skrivanek 2020-03-18 15:47:08 UTC
This bug didn't get any attention for a while, we didn't have the capacity to make any progress. If you deeply care about it or want to work on it please assign/target accordingly

Comment 8 Meina Li 2020-03-24 09:22:52 UTC
Can't reproduce it in the latest version:

RHV server:
rhvm-4.4.0-0.25.master.el8ev.noarch

Host:
vdsm-4.40.5-1.el8ev.x86_64
kernel-4.18.0-190.el8.x86_64
qemu-kvm-4.2.0-15.module+el8.2.0+6029+618ef2ec.x86_64
libvirt-6.0.0-14.module+el8.2.0+6069+78a1cb09.x86_64

Comment 9 Michal Skrivanek 2020-04-01 14:39:10 UTC
great for verifying it! closing then


Note You need to log in before you can comment on or make changes to this bug.