Spec URL: https://atim.fedorapeople.org/for-review/fragments.spec SRPM URL: https://atim.fedorapeople.org/for-review/fragments-1.4-9.fc30.src.rpm Description: Fragments is an easy to use BitTorrent client which follows the GNOME HIG and includes well thought-out features. Fedora Account System Username: atim Working COPR: https://copr.fedorainfracloud.org/coprs/atim/fragments/
License fixes. Spec URL: https://atim.fedorapeople.org/for-review/fragments.spec SRPM URL: https://atim.fedorapeople.org/for-review/fragments-1.4-10.fc30.src.rpm
Spec URL: https://atim.fedorapeople.org/for-review/fragments.spec SRPM URL: https://atim.fedorapeople.org/for-review/fragments-1.4-11.fc30.src.rpm
I will review this package.
1. If you bundle any libraries, you must add: Provides: bundled(foo) = foo_version. 2. Provides: libtransmission = git%{transmission_shortcommit} is incorrect, because it will override packaged version in Fedora. 3. Final bundled provides should look like: Provides: bundled(libtransmission) = 0.94.git%{transmission_shortcommit} Provides: bundled(libnatpmp) = 0.git%{libnatpmp_commit} Provides: bundled(dht) = 0.26.git%{dht_commit} Provides: bundled(libutp) = 0.git%{libutp_commit}
Fixed. Spec URL: https://atim.fedorapeople.org/for-review/fragments.spec SRPM URL: https://atim.fedorapeople.org/for-review/fragments-1.4-12.fc30.src.rpm
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [-]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU General Public License (v2)", "Expat License", "ISC License", "Unicode strict", "GPL (v3 or later)", "FSF All Permissive License", "GNU General Public License", "GPL (v2.1) GNU Lesser General Public License (v2.1)", "zlib/libpng license", "BSD 3-clause "New" or "Revised" License", "*No copyright* GNU General Public License", "BSD 2-clause "Simplified" License", "OpenSSL License", "BSD 4-clause "Original" or "Old" License". 1531 files have unknown license. Detailed output of licensecheck in /media/data/rpmbuild/1715613-fragments/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [-]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: The spec file handles locales properly. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: fragments-1.4-12.fc31.x86_64.rpm fragments-debuginfo-1.4-12.fc31.x86_64.rpm fragments-debugsource-1.4-12.fc31.x86_64.rpm fragments-1.4-12.fc31.src.rpm fragments.x86_64: W: no-manual-page-for-binary fragments 4 packages and 0 specfiles checked; 0 errors, 1 warnings. Rpmlint (debuginfo) ------------------- Checking: fragments-debuginfo-1.4-12.fc31.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- fragments-debugsource.x86_64: W: invalid-url URL: https://gitlab.gnome.org/World/Fragments <urlopen error [Errno -2] Name or service not known> fragments.x86_64: W: invalid-url URL: https://gitlab.gnome.org/World/Fragments <urlopen error [Errno -2] Name or service not known> fragments.x86_64: W: no-manual-page-for-binary fragments fragments-debuginfo.x86_64: W: invalid-url URL: https://gitlab.gnome.org/World/Fragments <urlopen error [Errno -2] Name or service not known> 3 packages and 0 specfiles checked; 0 errors, 4 warnings. Source checksums ---------------- https://github.com/transmission/libutp/tarball/fda9f4b3db97ccb243fcbed2ce280eb4135d705b#/libutp-fda9f4b.tar.gz : CHECKSUM(SHA256) this package : 1cde78664bc1e1425bb4b164f186ee673d4d3cb9b926d6f683946bf0f2056940 CHECKSUM(SHA256) upstream package : 1cde78664bc1e1425bb4b164f186ee673d4d3cb9b926d6f683946bf0f2056940 https://github.com/transmission/dht/tarball/25e12bb39eea3d433602de6390796fec8a8f3620#/dht-25e12bb.tar.gz : CHECKSUM(SHA256) this package : d12a072546d69beee286ed1579531c61b740e519e75005135a6cefd152ed5448 CHECKSUM(SHA256) upstream package : d12a072546d69beee286ed1579531c61b740e519e75005135a6cefd152ed5448 https://github.com/transmission/libnatpmp/tarball/4d3b9d87bbe7549830c212ce840600619abcf887#/libnatpmp-4d3b9d8.tar.gz : CHECKSUM(SHA256) this package : 941feae1e1d5335c1678440855846c397414cdb76165cb680ab0220726693280 CHECKSUM(SHA256) upstream package : 941feae1e1d5335c1678440855846c397414cdb76165cb680ab0220726693280 https://github.com/transmission/transmission/tarball/3d9fd25269ccfc1dacf9c5cd23a3d232e0085150#/transmission-3d9fd25.tar.gz : CHECKSUM(SHA256) this package : f6d90e1d31ff181dc6fcdee1ab7f917cb58aca0534ffcda6134c1dd565ac4e5f CHECKSUM(SHA256) upstream package : f6d90e1d31ff181dc6fcdee1ab7f917cb58aca0534ffcda6134c1dd565ac4e5f https://gitlab.gnome.org/World/Fragments/-/archive/1.4/Fragments-1.4.tar.gz : CHECKSUM(SHA256) this package : bfd493d68a720d676d47eef214c9b356c64dc600bf7e83e281f55eb239cabf54 CHECKSUM(SHA256) upstream package : bfd493d68a720d676d47eef214c9b356c64dc600bf7e83e281f55eb239cabf54 Requires -------- fragments (rpmlib, GLIBC filtered): hicolor-icon-theme libc.so.6()(64bit) libcairo.so.2()(64bit) libcrypto.so.1.1()(64bit) libcrypto.so.1.1(OPENSSL_1_1_0)(64bit) libcurl.so.4()(64bit) libevent-2.1.so.6()(64bit) libgdk-3.so.0()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgtk-3.so.0()(64bit) libhandy-0.0.so.0()(64bit) libhandy-0.0.so.0(LIBHANDY_0_0_0)(64bit) libminiupnpc.so.17()(64bit) libpthread.so.0()(64bit) libz.so.1()(64bit) rtld(GNU_HASH) fragments-debuginfo (rpmlib, GLIBC filtered): fragments-debugsource (rpmlib, GLIBC filtered): Provides -------- fragments: application() application(de.haeckerfelix.Fragments.desktop) bundled(dht) bundled(libnatpmp) bundled(libtransmission) bundled(libutp) fragments fragments(x86-64) metainfo() metainfo(de.haeckerfelix.Fragments.appdata.xml) mimehandler(application/x-bittorrent) mimehandler(x-scheme-handler/magnet) fragments-debuginfo: debuginfo(build-id) fragments-debuginfo fragments-debuginfo(x86-64) fragments-debugsource: fragments-debugsource fragments-debugsource(x86-64) Generated by fedora-review 0.7.2 (65d36bb) last change: 2019-04-09 Command line :/usr/bin/fedora-review -b 1715613 -m fedora-rawhide-x86_64 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, C/C++, Shell-api Disabled plugins: Perl, PHP, R, SugarActivity, Haskell, fonts, Java, Python, Ocaml Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
*No copyright* GNU General Public License ----------------------------------------- Fragments-1.4/submodules/transmission/qt/icons/Faenza/AUTHORS BSD 2-clause "Simplified" License --------------------------------- Fragments-1.4/submodules/transmission/third-party/openssl/include/openssl/asn1.h Fragments-1.4/submodules/transmission/third-party/openssl/include/openssl/asn1_mac.h Fragments-1.4/submodules/transmission/third-party/openssl/include/openssl/bio.h Fragments-1.4/submodules/transmission/third-party/openssl/include/openssl/blowfish.h Fragments-1.4/submodules/transmission/third-party/openssl/include/openssl/bn.h Fragments-1.4/submodules/transmission/third-party/openssl/include/openssl/buffer.h Fragments-1.4/submodules/transmission/third-party/openssl/include/openssl/cast.h Fragments-1.4/submodules/transmission/third-party/openssl/include/openssl/conf.h Fragments-1.4/submodules/transmission/third-party/openssl/include/openssl/conf_api.h Fragments-1.4/submodules/transmission/third-party/openssl/include/openssl/des.h Fragments-1.4/submodules/transmission/third-party/openssl/include/openssl/dh.h Fragments-1.4/submodules/transmission/third-party/openssl/include/openssl/dsa.h Fragments-1.4/submodules/transmission/third-party/openssl/include/openssl/err.h Fragments-1.4/submodules/transmission/third-party/openssl/include/openssl/evp.h Fragments-1.4/submodules/transmission/third-party/openssl/include/openssl/hmac.h Fragments-1.4/submodules/transmission/third-party/openssl/include/openssl/lhash.h Fragments-1.4/submodules/transmission/third-party/openssl/include/openssl/md2.h Fragments-1.4/submodules/transmission/third-party/openssl/include/openssl/md4.h Fragments-1.4/submodules/transmission/third-party/openssl/include/openssl/md5.h Fragments-1.4/submodules/transmission/third-party/openssl/include/openssl/mdc2.h Fragments-1.4/submodules/transmission/third-party/openssl/include/openssl/objects.h Fragments-1.4/submodules/transmission/third-party/openssl/include/openssl/pem.h Fragments-1.4/submodules/transmission/third-party/openssl/include/openssl/pkcs7.h Fragments-1.4/submodules/transmission/third-party/openssl/include/openssl/rand.h Fragments-1.4/submodules/transmission/third-party/openssl/include/openssl/rc2.h Fragments-1.4/submodules/transmission/third-party/openssl/include/openssl/rc4.h Fragments-1.4/submodules/transmission/third-party/openssl/include/openssl/rc5.h Fragments-1.4/submodules/transmission/third-party/openssl/include/openssl/ripemd.h Fragments-1.4/submodules/transmission/third-party/openssl/include/openssl/rsa.h Fragments-1.4/submodules/transmission/third-party/openssl/include/openssl/sha.h Fragments-1.4/submodules/transmission/third-party/openssl/include/openssl/ssl.h Fragments-1.4/submodules/transmission/third-party/openssl/include/openssl/ssl2.h Fragments-1.4/submodules/transmission/third-party/openssl/include/openssl/ssl23.h Fragments-1.4/submodules/transmission/third-party/openssl/include/openssl/ssl3.h Fragments-1.4/submodules/transmission/third-party/openssl/include/openssl/stack.h Fragments-1.4/submodules/transmission/third-party/openssl/include/openssl/tls1.h Fragments-1.4/submodules/transmission/third-party/openssl/include/openssl/tmdiff.h Fragments-1.4/submodules/transmission/third-party/openssl/include/openssl/txt_db.h Fragments-1.4/submodules/transmission/third-party/openssl/include/openssl/x509.h Fragments-1.4/submodules/transmission/third-party/openssl/include/openssl/x509_vfy.h BSD 3-clause "New" or "Revised" License --------------------------------------- Fragments-1.4/submodules/transmission/third-party/libnatpmp/LICENSE Fragments-1.4/submodules/transmission/third-party/libnatpmp/getgateway.c Fragments-1.4/submodules/transmission/third-party/libnatpmp/getgateway.h Fragments-1.4/submodules/transmission/third-party/libnatpmp/libnatpmpmodule.c Fragments-1.4/submodules/transmission/third-party/libnatpmp/natpmp.c Fragments-1.4/submodules/transmission/third-party/libnatpmp/natpmp.h Fragments-1.4/submodules/transmission/third-party/libnatpmp/natpmpc.c Fragments-1.4/submodules/transmission/third-party/libnatpmp/testgetgateway.c Fragments-1.4/submodules/transmission/third-party/libnatpmp/wingettimeofday.c Fragments-1.4/submodules/transmission/third-party/libnatpmp/wingettimeofday.h BSD 4-clause "Original" or "Old" License ---------------------------------------- Fragments-1.4/submodules/transmission/third-party/openssl/include/openssl/seed.h Expat License ------------- Fragments-1.4/submodules/transmission/cli/cli.c Fragments-1.4/submodules/transmission/gtk/conf.c Fragments-1.4/submodules/transmission/gtk/conf.h Fragments-1.4/submodules/transmission/gtk/dialogs.c Fragments-1.4/submodules/transmission/gtk/dialogs.h Fragments-1.4/submodules/transmission/gtk/main.c Fragments-1.4/submodules/transmission/gtk/tr-core.c Fragments-1.4/submodules/transmission/gtk/tr-core.h Fragments-1.4/submodules/transmission/gtk/tr-window.c Fragments-1.4/submodules/transmission/gtk/tr-window.h Fragments-1.4/submodules/transmission/gtk/transmission-gtk.1 Fragments-1.4/submodules/transmission/libtransmission/jsonsl.c Fragments-1.4/submodules/transmission/libtransmission/jsonsl.h Fragments-1.4/submodules/transmission/libtransmission/net.c Fragments-1.4/submodules/transmission/libtransmission/net.h Fragments-1.4/submodules/transmission/libtransmission/tr-dht.c Fragments-1.4/submodules/transmission/libtransmission/tr-dht.h Fragments-1.4/submodules/transmission/libtransmission/tr-lpd.c Fragments-1.4/submodules/transmission/libtransmission/tr-lpd.h Fragments-1.4/submodules/transmission/libtransmission/tr-udp.c Fragments-1.4/submodules/transmission/libtransmission/tr-udp.h Fragments-1.4/submodules/transmission/libtransmission/tr-utp.c Fragments-1.4/submodules/transmission/libtransmission/tr-utp.h Fragments-1.4/submodules/transmission/third-party/dht/LICENCE Fragments-1.4/submodules/transmission/third-party/dht/dht.c Fragments-1.4/submodules/transmission/third-party/dht/dht.h Fragments-1.4/submodules/transmission/third-party/libutp/LICENSE Fragments-1.4/submodules/transmission/third-party/libutp/README.md FSF All Permissive License -------------------------- Fragments-1.4/submodules/transmission/m4/check-ssl.m4 GNU General Public License -------------------------- Fragments-1.4/submodules/transmission/qt/LicenseDialog.ui GNU General Public License (v2) ------------------------------- Fragments-1.4/submodules/transmission/COPYING Fragments-1.4/submodules/transmission/web/javascript/common.js Fragments-1.4/submodules/transmission/web/javascript/dialog.js Fragments-1.4/submodules/transmission/web/javascript/file-row.js Fragments-1.4/submodules/transmission/web/javascript/formatter.js Fragments-1.4/submodules/transmission/web/javascript/inspector.js Fragments-1.4/submodules/transmission/web/javascript/main.js Fragments-1.4/submodules/transmission/web/javascript/polyfill.js Fragments-1.4/submodules/transmission/web/javascript/prefs-dialog.js Fragments-1.4/submodules/transmission/web/javascript/remote.js Fragments-1.4/submodules/transmission/web/javascript/torrent-row.js Fragments-1.4/submodules/transmission/web/javascript/torrent.js Fragments-1.4/submodules/transmission/web/javascript/transmission.js GPL (v2.1) GNU Lesser General Public License (v2.1) --------------------------------------------------- Fragments-1.4/submodules/transmission/qt/SqueezeLabel.cc Fragments-1.4/submodules/transmission/qt/SqueezeLabel.h GPL (v3 or later) ----------------- Fragments-1.4/data/icons/hicolor/scalable/status/lightning-symbolic.svg Fragments-1.4/submodules/transmission/m4/acx-pthread.m4 Fragments-1.4/submodules/transmission/third-party/libnatpmp/fr/free/miniupnp/libnatpmp/LibraryExtractor.java Fragments-1.4/submodules/transmission/third-party/libnatpmp/fr/free/miniupnp/libnatpmp/URLUtils.java ISC License ----------- Fragments-1.4/submodules/transmission/cli/transmission-cli.1 OpenSSL License --------------- Fragments-1.4/submodules/transmission/third-party/openssl/include/openssl/crypto.h Fragments-1.4/submodules/transmission/third-party/openssl/include/openssl/e_os2.h Fragments-1.4/submodules/transmission/third-party/openssl/include/openssl/ec.h Fragments-1.4/submodules/transmission/third-party/openssl/include/openssl/krb5_asn.h Fragments-1.4/submodules/transmission/third-party/openssl/include/openssl/ocsp.h Fragments-1.4/submodules/transmission/third-party/openssl/include/openssl/ossl_typ.h Fragments-1.4/submodules/transmission/third-party/openssl/include/openssl/safestack.h Fragments-1.4/submodules/transmission/third-party/openssl/include/openssl/store.h Fragments-1.4/submodules/transmission/third-party/openssl/include/openssl/symhacks.h Fragments-1.4/submodules/transmission/third-party/openssl/include/openssl/ui.h Fragments-1.4/submodules/transmission/third-party/openssl/include/openssl/ui_compat.h Unicode strict -------------- Fragments-1.4/submodules/transmission/libtransmission/ConvertUTF.c Fragments-1.4/submodules/transmission/libtransmission/ConvertUTF.h zlib/libpng license ------------------- Fragments-1.4/submodules/transmission/macosx/VDKQueue/VDKQueue.h Fragments-1.4/submodules/transmission/macosx/VDKQueue/VDKQueue.m
1. Final license tag should be: GPLv3+ and MIT and GPLv2 and BSD and OpenSSL and LGPLv2+ and zlib. 2. Also you must copy all this licenses to %license section. 3. Try to unbundle openssl. This a very dangerous library.
> 1. Final license tag should be: GPLv3+ and MIT and GPLv2 and BSD and OpenSSL and LGPLv2+ and zlib. GPLv2 and OpenSSL and LGPLv2+ and zlib - nothing from this is really used and requred for build Fragments and Transmission for Linux build. > 3. Try to unbundle openssl. This a very dangerous library. It's not bundled, it is built with system openssl library, but i removed it anyway from "third-party/openssl". Spec URL: https://atim.fedorapeople.org/for-review/fragments.spec SRPM URL: https://atim.fedorapeople.org/for-review/fragments-1.4-13.fc30.src.rpm
LGTM now. Package approved.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/fragments
FEDORA-2019-fc955d8997 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-fc955d8997
fragments-1.4-13.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-fc955d8997
fragments-1.4-13.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report.