Bug 1715863 (python-rawkit) - Review Request: python-rawkit - A ctypes-based set of LibRaw bindings for Python
Summary: Review Request: python-rawkit - A ctypes-based set of LibRaw bindings for Python
Keywords:
Status: CLOSED ERRATA
Alias: python-rawkit
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Peter Lemenkov
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1574642
TreeView+ depends on / blocked
 
Reported: 2019-05-31 13:09 UTC by Fabian Affolter
Modified: 2019-06-18 03:46 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-06-18 03:46:11 UTC
Type: ---
Embargoed:
lemenkov: fedora-review+


Attachments (Terms of Use)

Description Fabian Affolter 2019-05-31 13:09:17 UTC
Spec URL: https://fab.fedorapeople.org/packages/SRPMS/python-rawkit.spec
SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/python-rawkit-0.6.0-1.fc30.src.rpm

Project URL: https://rawkit.readthedocs.io

Description:
rawkit is a ctypes-based set of LibRaw bindings for Python.

Koji scratch build:

rpmlint output:
$ rpmlint python-rawkit-0.6.0-1.fc30.src.rpm 
python-rawkit.src: W: spelling-error Summary(en_US) ctypes -> types, c types
python-rawkit.src: W: spelling-error %description -l en_US ctypes -> types, c types
1 packages and 0 specfiles checked; 0 errors, 2 warnings.

$ rpmlint python3-rawkit-0.6.0-1.fc30.noarch.rpm 
python3-rawkit.noarch: W: spelling-error Summary(en_US) ctypes -> types, c types
python3-rawkit.noarch: W: spelling-error %description -l en_US ctypes -> types, c types
1 packages and 0 specfiles checked; 0 errors, 2 warnings.

Fedora Account System Username: fab

Comment 1 Peter Lemenkov 2019-06-07 13:12:58 UTC
I'll review it

Comment 2 Peter Lemenkov 2019-06-07 13:28:01 UTC
[+] rpmlint is silent (or produces messages which can be safely ignored):

Auriga ~: rpmlint python-rawkit-0.6.0-1.fc31.src.rpm python3-rawkit-0.6.0-1.fc31.noarch.rpm
python-rawkit.src: W: spelling-error Summary(en_US) ctypes -> types, c types
python-rawkit.src: W: spelling-error %description -l en_US ctypes -> types, c types
python-rawkit.src:38: W: macro-in-comment %check
python-rawkit.src:39: W: macro-in-comment %{python3_version}
python3-rawkit.noarch: W: spelling-error Summary(en_US) ctypes -> types, c types
python3-rawkit.noarch: W: spelling-error %description -l en_US ctypes -> types, c types
2 packages and 0 specfiles checked; 0 errors, 6 warnings.
Auriga ~: 

[+] The package is named according to the Package Naming Guidelines.
[+] The spec file name matches the base package %{name}, in the format %{name}.spec.
[+] The package meets the Packaging Guidelines.
[+] The package is licensed with a Fedora approved license and meets the Licensing Guidelines.
[+] The License field in the package spec file matches the actual license (MIT).
[+] The file, containing the text of the license(s) for the package, is included in %doc and marked as %license.
[+] The spec file is written in American English.
[+] The spec file for the package is legible.
[+] The sources used to build the package matches the upstream source, as provided in the spec URL.

Auriga ~: sha512sum rawkit-0.6.0.tar.gz*
4d9ca2ebaa18f3dced1a12d5d28412595e985d8602f5c1c1b244ac5b5f61c68ef07e44f14eac345b5df30ee05fc891a3f1f819ceaed8959847a18abbeeb0e657  rawkit-0.6.0.tar.gz
4d9ca2ebaa18f3dced1a12d5d28412595e985d8602f5c1c1b244ac5b5f61c68ef07e44f14eac345b5df30ee05fc891a3f1f819ceaed8959847a18abbeeb0e657  rawkit-0.6.0.tar.gz.1
Auriga ~: 

[+] The package successfully compiles and builds into binary rpms. See this scrathchbuild:

  * https://koji.fedoraproject.org/koji/taskinfo?taskID=35368016

[+] All build dependencies are listed in BuildRequires.
[0] No need to handle locales.
[0] The package does not contain any shared library files.
[+] Packages does not bundle copies of system libraries.
[+] The package isn't designed to be relocatable.
[+] The package owns all directories that it creates.
[+] The package does not list a file more than once in the spec file's %files listings.
[+] Permissions on files are set properly.
[+] The package consistently uses macros.
[+] The package contains code, or permissible content.
[0] No large documentation files.
[+] Anything, the package includes as %doc, does not affect the runtime of the application.
[0] No static libraries.
[0] No -devel sub-package.
[+] The package does not contain any .la libtool archives.
[0] Not a GUI application.
[+] The package does not own files or directories already owned by other packages.
[+] All filenames in rpm packages are valid UTF-8.


APPROVED.

Comment 3 Fabian Affolter 2019-06-08 16:23:47 UTC
Thanks for the review. Is much appreciated.

Comment 4 Gwyn Ciesla 2019-06-08 20:47:13 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/python-rawkit

Comment 5 Fedora Update System 2019-06-09 09:04:39 UTC
FEDORA-2019-a89c6dd7a6 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-a89c6dd7a6

Comment 6 Fedora Update System 2019-06-10 01:10:43 UTC
python-rawkit-0.6.0-1.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-a89c6dd7a6

Comment 7 Fedora Update System 2019-06-18 03:46:11 UTC
python-rawkit-0.6.0-1.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.