Bug 1715893 (python-gphoto2) - Review Request: python-gphoto2 - A Python interface to libgphoto2
Summary: Review Request: python-gphoto2 - A Python interface to libgphoto2
Keywords:
Status: CLOSED ERRATA
Alias: python-gphoto2
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Peter Lemenkov
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1574642
TreeView+ depends on / blocked
 
Reported: 2019-05-31 14:32 UTC by Fabian Affolter
Modified: 2019-06-18 03:46 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-06-18 03:46:17 UTC
Type: ---
Embargoed:
lemenkov: fedora-review+


Attachments (Terms of Use)

Description Fabian Affolter 2019-05-31 14:32:47 UTC
Spec URL: https://fab.fedorapeople.org/packages/SRPMS/python-gphoto2.spec
SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/python-gphoto2-2.0.0-1.fc30.src.rpm

Project URL: https://github.com/jim-easterbrook/python-gphoto2

Description:
python-gphoto2 is a comprehensive Python interface (or binding) to libgphoto2.
It is built using SWIG to automatically generate the interface code. This 
ives direct access to nearly all the libgphoto2 functions, but sometimes in
a rather un-Pythonic manner.

Koji scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=35171785

rpmlint output:
$ rpmlint python-gphoto2-2.0.0-1.fc30.src.rpm 
python-gphoto2.src: W: spelling-error %description -l en_US ives -> vies, vise, Ives
python-gphoto2.src: W: spelling-error %description -l en_US un -> UN, nu, in
1 packages and 0 specfiles checked; 0 errors, 2 warnings.

$ rpmlint python3-gphoto2*
python3-gphoto2.x86_64: W: spelling-error %description -l en_US un -> UN, nu, in
2 packages and 0 specfiles checked; 0 errors, 1 warnings.

Fedora Account System Username: fab

Comment 1 Peter Lemenkov 2019-06-07 13:15:05 UTC
I'll review it

Comment 2 Peter Lemenkov 2019-06-07 13:21:51 UTC
[+/-] rpmlint spotted one small typo. Apart from it everything looks fine:

Auriga ~: rpmlint python3-gphoto2-2.0.0-1.fc31.x86_64.rpm python-gphoto2-2.0.0-1.fc31.src.rpm
python3-gphoto2.x86_64: W: spelling-error %description -l en_US un -> UN, nu, in
python-gphoto2.src: W: spelling-error %description -l en_US ives -> vies, vise, Ives

^^^ Please fix that typo.

python-gphoto2.src: W: spelling-error %description -l en_US un -> UN, nu, in
2 packages and 0 specfiles checked; 0 errors, 3 warnings.
Auriga ~: 

[+] The package is named according to the Package Naming Guidelines.
[+] The spec file name matches the base package %{name}, in the format %{name}.spec.
[+] The package meets the Packaging Guidelines.
[+] The package is licensed with a Fedora approved license and meets the Licensing Guidelines.
[+] The License field in the package spec file matches the actual license (GPLv3 or later).
[+] The file, containing the text of the license(s) for the package, is included in %doc and marked as %license.
[+] The spec file is written in American English.
[+] The spec file for the package is legible.
[+] The sources used to build the package matches the upstream source, as provided in the spec URL.

Auriga ~: sha512sum  gphoto2-2.0.0.tar.gz*
f3412c6a994a5242187321ae9f37c481e1248c97c8528c7542f29549cfc691daec84fd03139bea48e7b090e149bff091d5b2900f3eb22f888fe9e7f8bb599e34  gphoto2-2.0.0.tar.gz
f3412c6a994a5242187321ae9f37c481e1248c97c8528c7542f29549cfc691daec84fd03139bea48e7b090e149bff091d5b2900f3eb22f888fe9e7f8bb599e34  gphoto2-2.0.0.tar.gz.1
Auriga ~: 

[+] The package successfully compiles and builds into binary rpms.
[+] All build dependencies are listed in BuildRequires.
[0] No need to handle locales.
[0] The package does not contain any shared library files in a common places where shared libs are stored usually.
[+] Packages does not bundle copies of system libraries.
[+] The package isn't designed to be relocatable.
[+] The package owns all directories that it creates.
[+] The package does not list a file more than once in the spec file's %files listings.
[+] Permissions on files are set properly.
[+] The package consistently uses macros.
[+] The package contains code, or permissible content.
[0] No large documentation files.
[+] Anything, the package includes as %doc, does not affect the runtime of the application.
[0] No static libraries.
[0] No -devel sub-package.
[+] The package does not contain any .la libtool archives.
[0] Not a GUI application.
[+] The package does not own files or directories already owned by other packages.
[+] All filenames in rpm packages are valid UTF-8.

APPROVED.

Comment 3 Fabian Affolter 2019-06-08 16:30:28 UTC
Thanks once more.

Comment 4 Gwyn Ciesla 2019-06-08 20:52:33 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/python-gphoto2

Comment 5 Fedora Update System 2019-06-09 09:09:06 UTC
FEDORA-2019-b230d30416 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-b230d30416

Comment 6 Fedora Update System 2019-06-10 01:10:46 UTC
python-gphoto2-2.0.0-1.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-b230d30416

Comment 7 Fedora Update System 2019-06-18 03:46:17 UTC
python-gphoto2-2.0.0-1.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.