Description of problem: There are some unnecessary warnings in scriptlet which shoudl be probably fixed. Version-Release number of selected component (if applicable): openssh-server-8.0p1-2.fc31 How reproducible: deterministic Steps to Reproduce: 1. # ensure that you have older version of openssh installed 2. dnf update -y openssh Actual results: sh# dnf update openssh Last metadata expiration check: 0:44:21 ago on Mon 03 Jun 2019 10:11:22 AM CEST. Dependencies resolved. ================================================================================ Package Architecture Version Repository Size ================================================================================ Upgrading: openssh x86_64 8.0p1-3.fc31 rawhide 424 k openssh-askpass x86_64 8.0p1-3.fc31 rawhide 20 k openssh-clients x86_64 8.0p1-3.fc31 rawhide 630 k openssh-server x86_64 8.0p1-3.fc31 rawhide 413 k Transaction Summary ================================================================================ Upgrade 4 Packages Total download size: 1.5 M Is this ok [y/N]: y Downloading Packages: (1/4): openssh-askpass-8.0p1-3.fc31.x86_64.rpm 449 kB/s | 20 kB 00:00 (2/4): openssh-8.0p1-3.fc31.x86_64.rpm 3.4 MB/s | 424 kB 00:00 (3/4): openssh-server-8.0p1-3.fc31.x86_64.rpm 4.8 MB/s | 413 kB 00:00 (4/4): openssh-clients-8.0p1-3.fc31.x86_64.rpm 3.8 MB/s | 630 kB 00:00 -------------------------------------------------------------------------------- Total 1.4 MB/s | 1.5 MB 00:01 Running transaction check Transaction check succeeded. Running transaction test Transaction test succeeded. Running transaction Preparing : 1/1 Running scriptlet: openssh-8.0p1-3.fc31.x86_64 1/1 Running scriptlet: openssh-8.0p1-3.fc31.x86_64 1/8 Upgrading : openssh-8.0p1-3.fc31.x86_64 1/8 Upgrading : openssh-askpass-8.0p1-3.fc31.x86_64 2/8 Upgrading : openssh-clients-8.0p1-3.fc31.x86_64 3/8 Running scriptlet: openssh-server-8.0p1-3.fc31.x86_64 4/8 Upgrading : openssh-server-8.0p1-3.fc31.x86_64 4/8 Running scriptlet: openssh-server-8.0p1-3.fc31.x86_64 4/8 Running scriptlet: openssh-server-8.0p1-2.fc31.x86_64 5/8 Cleanup : openssh-server-8.0p1-2.fc31.x86_64 5/8 Running scriptlet: openssh-server-8.0p1-2.fc31.x86_64 5/8 Warning: The unit file, source configuration file or drop-ins of sshd.service changed on disk. Run 'systemctl daemon-reload' to reload units. Cleanup : openssh-clients-8.0p1-2.fc31.x86_64 6/8 Cleanup : openssh-askpass-8.0p1-2.fc31.x86_64 7/8 Cleanup : openssh-8.0p1-2.fc31.x86_64 8/8 Running scriptlet: openssh-8.0p1-2.fc31.x86_64 8/8 Verifying : openssh-8.0p1-3.fc31.x86_64 1/8 Verifying : openssh-8.0p1-2.fc31.x86_64 2/8 Verifying : openssh-askpass-8.0p1-3.fc31.x86_64 3/8 Verifying : openssh-askpass-8.0p1-2.fc31.x86_64 4/8 Verifying : openssh-clients-8.0p1-3.fc31.x86_64 5/8 Verifying : openssh-clients-8.0p1-2.fc31.x86_64 6/8 Verifying : openssh-server-8.0p1-3.fc31.x86_64 7/8 Verifying : openssh-server-8.0p1-2.fc31.x86_64 8/8 Upgraded: openssh-8.0p1-3.fc31.x86_64 openssh-askpass-8.0p1-3.fc31.x86_64 openssh-clients-8.0p1-3.fc31.x86_64 openssh-server-8.0p1-3.fc31.x86_64 Complete! Expected results: No warnings in output.
`systemctl daemon-reload` should be executed but I am not sure whether it is wrong usage if systemd macros or it should be handled in %systemd_postun_with_restart So freel free to reassing component to systemd sh$ rpm -qf /usr/lib/rpm/macros.d/macros.systemd systemd-rpm-macros-242-3.git7a6d834.fc31.noarch
This is an update, which does NOT change the units on the disk. If it would, the systemd macros should indeed take care of the daemon-reload step. Can you make sure you did not made any changes to these files prior the update? Checking the files /usr/lib/systemd/system/sshd.service and drop-in files under /etc/systemd/system/sshd.service.d/ and the sshd.socket, sshd@.service, sshd-keygen.target and sshd-keygen@.service paths, whether they were not modified? Checking using rpm -qV openssh-server could also show whether the shipped files were modified.
It is enough
It is enough sh# touch /usr/lib/systemd/system/sshd.service sh# systemctl restart sshd Warning: The unit file, source configuration file or drop-ins of sshd.service changed on disk. Run 'systemctl daemon-reload' to reload units. And I do not have any overrides in /etc sh# rpm -qV openssh-server sh# ls -l /etc/systemd/system/ssh* ls: cannot access '/etc/systemd/system/ssh*': No such file or directory
Ok, then it is something new probably in systemd. I miss the buildrequires in my spec file BuildRequires: systemd-rpm-macros but it is pulled in by something else according to the root.log of last build [1]). Otherwise, the scriptlets look just fine according to the packaging guidelines [2] so it is probably something to ask systemd. [1] https://koji.fedoraproject.org/koji/buildinfo?buildID=1270919 [2] https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_systemd
*** This bug has been marked as a duplicate of bug 1715737 ***