Bug 1716936 - Add upstream patch to make audio connection more reliable
Summary: Add upstream patch to make audio connection more reliable
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: libnice
Version: 30
Hardware: All
OS: Linux
unspecified
high
Target Milestone: ---
Assignee: Stefan Becker
QA Contact: Fedora Extras Quality Assurance
URL: https://gitlab.freedesktop.org/libnic...
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-06-04 12:27 UTC by Brian J. Murrell
Modified: 2019-06-13 01:38 UTC (History)
6 users (show)

Fixed In Version: libnice-0.1.16-4.fc30 libnice-0.1.16-4.fc29
Clone Of:
Environment:
Last Closed: 2019-06-13 01:14:50 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Brian J. Murrell 2019-06-04 12:27:33 UTC
Description of problem:
Ofen when connecting to an audio bridge, the connection will fail, requiring one to retry several times in order to get connected.

Version-Release number of selected component (if applicable):
0.1.16

How reproducible:
100%

Steps to Reproduce:
1. Install pidgin-sipe
2. Connect to a Skype-for-business (a.k.a. Lync) server
3. Connect to an audio bridge

Actual results:
Audio call will intermittently fail to connect

Expected results:
Should connect reliably every time

Additional info:
There is a patch upstream at https://gitlab.freedesktop.org/libnice/libnice/merge_requests/57 which fixes the issue.  It would be nice to have a build from Fedora that incorporates this patch.

FWIW, 0.1.16.1 has also subsequently been released so updating to that could include this patch.

Comment 1 Stefan Becker 2019-06-04 12:42:20 UTC
4-digit release number means "pre-release", i.e. libnice project always goes from A.B.C official release immediately to A.B.C.1 for changes on git master.

So we only need https://gitlab.freedesktop.org/libnice/libnice/commit/ca47519feda9d4dad38a06e2f7d94c0afc501364 from the merge requet.

Brian: I assume "which fixes the problem" means you verified the patch on your local machine?

Comment 2 Kamil Dudka 2019-06-04 13:10:00 UTC
Stefan, I am assigning this bug to you.  Please let me know if you need any assistance with the update!

Comment 3 Brian J. Murrell 2019-06-04 13:20:13 UTC
(In reply to Stefan Becker from comment #1)
> 4-digit release number means "pre-release", i.e. libnice project always goes
> from A.B.C official release immediately to A.B.C.1 for changes on git master.

Ahh.  OK.  I was not aware of this.  I have not seen this particular release model before.

> So we only need
> https://gitlab.freedesktop.org/libnice/libnice/commit/
> ca47519feda9d4dad38a06e2f7d94c0afc501364 from the merge requet.

Correct.
 
> Brian: I assume "which fixes the problem" means you verified the patch on
> your local machine?

Yessir.  I ran the patch for the better part of a week, joining a number of meetings during that time and every single one joined the audio bridge on the first attempt.  I didn't even have to restart pidgin after every meeting to get a higher degree of reliability (although in retrospect, that might have just been placebo effect) in joining the next meeting.

Comment 4 Fedora Update System 2019-06-04 13:29:01 UTC
FEDORA-2019-98a19f225a has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-98a19f225a

Comment 5 Fedora Update System 2019-06-04 13:30:59 UTC
FEDORA-2019-64beea4bd6 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2019-64beea4bd6

Comment 6 Fedora Update System 2019-06-05 00:32:33 UTC
libnice-0.1.16-4.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-98a19f225a

Comment 7 Fedora Update System 2019-06-05 03:05:35 UTC
libnice-0.1.16-4.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-64beea4bd6

Comment 8 Fedora Update System 2019-06-13 01:14:50 UTC
libnice-0.1.16-4.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report.

Comment 9 Fedora Update System 2019-06-13 01:38:19 UTC
libnice-0.1.16-4.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.