Description of problem: Once a custom background is uploaded and enabled on the Custom logos screen (under server settings), the background of the About modal should be updated. It no longer is. Version-Release number of selected component (if applicable): How reproducible: 100% Steps to Reproduce: 1. Upload and enable "Custom Login & 'About' Screen Background Image" on the custom logos tab under "Server Settings" 2. Go to the 'About' Modal 3. Actual results: The default RHT/MIQ background remains on the 'About' modal while the login screen is updated correctly. Expected results: The About modal should be displaying a custom background image Additional info:
David, I think this problems relates to this PR: https://github.com/ManageIQ/manageiq-ui-classic/pull/4726 and this line: https://github.com/ManageIQ/manageiq-ui-classic/pull/4726/files#diff-0056af86b4bd58050d1f8cfa73d05ae5L3 .modal-content.about-modal-pf{:class => ::Settings.server.custom_login_logo ? 'whitelabel' : ''}
Hi, in the non-react implementation the about modal was part of the DOM tree on every page render. Therefore, it was possible to add an extra CSS class that determines the custom background. In the current react-based patternfly implementation, the modal is appended to the end of the DOM tree only when needed. The best way to sort this out would be to make the AboutModal react component (provided by PF) listen to a parameter that determines its background image. Do you think we could escalate this to the PF team? I can see a possible (and very hacky) solution where we add an extra CSS class to the document's body on EVERY page if the custom login background feature is enabled. This is definitely an overkill and I would like to avoid it if possible.
As discussed, let's try the extra class for this release and approach the PF team about getting support in the PF4 component for the next release.
Issue created at PF: https://github.com/patternfly/patternfly-react/issues/2185
https://github.com/ManageIQ/manageiq-ui-classic/pull/5685
New commits detected on ManageIQ/manageiq-ui-classic/master: https://github.com/ManageIQ/manageiq-ui-classic/commit/fe7a1e71e6110ab221b911808073b54994b82ddb commit fe7a1e71e6110ab221b911808073b54994b82ddb Author: Dávid Halász <dhalasz> AuthorDate: Fri Jun 7 10:49:49 2019 -0400 Commit: Dávid Halász <dhalasz> CommitDate: Fri Jun 7 10:49:49 2019 -0400 Add an extra login class on the body on the login screen https://bugzilla.redhat.com/show_bug.cgi?id=1717116 app/assets/stylesheets/main.scss | 2 +- app/views/layouts/login.html.haml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) https://github.com/ManageIQ/manageiq-ui-classic/commit/37884f7153653eea1a99369675bc04d7d34b6637 commit 37884f7153653eea1a99369675bc04d7d34b6637 Author: Dávid Halász <dhalasz> AuthorDate: Fri Jun 7 10:55:57 2019 -0400 Commit: Dávid Halász <dhalasz> CommitDate: Fri Jun 7 10:55:57 2019 -0400 Append a class on <body> on each page if the login branding is custom Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1717116 app/assets/stylesheets/about_modal_background.scss | 9 +- app/views/layouts/application.html.haml | 2 +- 2 files changed, 7 insertions(+), 4 deletions(-)
FIXED. Verified on 5.11.0.10.20190619171116_239686f.