Bug 1717661 - python-pocketlint fails to build with Python 3.8
Summary: python-pocketlint fails to build with Python 3.8
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: python-pocketlint
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
high
Target Milestone: ---
Assignee: Jiri Konecny
QA Contact: Fedora Extras Quality Assurance
URL: https://copr.fedorainfracloud.org/cop...
Whiteboard:
Depends On: 1717662
Blocks: PYTHON38
TreeView+ depends on / blocked
 
Reported: 2019-06-05 21:44 UTC by Miro Hrončok
Modified: 2019-08-28 11:43 UTC (History)
3 users (show)

Fixed In Version: python-pocketlint-0.19-5
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-08-28 11:43:12 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Miro Hrončok 2019-06-05 21:44:35 UTC
python-pocketlint fails to build with Python 3.8.0b1. See https://copr.fedorainfracloud.org/coprs/g/python/python3.8/package/python-pocketlint/ for actual logs. This report is automated and not very verbose, but I'll get back here with details.

Comment 1 Miro Hrončok 2019-06-05 21:55:51 UTC
+ make PYTHON=/usr/bin/python3 check
*** Running pylint to verify source ***
PYTHONPATH=./build/lib /usr/bin/python3 tests/pylint/runpylint.py
************* Module pocketlint.pangocheck
E0001(syntax-error): 22,0: : Cannot import 'collections' due to syntax error 'invalid syntax (<unknown>, line 96)'
************* Module pocketlint.pangocheck
E0001(syntax-error): 22,0: : Cannot import 'collections' due to syntax error 'invalid syntax (<unknown>, line 96)'
/builddir/build/BUILD/pocketlint-0.19/build/lib/pocketlint/__init__.py:224: FutureWarning: Possible set difference at position 38
  pattern = re.compile(r"%s (?P<version>[1-9.]+)" % exc)
make: *** [Makefile:13: check] Error 2
error: Bad exit status from /var/tmp/rpm-tmp.RmaBHu (%check)

Comment 2 Jiri Konecny 2019-06-07 08:44:11 UTC
Hi Miro, 

Could you please provide me build of python3.8. I thought it is on Rawhide but it looks there is only python3.7.3.

Thanks!

Comment 3 Petr Viktorin (pviktori) 2019-06-07 08:58:48 UTC
Hello,
So far we're building in COPR, which should also have your dependencies built for Python 3.8. You can use the Mock config from https://copr.fedorainfracloud.org/coprs/g/python/python3.8/

Let me know if you need anything else.

Comment 4 Miro Hrončok 2019-06-10 16:43:15 UTC
This issue is blocking the Python 3.8 rebuilds. If this package won't build with 3.8, it won't be installable, along with all its dependent packages, after the side tag is merged.
Furthermore, as it fails to install, its dependent packages will fail to install and/or build as well. The fix should be pushed on the master branch and no release bump is required.

Testing and mass rebuild of packages is happening in copr. You can follow these instructions to test locally in mock if your package builds with Python 3.8: https://copr.fedorainfracloud.org/coprs/g/python/python3.8/

This issue needs to be resolved by next week, if other rebuilds of Python 3.8 beta 1 go well. If this is unrealistic for you, let us know how much time you need.

If you don't have free cycles to dedicate fixing your package, notify us and we'll try to provide some pointers. Let us know if we can push a fix directly without a pull request, in the case we happen to have one before you do.

We recommend always consulting with upstream, chances are this is already fixed there.

Comment 5 Jiri Konecny 2019-06-12 13:04:51 UTC
This is an issue in pylint/astroid project. I've filed an issue upstream:

https://github.com/PyCQA/astroid/issues/677


The problem is that pylint have an issue when `import collections` is in the code.

Also it looks like the astroid is not migrated to python3.8 yet. See https://github.com/PyCQA/astroid/issues/675 .

Comment 6 Miro Hrončok 2019-06-12 13:28:37 UTC
And until that is fixed, this is a problem. We need to keep this open to track it.

Comment 7 Miro Hrončok 2019-06-17 09:42:59 UTC
It seems that python3-pocketlint is no longer (build)required by anything critical. Lowering the severity to high - form the package perspective, if this is not fixed, it makes the package entirely broken. From the distro perspective, this is not that important.

Comment 8 Ben Cotton 2019-08-13 17:04:08 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 31 development cycle.
Changing version to '31'.

Comment 9 Ben Cotton 2019-08-13 18:52:21 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 31 development cycle.
Changing version to 31.

Comment 10 Miro Hrončok 2019-08-14 22:24:53 UTC
The coordinated rebuild of Python 3.8 has started in the `f32-python` side tag.

If you figure out how to rebuild this package, please don't rebuild it in regular rawhide, but use the side tag instead:

    on branch master:
    $ fedpkg build --target=f32-python

To wait for a build to show up in the side tag, do:

    $ koji wait-repo f32-python --build=<nvr>

Where <nvr> is name-version-release of the source package, e.g. python-foo-1.1-2.fc32.

An updated mock config is posted at:
http://copr.fedorainfracloud.org/coprs/g/python/python3.8/

Note that it will take a while before the essential packages are rebuilt, so don't expect all your dependencies to be available right away.

Thanks. Let us know if you need up to date info, or if you have any questions.



PS this message is mass posted to all the bugs that block the PYTHON38 bug. If this is also a Fedora 31 FTBFS bug and you manage to fix it, you can do a f31 build as usual:

    on branch f31:
    $ fedpkg build

Comment 11 Miro Hrončok 2019-08-21 16:35:40 UTC
The f32-python side tag has been merged. In order to rebuild the package, do it in regular rawhide, but please wait until python3-3.8 is tagged:

  $ koji wait-repo f32-build --build python3-3.8.0~b3-3.fc32


If your built already started in f32-python, after it is finished, please tag it to rawhide with:

  $ koji tag-build f32-pending <nvr>

For example:

  $ koji tag-build f32-pending libreoffice-6.3.0.4-3.fc32

Thanks!

(This comment is mass posted to all bugzillas blocking the PYTHON38 tracking bug.)

Comment 12 Miro Hrončok 2019-08-21 17:29:37 UTC
(Python 3.8 has landed in the rawhide buildroot.)


Note You need to log in before you can comment on or make changes to this bug.