Bug 1717664 - python-tornado fails to build with Python 3.8
Summary: python-tornado fails to build with Python 3.8
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: python-tornado
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
urgent
Target Milestone: ---
Assignee: Python SIG
QA Contact: Fedora Extras Quality Assurance
URL: https://copr.fedorainfracloud.org/cop...
Whiteboard:
Depends On:
Blocks: PYTHON38
TreeView+ depends on / blocked
 
Reported: 2019-06-05 21:44 UTC by Miro Hrončok
Modified: 2019-06-19 21:53 UTC (History)
7 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-06-19 21:53:58 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github tornadoweb tornado issues 2677 0 None None None 2019-06-18 14:50:21 UTC
Github tornadoweb tornado pull 2681 0 None None None 2019-06-19 16:20:00 UTC

Description Miro Hrončok 2019-06-05 21:44:50 UTC
python-tornado fails to build with Python 3.8.0b1. See https://copr.fedorainfracloud.org/coprs/g/python/python3.8/package/python-tornado/ for actual logs. This report is automated and not very verbose, but I'll get back here with details.

Comment 1 Miro Hrončok 2019-06-05 22:02:13 UTC
[E 190605 19:10:32 runtests:210] logged 0 infos, 0 warnings, 4 errors, and 2516 bytes to stderr
error: Bad exit status from /var/tmp/rpm-tmp.4FLcgx (%check)

The errors look like:

[E 190605 19:10:24 base_events:1692] Exception in callback with_timeout.<locals>.error_callback(<Future cancelled>) at /builddir/build/BUILD/tornado-5.1.1/tornado/gen.py:968
    handle: <Handle with_timeout.<locals>.error_callback(<Future cancelled>) at /builddir/build/BUILD/tornado-5.1.1/tornado/gen.py:968>
    Traceback (most recent call last):
      File "/usr/lib64/python3.8/asyncio/events.py", line 81, in _run
        self._context.run(self._callback, *self._args)
      File "/builddir/build/BUILD/tornado-5.1.1/tornado/gen.py", line 970, in error_callback
        future.result()
    asyncio.exceptions.CancelledError

Comment 2 Miro Hrončok 2019-06-10 12:21:30 UTC
tornado 6.0.2 does not fix this:

test_event_timeout (tornado.test.locks_test.EventTest) ... [E 190610 11:43:57 base_events:1692] Exception in callback with_timeout.<locals>.error_callback(<Future cancelled>) at /builddir/build/BUILD/tornado-6.0.2/tornado/gen.py:587
    handle: <Handle with_timeout.<locals>.error_callback(<Future cancelled>) at /builddir/build/BUILD/tornado-6.0.2/tornado/gen.py:587>
    Traceback (most recent call last):
      File "/usr/lib64/python3.8/asyncio/events.py", line 81, in _run
        self._context.run(self._callback, *self._args)
      File "/builddir/build/BUILD/tornado-6.0.2/tornado/gen.py", line 589, in error_callback
        future.result()
    asyncio.exceptions.CancelledError
ok

Comment 3 Miro Hrončok 2019-06-10 16:43:47 UTC
This issue is blocking the Python 3.8 rebuilds. If this package won't build with 3.8, it won't be installable, along with all its dependent packages, after the side tag is merged.
Furthermore, as it fails to install, its dependent packages will fail to install and/or build as well. The fix should be pushed on the master branch and no release bump is required.

Testing and mass rebuild of packages is happening in copr. You can follow these instructions to test locally in mock if your package builds with Python 3.8: https://copr.fedorainfracloud.org/coprs/g/python/python3.8/

This issue needs to be resolved by next week, if other rebuilds of Python 3.8 beta 1 go well. If this is unrealistic for you, let us know how much time you need.

Comment 4 Miro Hrončok 2019-06-19 21:53:58 UTC
Pushed https://github.com/tornadoweb/tornado/pull/2681


Note You need to log in before you can comment on or make changes to this bug.