Bug 1717843 - [RFE] `Request is required` for button create in ansible while it is in Advanced tab
Summary: [RFE] `Request is required` for button create in ansible while it is in Advan...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: UI - OPS
Version: 5.10.0
Hardware: x86_64
OS: Linux
low
low
Target Milestone: GA
: 5.11.0
Assignee: Zita Nemeckova
QA Contact: Jaroslav Henner
Red Hat CloudForms Documentation
URL:
Whiteboard:
: 1717844 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-06-06 10:23 UTC by Jaroslav Henner
Modified: 2020-01-14 11:41 UTC (History)
9 users (show)

Fixed In Version: 5.11.0.19
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-12-12 13:36:36 UTC
Category: Feature
Cloudforms Team: CFME Core
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2019:4199 0 None None None 2019-12-12 13:36:48 UTC

Comment 2 John Prause 2019-06-06 13:38:12 UTC
*** Bug 1717844 has been marked as a duplicate of this bug. ***

Comment 3 drew uhlmann 2019-06-10 12:52:54 UTC
Hey Harpreet, I don't think this requires backend changes. Isn't the fix for this a UI change only?

Comment 6 CFME Bot 2019-08-07 15:42:09 UTC
New commit detected on ManageIQ/manageiq-ui-classic/master:

https://github.com/ManageIQ/manageiq-ui-classic/commit/a0760fcb90830c3301216d548f2fb6d2ed715864
commit a0760fcb90830c3301216d548f2fb6d2ed715864
Author:     Zita Nemeckova <znemecko>
AuthorDate: Thu Jul 25 08:03:08 2019 -0400
Commit:     Zita Nemeckova <znemecko>
CommitDate: Thu Jul 25 08:03:08 2019 -0400

    Switch to Advanced tab when only error is request is required

    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1717843

 app/controllers/application_controller/buttons.rb | 29 +-
 1 file changed, 25 insertions(+), 4 deletions(-)

Comment 7 CFME Bot 2019-08-07 22:37:42 UTC
New commit detected on ManageIQ/manageiq-ui-classic/ivanchuk:

https://github.com/ManageIQ/manageiq-ui-classic/commit/907631a0294372ae6f50eba735a349b81f2b3caa
commit 907631a0294372ae6f50eba735a349b81f2b3caa
Author:     Harpreet Kataria <hkataria>
AuthorDate: Wed Aug  7 11:41:32 2019 -0400
Commit:     Harpreet Kataria <hkataria>
CommitDate: Wed Aug  7 11:41:32 2019 -0400

    Merge pull request #5873 from ZitaNemeckova/fix_cb_tabs

    Switch to Advanced tab when only error is "Request is required"

    (cherry picked from commit 88b4b54e8c037eab2114233538f45eedcf7e6520)

    https://bugzilla.redhat.com/show_bug.cgi?id=1717843

 app/controllers/application_controller/buttons.rb | 34 +-
 app/views/shared/buttons/_ab_advanced_form.html.haml | 2 +-
 spec/controllers/application_controller/buttons_spec.rb | 4 +-
 3 files changed, 31 insertions(+), 9 deletions(-)

Comment 8 Jaroslav Henner 2019-08-29 11:01:35 UTC
Well I cannot say I like the way it is solved.

When I try to save, several warnings pop up. I change one thing and all the warnings disappear. I click add, rest of the warnings appear. I change other field, all warnings disappear. I click add... I am redirected to Advanced. So it sort of works, but warnings appearing and disappearing is not much user friendly as if I want to fix all the problems at once, I need to remember all the messages to find all the fields that are failing validation.

Comment 10 errata-xmlrpc 2019-12-12 13:36:36 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2019:4199


Note You need to log in before you can comment on or make changes to this bug.