RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1718172 - NULL pointer access in qemuProcessInitCpuAffinity()
Summary: NULL pointer access in qemuProcessInitCpuAffinity()
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: libvirt
Version: 7.7
Hardware: All
OS: Linux
high
high
Target Milestone: rc
: ---
Assignee: Andrea Bolognani
QA Contact: jiyan
URL:
Whiteboard:
: 1719558 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-06-07 07:57 UTC by Andrea Bolognani
Modified: 2019-08-06 13:15 UTC (History)
9 users (show)

Fixed In Version: libvirt-4.5.0-22.el7
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-08-06 13:14:55 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2019:2294 0 None None None 2019-08-06 13:15:37 UTC

Description Andrea Bolognani 2019-06-07 07:57:42 UTC 
The fix for Bug 1703661 included, itself, a bug which will result in
a NULL pointer access. We should make sure RHEL 7.7 doesn't include
this bug when it ships.

A fix has already been committed upstream as

  commit a84922c09e9e1a0ca4f8fb1e8b4b1c7b55bd79e9
  Author: Andrea Bolognani <abologna>
  Date:   Thu Jun 6 15:38:29 2019 +0200

    qemu: Fix NULL pointer access in qemuProcessInitCpuAffinity()

    Commit 2f2254c7f4e5 attempted to fix a memory leak by ensuring
    cpumapToSet is always a freshly allocated bitmap, but regrettably
    introduced a NULL pointer access while doing so, because it called
    virBitmapCopy() without allocating the destination bitmap first.

    Solve the issue by using virBitmapNewCopy() instead.

    Reported-by: John Ferlan <jferlan>
    Signed-off-by: Andrea Bolognani <abologna>
    Reviewed-by: Erik Skultety <eskultet>
    Reviewed-by: John Ferlan <jferlan>

  v5.4.0-55-ga84922c09e

so addressing this bug is going to be just a matter of backporting a
trivial patch.
Comment 6 Andrea Bolognani 2019-06-12 07:47:17 UTC 
*** Bug 1719558 has been marked as a duplicate of this bug. ***
Comment 8 jiyan 2019-06-17 09:05:39 UTC 
According to patch, this only affects emulatorpin.

Reproduced this issue on libvirt-4.5.0-21.el7.x86_64 by starting VM with emulatorpin conf

S1:
# virsh domstate q35
shut off

# virsh dumpxml q35 --inactive |grep "<vcpu" -A5
  <vcpu placement='static' current='5'>7</vcpu>
  <cputune>
    <emulatorpin cpuset='1-3'/>
  </cputune>

# virsh start q35
error: Disconnected from qemu:///system due to end of file
error: Failed to start domain q35
error: End of file while reading data: Input/output error


S2: 
# virsh domstate q35
shut off

# virsh dumpxml q35 --inactive |grep "<vcpu" -A2
  <vcpu placement='static' current='5'>7</vcpu>
  No emulatorpin conf
 
# virsh start q35
Domain q35 started

# virsh emulatorpin q35 1-3

# virsh emulatorpin q35 1-3 --config

# virsh destroy q35
Domain q35 destroyed

# virsh start q35
error: Disconnected from qemu:///system due to end of file
error: Failed to start domain q35
error: End of file while reading data: Input/output error
Comment 9 jiyan 2019-06-17 09:07:30 UTC 
Verified this bug on libvirt-4.5.0-22.el7.x86_64

Version:
kernel-3.10.0-1056.el7.x86_64
libvirt-4.5.0-22.el7.x86_64
qemu-kvm-rhev-2.12.0-32.el7.x86_64

Steps:
1. Prepare a shutdown VM with the following conf
# virsh domstate q35
shut off

# virsh dumpxml q35|grep "<vcpu" -A3
  <vcpu placement='static'>7</vcpu>
  <cputune>
    <emulatorpin cpuset='1-3'/>
  </cputune>

2. Start the VM and check the emulatorpin info and related XML
# virsh start q35
Domain q35 started

# virsh emulatorpin q35
emulator: CPU Affinity
----------------------------------
       *: 1-3

# virsh dumpxml q35|grep "<vcpu" -A4
  <vcpu placement='static'>7</vcpu>
  <cputune>
    <emulatorpin cpuset='1-3'/>
  </cputune>
Comment 11 errata-xmlrpc 2019-08-06 13:14:55 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2019:2294
Note You need to log in before you can comment on or make changes to this bug.