Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1718848

Summary:	False positive logging of mount failure
Product:	[Community] GlusterFS	Reporter:	Atin Mukherjee <amukherj>
Component:	glusterd	Assignee:	Sanju <srakonde>
Status:	CLOSED NEXTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	mainline	CC:	bugs, pasik
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-06-17 10:31:46 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Atin Mukherjee 2019-06-10 12:02:25 UTC

Description of problem:

Even on successful mount attempts seeing false positive logging:

[2019-06-09 18:18:16.079101] E [MSGID: 106176] [glusterd-handshake.c:1038:__server_getspec] 0-management: Failed to mount the volume 


I believe not every time rsp.op_ret will be 0 in case successful mounts. This needs to be cross checked on why we're logging this unnecessarily. While running subdir-mount.t test caught this log entry.



Version-Release number of selected component (if applicable):
mainline

How reproducible:
always

Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Atin Mukherjee 2019-06-10 12:03:34 UTC

d42221bec9 (Sanju Rakonde           2019-05-08 07:58:27 +0530 1036)     if (rsp.op_ret)
d42221bec9 (Sanju Rakonde           2019-05-08 07:58:27 +0530 1037)         gf_msg(this->name, GF_LOG_ERROR, 0, GD_MSG_MOUNT_REQ_FAIL,
d42221bec9 (Sanju Rakonde           2019-05-08 07:58:27 +0530 1038)                "Failed to mount the volume")

Was introduced by commit d42221bec9 .

Comment 2 Worker Ant 2019-06-13 13:43:39 UTC

REVIEW: https://review.gluster.org/22860 (glusterd: assign zero to ret on successful sys_read()) posted (#1) for review on master by Sanju Rakonde

Comment 3 Worker Ant 2019-06-17 10:31:46 UTC

REVIEW: https://review.gluster.org/22860 (glusterd: log error message only when rsp.op_ret is negative) merged (#5) on master by Amar Tumballi