Description of problem:
Even on successful mount attempts seeing false positive logging:
[2019-06-09 18:18:16.079101] E [MSGID: 106176] [glusterd-handshake.c:1038:__server_getspec] 0-management: Failed to mount the volume
I believe not every time rsp.op_ret will be 0 in case successful mounts. This needs to be cross checked on why we're logging this unnecessarily. While running subdir-mount.t test caught this log entry.
Version-Release number of selected component (if applicable):
Steps to Reproduce:
d42221bec9 (Sanju Rakonde 2019-05-08 07:58:27 +0530 1036) if (rsp.op_ret)
d42221bec9 (Sanju Rakonde 2019-05-08 07:58:27 +0530 1037) gf_msg(this->name, GF_LOG_ERROR, 0, GD_MSG_MOUNT_REQ_FAIL,
d42221bec9 (Sanju Rakonde 2019-05-08 07:58:27 +0530 1038) "Failed to mount the volume")
Was introduced by commit d42221bec9 .
REVIEW: https://review.gluster.org/22860 (glusterd: assign zero to ret on successful sys_read()) posted (#1) for review on master by Sanju Rakonde
REVIEW: https://review.gluster.org/22860 (glusterd: log error message only when rsp.op_ret is negative) merged (#5) on master by Amar Tumballi