Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1718851

Summary:	[RFE] Unmanaged disks should be kept after VM restart/poweroff
Product:	[oVirt] ovirt-engine	Reporter:	Ryan Barry <rbarry>
Component:	BLL.Virt	Assignee:	Tomasz Barański <tbaransk>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Nisim Simsolo <nsimsolo>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	future	CC:	bugs, michal.skrivanek
Target Milestone:	ovirt-4.4.0	Keywords:	CodeChange, FutureFeature
Target Release:	---	Flags:	rbarry: ovirt-4.4? pm-rhel: planning_ack? pm-rhel: devel_ack+ pm-rhel: testing_ack+
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	No Doc Update
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-05-20 20:03:10 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Virt	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Ryan Barry 2019-06-10 12:07:56 UTC

Description of problem:
Currently, any unmanaged disks added to a VM are discarded when the VM is stopped or rebooted and the XML is regenerated. We should keep track of these in unmanaged/plugged devices so the VM remains consistent without user intervention

Comment 1 Michal Skrivanek 2019-06-11 10:05:29 UTC

They're not useful per se, but it helps to see them kept when VM is Down in VM Devices tab.
The major thing is not to return early in VmDevicesConverter for each device, this triggers a problem that the device is not found during devices monitoring and gets "unplugged"

Comment 2 Tomasz Barański 2019-09-12 08:54:39 UTC

(In reply to Ryan Barry from comment #0)
> Description of problem:
> Currently, any unmanaged disks added to a VM are discarded when the VM is
> stopped or rebooted and the XML is regenerated. We should keep track of
> these in unmanaged/plugged devices so the VM remains consistent without user
> intervention

What are the steps to recreate the problem?

Comment 3 Ryan Barry 2019-09-12 16:57:57 UTC

If vdsm-hook-hostdev_scsi is used, then the VM is rebooted, the disk is missing. Sure, the hook is optional, but this is the easiest reproducer to demonstrate

Comment 4 Ryan Barry 2019-12-03 15:08:53 UTC

The only known reproducer was vdsm-hook-hostdev-scsi, which is now dropped. Moving to CodeChange->VERIFIED based on the code

Comment 5 Sandro Bonazzola 2020-05-20 20:03:10 UTC

This bugzilla is included in oVirt 4.4.0 release, published on May 20th 2020.

Since the problem described in this bug report should be
resolved in oVirt 4.4.0 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.