Spec URL: https://luhliarik.fedorapeople.org/mod_md.spec SRPM URL: https://luhliarik.fedorapeople.org/mod_md-2.0.3-1.fc31.src.rpm Description: This module manages common properties of domains for one or more virtual hosts. Specifically it can use the ACME protocol (RFC Draft) to automate certificate provisioning. These will be configured for managed domains and their virtual hosts automatically. This includes renewal of certificates before they expire. Fedora Account System Username: luhliarik
ackage Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package installs properly. Note: Installation errors (see attachment) See: https://docs.fedoraproject.org/en-US/packaging-guidelines/ ===== MUST items ===== C/C++: [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [ ]: Rpath absent or only used for internal libs. Note: See rpmlint output [ ]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) Generic: [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "FSF All Permissive License", "*No copyright* Apache License (v2.0)", "Apache License (v2.0)", "Expat License", "GPL (v3 or later)", "FSF Unlimited License (with Retention) GNU General Public License", "FSF Unlimited License (with Retention)", "*No copyright* Public domain". 135 files have unknown license. Detailed output of licensecheck in /home/yarda/1719248-mod_md/licensecheck.txt [ ]: License file installed when any subpackage combination is installed. [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 92160 bytes in 3 files. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in mod_md [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Rpmlint is run on all installed packages. Note: Mock build failed See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_use_rpmlint [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Installation errors ------------------- INFO: mock.py version 1.4.15 starting (python version = 3.7.3)... Start: init plugins INFO: selinux disabled Finish: init plugins Start: run Start: chroot init INFO: calling preinit hooks INFO: enabled root cache INFO: enabled dnf cache Start: cleaning dnf metadata Finish: cleaning dnf metadata INFO: enabled HW Info plugin Mock Version: 1.4.15 INFO: Mock Version: 1.4.15 Finish: chroot init INFO: installing package(s): /home/yarda/1719248-mod_md/results/mod_md-debuginfo-2.0.3-1.fc31.x86_64.rpm /home/yarda/1719248-mod_md/results/mod_md-2.0.3-1.fc31.x86_64.rpm /home/yarda/1719248-mod_md/results/mod_md-debugsource-2.0.3-1.fc31.x86_64.rpm ERROR: Command failed: # /usr/bin/dnf --installroot /var/lib/mock/fedora-rawhide-x86_64/root/ --releasever 31 --setopt=deltarpm=False --disableplugin=local --disableplugin=spacewalk install /home/yarda/1719248-mod_md/results/mod_md-debuginfo-2.0.3-1.fc31.x86_64.rpm /home/yarda/1719248-mod_md/results/mod_md-2.0.3-1.fc31.x86_64.rpm /home/yarda/1719248-mod_md/results/mod_md-debugsource-2.0.3-1.fc31.x86_64.rpm Rpmlint ------- Checking: mod_md-2.0.3-1.fc31.x86_64.rpm mod_md-debuginfo-2.0.3-1.fc31.x86_64.rpm mod_md-debugsource-2.0.3-1.fc31.x86_64.rpm mod_md-2.0.3-1.fc31.src.rpm mod_md.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/a2md ['/usr/lib64'] mod_md.x86_64: W: no-manual-page-for-binary a2md mod_md-debuginfo.x86_64: W: spelling-error Summary(en_US) md -> MD, Md, ms mod_md-debuginfo.x86_64: W: spelling-error %description -l en_US md -> MD, Md, ms mod_md-debugsource.x86_64: W: spelling-error Summary(en_US) md -> MD, Md, ms mod_md-debugsource.x86_64: W: spelling-error %description -l en_US md -> MD, Md, ms 4 packages and 0 specfiles checked; 1 errors, 5 warnings. Unversioned so-files -------------------- mod_md: /usr/lib64/httpd/modules/mod_md.so Source checksums ---------------- https://github.com/icing/mod_md/releases/download/v2.0.3/mod_md-2.0.3.tar.gz : CHECKSUM(SHA256) this package : 55ab6f980fcf4951f929c12df6dc8381a06594cd96a36271882b7a26c2f981ae CHECKSUM(SHA256) upstream package : 55ab6f980fcf4951f929c12df6dc8381a06594cd96a36271882b7a26c2f981ae Requires -------- mod_md (rpmlib, GLIBC filtered): config(mod_md) httpd-mmn libapr-1.so.0()(64bit) libaprutil-1.so.0()(64bit) libc.so.6()(64bit) libcrypto.so.1.1()(64bit) libcrypto.so.1.1(OPENSSL_1_1_0)(64bit) libcrypto.so.1.1(OPENSSL_1_1_1)(64bit) libcurl.so.4()(64bit) libjansson.so.4()(64bit) libpthread.so.0()(64bit) libssl.so.1.1()(64bit) rtld(GNU_HASH) mod_md-debuginfo (rpmlib, GLIBC filtered): mod_md-debugsource (rpmlib, GLIBC filtered): Provides -------- mod_md: config(mod_md) mod_md mod_md(x86-64) mod_md-debuginfo: debuginfo(build-id) mod_md-debuginfo mod_md-debuginfo(x86-64) mod_md-debugsource: mod_md-debugsource mod_md-debugsource(x86-64) Generated by fedora-review 0.7.2 (65d36bb) last change: 2019-04-09 Command line :/usr/bin/fedora-review -b 1719248 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic, C/C++ Disabled plugins: PHP, fonts, R, Perl, Haskell, SugarActivity, Python, Java, Ocaml Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
Please fix the rpath
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package installs properly. Note: Installation errors (see attachment) See: https://docs.fedoraproject.org/en-US/packaging-guidelines/ ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [-]: Rpath absent or only used for internal libs. Note: See rpmlint output [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. Probably OK, module dir, private. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "FSF All Permissive License", "*No copyright* Apache License (v2.0)", "Apache License (v2.0)", "Expat License", "GPL (v3 or later)", "FSF Unlimited License (with Retention) GNU General Public License", "FSF Unlimited License (with Retention)", "*No copyright* Public domain". 135 files have unknown license. Detailed output of licensecheck in /home/yarda/1719248-mod_md/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [-]: Package does not generate any conflict. I am unable to install it [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 92160 bytes in 3 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in mod_md [?]: Package functions as described. [x]: Latest version is packaged. It seems to be the latest stable. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [?]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [?]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Rpmlint is run on all installed packages. Note: Mock build failed See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_use_rpmlint [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Installation errors ------------------- INFO: mock.py version 1.4.15 starting (python version = 3.7.3)... Start: init plugins INFO: selinux disabled Finish: init plugins Start: run Start: chroot init INFO: calling preinit hooks INFO: enabled root cache INFO: enabled dnf cache Start: cleaning dnf metadata Finish: cleaning dnf metadata INFO: enabled HW Info plugin Mock Version: 1.4.15 INFO: Mock Version: 1.4.15 Finish: chroot init INFO: installing package(s): /home/yarda/1719248-mod_md/results/mod_md-debuginfo-2.0.3-1.fc31.x86_64.rpm /home/yarda/1719248-mod_md/results/mod_md-2.0.3-1.fc31.x86_64.rpm /home/yarda/1719248-mod_md/results/mod_md-debugsource-2.0.3-1.fc31.x86_64.rpm ERROR: Command failed: # /usr/bin/dnf --installroot /var/lib/mock/fedora-rawhide-x86_64/root/ --releasever 31 --setopt=deltarpm=False --disableplugin=local --disableplugin=spacewalk install /home/yarda/1719248-mod_md/results/mod_md-debuginfo-2.0.3-1.fc31.x86_64.rpm /home/yarda/1719248-mod_md/results/mod_md-2.0.3-1.fc31.x86_64.rpm /home/yarda/1719248-mod_md/results/mod_md-debugsource-2.0.3-1.fc31.x86_64.rpm Rpmlint ------- Checking: mod_md-2.0.3-1.fc31.x86_64.rpm mod_md-debuginfo-2.0.3-1.fc31.x86_64.rpm mod_md-debugsource-2.0.3-1.fc31.x86_64.rpm mod_md-2.0.3-1.fc31.src.rpm mod_md.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/a2md ['/usr/lib64'] mod_md.x86_64: W: no-manual-page-for-binary a2md mod_md-debuginfo.x86_64: W: spelling-error Summary(en_US) md -> MD, Md, ms mod_md-debuginfo.x86_64: W: spelling-error %description -l en_US md -> MD, Md, ms mod_md-debugsource.x86_64: W: spelling-error Summary(en_US) md -> MD, Md, ms mod_md-debugsource.x86_64: W: spelling-error %description -l en_US md -> MD, Md, ms 4 packages and 0 specfiles checked; 1 errors, 5 warnings. Unversioned so-files -------------------- mod_md: /usr/lib64/httpd/modules/mod_md.so Source checksums ---------------- https://github.com/icing/mod_md/releases/download/v2.0.3/mod_md-2.0.3.tar.gz : CHECKSUM(SHA256) this package : 55ab6f980fcf4951f929c12df6dc8381a06594cd96a36271882b7a26c2f981ae CHECKSUM(SHA256) upstream package : 55ab6f980fcf4951f929c12df6dc8381a06594cd96a36271882b7a26c2f981ae Requires -------- mod_md (rpmlib, GLIBC filtered): config(mod_md) httpd-mmn libapr-1.so.0()(64bit) libaprutil-1.so.0()(64bit) libc.so.6()(64bit) libcrypto.so.1.1()(64bit) libcrypto.so.1.1(OPENSSL_1_1_0)(64bit) libcrypto.so.1.1(OPENSSL_1_1_1)(64bit) libcurl.so.4()(64bit) libjansson.so.4()(64bit) libpthread.so.0()(64bit) libssl.so.1.1()(64bit) rtld(GNU_HASH) mod_md-debuginfo (rpmlib, GLIBC filtered): mod_md-debugsource (rpmlib, GLIBC filtered): Provides -------- mod_md: config(mod_md) mod_md mod_md(x86-64) mod_md-debuginfo: debuginfo(build-id) mod_md-debuginfo mod_md-debuginfo(x86-64) mod_md-debugsource: mod_md-debugsource mod_md-debugsource(x86-64) Generated by fedora-review 0.7.2 (65d36bb) last change: 2019-04-09 Command line :/usr/bin/fedora-review -b 1719248 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic, C/C++ Disabled plugins: PHP, fonts, R, Perl, Haskell, SugarActivity, Python, Java, Ocaml Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
- please fix the rpath in /usr/bin/a2md - please make the build verbose, i.e. use the following in the spec (V=1): %make_build V=1 - I am unable to install the package Error: Problem: package mod_md-2.0.3-1.fc29.x86_64 requires httpd-mmn = 20120211x8664, but none of the providers can be installed - package mod_md-2.0.3-1.fc29.x86_64 conflicts with httpd < 2.4.39-5 provided by httpd-2.4.39-3.fc29.x86_64 - package mod_md-2.0.3-1.fc29.x86_64 conflicts with httpd < 2.4.39-5 provided by httpd-2.4.34-8.fc29.x86_64 - conflicting requests - There is typo in the changelog (it's different bugzilla): Initial import (#1440780). - There is unused patch mentioned in the spec - could you run the tests?
(In reply to Jaroslav Škarvada from comment #4) > - please fix the rpath in /usr/bin/a2md - fixed > - please make the build verbose, i.e. use the following in the spec (V=1): > %make_build V=1 - fixed > - I am unable to install the package > Error: > Problem: package mod_md-2.0.3-1.fc29.x86_64 requires httpd-mmn = > 20120211x8664, but none of the providers can be installed > - package mod_md-2.0.3-1.fc29.x86_64 conflicts with httpd < 2.4.39-5 > provided by httpd-2.4.39-3.fc29.x86_64 > - package mod_md-2.0.3-1.fc29.x86_64 conflicts with httpd < 2.4.39-5 > provided by httpd-2.4.34-8.fc29.x86_64 > - conflicting requests - you are unabled to install it, since we don't have httpd without mod_md yet. As soon as this package is reviewed, I will build httpd package (2.4.39-5) without bundled mod_md. > - There is typo in the changelog (it's different bugzilla): - fixed > Initial import (#1440780). > - There is unused patch mentioned in the spec - fixed (removed comment) > - could you run the tests? - fixed
I guess you added the epoch to resolve the versioning conflict. One minor thing: - rm -r %{buildroot}%{_httpd_moddir}/mod_md.so, why is there '-r'? shouldn't it be '-f' instead? Otherwise LGTM.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/mod_md
Rawhide build: https://koji.fedoraproject.org/koji/buildinfo?buildID=1287168