Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.
RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.

Bug 1719331

Summary: thin_trim manpage has obsolete infomation about --pool-inactive option
Product: Red Hat Enterprise Linux 8 Reporter: Jakub Krysl <jkrysl>
Component: device-mapper-persistent-dataAssignee: Joe Thornber <thornber>
Status: CLOSED ERRATA QA Contact: Lin Li <lilin>
Severity: unspecified Docs Contact:
Priority: low    
Version: 8.1CC: agk, heinzm, jbrassow, lvm-team, mcsontos, msnitzer, thornber
Target Milestone: rcFlags: pm-rhel: mirror+
Target Release: 8.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: device-mapper-persistent-data-0.8.5-3.el8 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-04-28 16:58:19 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Jakub Krysl 2019-06-11 14:12:20 UTC
Description of problem:
The --pool-inactive information in thin_trim manpage seems to be outdated as using that option produces warning message instead of supressing it.
       --pool-inactive
              Indicates you are aware the pool should be inactive.

           Suppresses a warning message and prompt.

# thin_trim --pool-inactive  --data-dev '/dev/mapper/vgtest-swapvol' --metadata-dev '/tmp/metadata_repair'                                       
--pool-inactive no longer required since we ensure the metadata device is opened exclusively.
in trim
emitting discard for blocks (209, 1600]

Also the option itself is no longer required:
# thin_trim --data-dev '/dev/mapper/vgtest-swapvol' --metadata-dev '/tmp/metadata_repair'
in trim
emitting discard for blocks (209, 1600]

Version-Release number of selected component (if applicable):
device-mapper-persistent-data-0.7.6-1.el8.x86_64

How reproducible:
100%

Steps to Reproduce:
1. man thin_trim
2. thin_trim --pool-inactive  --data-dev '/dev/mapper/vgtest-swapvol' --metadata-dev '/tmp/metadata_repair'

Actual results:
obsolete infomration in manpage

Expected results:
correct information in manpage

Additional info:

Comment 1 Jakub Krysl 2019-10-02 11:41:03 UTC
Mass migration to lilin.

Comment 3 Marian Csontos 2019-11-27 09:05:26 UTC
*** Bug 1774000 has been marked as a duplicate of this bug. ***

Comment 5 Lin Li 2019-11-29 01:18:14 UTC
Reproduced on device-mapper-persistent-data-0.8.5-2.el8
1,[root@storageqe-25 ~]# rpm -qa | grep device-mapper-persistent-data
device-mapper-persistent-data-0.8.5-2.el8.x86_64

2,[root@storageqe-25 ~]# man thin_trim
OPTIONS
       -h, --help
              Print help and exit.

       -V, --version
              Print version information and exit.

       --pool-inactive
              Indicates you are aware the pool should be inactive.

           Suppresses a warning message and prompt.

3,[root@storageqe-25 ~]# thin_trim --pool-inactive  --data-dev '/dev/mapper/vgtest-swapvol' --metadata-dev '/tmp/metadata_repair'
--pool-inactive no longer required since we ensure the metadata device is opened exclusively.
in trim
Couldn't stat path



Verified on device-mapper-persistent-data-0.8.5-3.el8
1,[root@storageqe-25 ~]# rpm -qa | grep device-mapper-persistent-data
device-mapper-persistent-data-0.8.5-3.el8.x86_64

2,[root@storageqe-25 ~]# man thin_trim
OPTIONS
       -h, --help
              Print help and exit.

       -V, --version
              Print version information and exit.
<------------------------------------------------------------------ no --pool-inactive option




Test result:thin_trim manpage no longer has information about --pool-inactive option

Comment 7 errata-xmlrpc 2020-04-28 16:58:19 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:1873