Red Hat Bugzilla – Bug 171954
notification api needs another arg
Last modified: 2013-03-13 00:49:14 EDT
...to make nice warning dialogs with primary and secondary text.
How do you mean "primary" and "secondary"? Have you got an example please. Also,
is this with libnotify or the gtk fallback? Thanks.
sorry, the bug is terse, but caillon knows.
GtkMessageDialog has primary and secodary text arguments. Right now, we only
really use the secondary. We should also include another argument to set the
primary text. See http://www.gnome.org/~caillon/gpm-dialog.png for an example
of what the dialog should look like. The libnotify stuff should also include
this, but I'm not sure what the API will look like for that. J5?
I looked through gpm-main.c to implement this, and I must say, I'm confused as
to why we are sending notifications of many things. "Power button pressed"?
Not sure why any user would care to get notified of that ever. "Duh, I just
pushed the button." Is that something that a g_debug () would be better suited for?
Yes we must go and destroy any bad notifications :-) Actually the only time
notification should be used is for battery low, perhaps battery full and
switching form battery/power. http://www.galago-project.org/downloads.php for
the current libnotify sources. I'm working on a replacement and have asked for
an svn account from chris hammond.
First cut at a patch is
It's untested, other than it compiles for me.
Patch looks good, and I agree we shouldn't do as many notifications as we are
doing. The Powerbutton pressed stuff was more for debugging and so should be
As for the primary and secodary text arguments, I see what you mean now.
Overall, patch looks good to me.
Hi, I made sure things work fine and just committed this patch with one slight
modification (forgot to use the new parameter with libnotify) to GNOME CVS.
Is in upstream cvs now, so I think we can close this bug.