Bug 1719991
| Summary: | Add nfsclient.ops.<opname>.errors - a new count of RPC ops completing with errors in /proc/self/mountstats for NFS | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Linux 8 | Reporter: | Dave Wysochanski <dwysocha> |
| Component: | pcp | Assignee: | Nathan Scott <nathans> |
| Status: | CLOSED DUPLICATE | QA Contact: | Jan Kurik <jkurik> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 8.0 | CC: | agerstmayr, jkurik, mgoodwin, nathans, patrickm |
| Target Milestone: | rc | ||
| Target Release: | 8.2 | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2019-10-10 23:48:32 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1636572 | ||
| Bug Blocks: | |||
| Attachments: | |||
|
Description
Dave Wysochanski
2019-06-12 21:48:33 UTC
Thanks for the heads-up Dave. Could you attach a /proc/mountstats file with the new output format please, if you have a machine running a patched kernel with some NFS mounts handy? (we'll use this for regression testing) cheers. Created attachment 1580252 [details]
Normal RHEL8 mountstats with NFSv3, 4.0, 4.1, and 4.2 shares mounted
Created attachment 1580253 [details]
Patched RHEL8 mountstats showing RPC iostat version 1.1 and 9th column of numbers, with NFSv3, 4.0, 4.1, and 4.2 shares mounted
Thanks Dave, I'll get onto implementing this shortly. Dave, I see in your mountstats.py patch in the nfs-utils BZ (1719983) ...
- print('\t%d ops (%d%%)' % \
- (count, ((count * 100) / sends)), end=' ')
+ print('\t%d ops (%d%%) %d completions %d xmits %d errors' % \
+ (count, ((count * 100) / sends), stats[2], stats[10], stats[9]), end=' ')
This suggests there's another metric patch lurking somewhere for the metric reported above as 'xmits'. However I don't see this in Tronds tree (and mainline has neither yet). Is this tenth field going to be added to the kernel, as this userspace patch suggests?
Thanks.
Nathan, No for now I abandoned the work to try to split out "completions" and "transmissions" and I never submitted those kernel patches, only the error count patches. Also the one nfs-utils patch that has been merged is for the extra error count so there's only one extra count being added: http://git.linux-nfs.org/?p=steved/nfs-utils.git;a=commitdiff;h=73491ef272f9131888ef9f45207abbc2055d6aae I also have a few more nfs-utils patches for other tools that are waiting to be merged. Those just fixup other tools though for the 'errors' count: https://bugzilla.redhat.com/show_bug.cgi?id=1719983#c1 Fixed upstream, will aim for inclusion in 8.2
commit c81f8ee0fd0166b0427fb6aaa9963f4f3c095288
Author: Nathan Scott <nathans>
Date: Tue Jun 18 08:16:39 2019 +1000
pmdanfsclient: add per-op, per-mount rpc errors metrics
Resolves Red Hat BZ #1719991
This commit is part of the PCP rebase for 8.2 and does not require special QE attention - marking it as a duplicate. *** This bug has been marked as a duplicate of bug 1723598 *** |