Bug 1720143 - perl-Redis-1.991-10.fc31FTBFS: line 45: kill: (20250) - No such process
Summary: perl-Redis-1.991-10.fc31FTBFS: line 45: kill: (20250) - No such process
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: rpm
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Packaging Maintenance Team
QA Contact: Fedora Extras Quality Assurance
URL: https://apps.fedoraproject.org/kosche...
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-06-13 08:55 UTC by Petr Pisar
Modified: 2019-06-13 10:18 UTC (History)
8 users (show)

Fixed In Version: rpm-4.14.90-0.git14653.14.fc31
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-06-13 10:18:19 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Petr Pisar 2019-06-13 08:55:22 UTC
perl-Redis-1.991-10.fc31 fails to build in F31:

+ make test
+ redis-server -
BUILDSTDERR:     # child is ready to test, signal parent to kill our server
BUILDSTDERR:     # parent killed pub/sub redis server, signal child to proceed
BUILDSTDERR:     # now, check wait_for_messages(), should die...
BUILDSTDERR:     # parent waiting for child 20292...
BUILDSTDERR:     # CHILD: reconnected (with a 10s timeout)
BUILDSTDERR:     # CHILD: is ready to test, signal parent to restart our server
BUILDSTDERR:     # PARENT: killed pub/sub redis server, signal child to proceed
BUILDSTDERR:     # CHILD: launch wait_for_messages(2), with reconnect...
BUILDSTDERR:     # CHILD: reconnected (with a 10s timeout)
BUILDSTDERR:     # PARENT: has relaunched the server...
BUILDSTDERR:     # CHILD: after 2 sec, nothing yet, retrying
BUILDSTDERR:     # CHILD: launch wait_for_messages(2), with reconnect...
BUILDSTDERR:     # CHILD: after 2 sec, nothing yet, retrying
BUILDSTDERR:     # CHILD: launch wait_for_messages(2), with reconnect...
BUILDSTDERR:     # PARENT: waiting for child 20297...
BUILDSTDERR:     # CHILD: child received the message
BUILDSTDERR:     # Sleeping 11 seconds, waiting for Redis to timeout...
BUILDSTDERR:     # waiting for sleep command
BUILDSTDERR: ++ cat /builddir/build/BUILDROOT/perl-Redis-1.991-10.fc31.noarch/redis.pid
+ kill -TERM 20252
+ RPM_EC=0
BUILDSTDERR: ++ jobs -p
+ for pid in $(jobs -p)
+ kill -9 20250
BUILDSTDERR: /var/tmp/rpm-tmp.tdIwBR: line 45: kill: (20250) - No such process
[...]
All tests successful.
Files=18, Tests=289, 80 wallclock secs ( 0.25 usr  0.09 sys + 14.26 cusr  3.33 csys = 17.93 CPU)
Result: PASS
RPM build errors:
BUILDSTDERR: error: Bad exit status from /var/tmp/rpm-tmp.tdIwBR (%check)

It seems rpm-build appends some script after a %check section that tries to clean up running processes and there is a race between gathering PIDs and killing them.

This seems to be triggered up upgrading rpm-build from 4.14.2.1-10.fc31 to
4.14.90-0.git14653.13...

Maybe he %check script should wait() on the daemon PID after killing it.

Comment 1 Panu Matilainen 2019-06-13 09:32:30 UTC
This is an rpm bug, it shouldn't error out because a process we were about to kill died on its own.

If you want to wait on the pid, you're of course free to do so anyway.

Comment 2 Panu Matilainen 2019-06-13 10:18:19 UTC
Should be fixed in rpm-4.14.90-0.git14653.14.fc31 now. Thanks for the report!


Note You need to log in before you can comment on or make changes to this bug.