Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.
RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.

Bug 1720386

Summary: [ Marvell 7.8 FEAT ] Update bnx2x firmware to latest upstream
Product: Red Hat Enterprise Linux 7 Reporter: Manish Chopra (Marvell) <mchopra>
Component: linux-firmwareAssignee: Jan Stancek <jstancek>
Status: CLOSED ERRATA QA Contact: Tianhao <tizhao>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 7.8CC: arahman, ctatman, dhoward, mchopra, rasesh.mody, rvr, tizhao
Target Milestone: rcKeywords: FutureFeature
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: linux-firmware-20190918-74.git6c6918a.el7 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-03-31 20:00:30 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1713124, 1754591    

Description Manish Chopra (Marvell) 2019-06-13 21:29:21 UTC
bnx2x FW files update BZ.

Comment 3 Bruno Meneguele 2019-06-14 18:35:05 UTC
Per "Version" field and "FutureFeature" keyword, this BZ is for RHEL-7.8 right?

Moving release flag to the correct number.

Comment 4 Tianhao 2019-07-04 07:36:38 UTC
set qa_ack+.

Comment 5 Don Howard 2019-08-14 21:59:23 UTC
Hi Manish -
Is there any particular firmware version that marvel is looking for here?

Comment 7 Manish Chopra (Marvell) 2019-11-01 11:24:51 UTC
Hi,

is it possible to anticipate FW files corresponding to below linux-firmware.git commit for inclusion in RHEL7.8 ?
We need to take them as new DPDK drivers releases will need them inboxed.

commit 8fcf0ec44c11f1865f8451c0265e84bf16365312
Author: Rahul Verma <Rahul.Verma>
Date:   Fri Feb 8 00:57:04 2019 -0800

    bnx2x: Add FW 7.13.11.0.

    This patch adds new FW for bnx2x, which adds the following:
     - TX VLAN filtering support.
     - Enable TPA only for packets without VLAN.

    It also addresses few critical issues,
     - Fairness algorithm misbehaviour when minimum bandwidth configured
       for all PFs.
     - Error recovery issue on TAPE devices.
     - FW not discarding FIP frames that are not designated to PF.
     - Kernel driver initialization failure after preboot driver.
     - VxLAN stops working after sending inner IP fragmented traffic.
     - Issues in the following FW flows:
        SD VLAN update, TX packet drop, packet padding flow, vlan add/remove.

    Signed-off-by: Sudarsana Reddy Kalluru <Sudarsana.Kalluru>
    Signed-off-by: Ariel Elior <Ariel.Elior>
    Signed-off-by: Rahul Verma <Rahul.Verma>
    Signed-off-by: Josh Boyer <jwboyer>

Thanks,
Manish

Comment 8 Jan Stancek 2019-11-01 11:35:55 UTC
(In reply to Manish Chopra (Marvell) from comment #7)
> is it possible to anticipate FW files corresponding to below
> linux-firmware.git commit for inclusion in RHEL7.8 ?
> We need to take them as new DPDK drivers releases will need them inboxed.

Yes, this commit is included in linux-firmware-20190918-74.git6c6918a.el7

Comment 9 Tianhao 2019-11-08 08:33:45 UTC
Hi Manish,

It seems the bnx2x NIC is not using the 7.13.11.0 FW. I checked the linux-firmware package and bnx2x firmware version. The details are given below.

The linux-firmware package is the fixed version but the firmware version is not the latest.

[root@hp-dl380g9-06 ~]# ethtool -i ens1f0
driver: bnx2x
version: 1.713.36-0 storm 7.13.1.0
firmware-version: FFV7.12.17 bc 7.12.4
expansion-rom-version: 
bus-info: 0000:05:00.0
supports-statistics: yes
supports-test: yes
supports-eeprom-access: yes
supports-register-dump: yes
supports-priv-flags: yes
[root@hp-dl380g9-06 ~]# rpm -q linux-firmware
linux-firmware-20190918-74.git6c6918a.el7.noarch
[root@hp-dl380g9-06 ~]# lspci -s 05:00.0 -nnv
05:00.0 Ethernet controller [0200]: Broadcom Inc. and subsidiaries NetXtreme II BCM57810 10 Gigabit Ethernet [14e4:168e] (rev 10)
	Subsystem: Broadcom Inc. and subsidiaries Device [14e4:1006]
	Physical Slot: 1
	Flags: bus master, fast devsel, latency 0, IRQ 16, NUMA node 0
	Memory at 94800000 (64-bit, prefetchable) [size=8M]
	Memory at 94000000 (64-bit, prefetchable) [size=8M]
	Memory at 96000000 (64-bit, prefetchable) [size=64K]
	[virtual] Expansion ROM at 96080000 [disabled] [size=512K]
	Capabilities: [48] Power Management version 3
	Capabilities: [50] Vital Product Data
	Capabilities: [a0] MSI-X: Enable+ Count=32 Masked-
	Capabilities: [ac] Express Endpoint, MSI 00
	Capabilities: [100] Advanced Error Reporting
	Capabilities: [13c] Device Serial Number 00-10-18-ff-fe-e8-2a-20
	Capabilities: [150] Power Budgeting <?>
	Capabilities: [160] Virtual Channel
	Capabilities: [1b8] Alternative Routing-ID Interpretation (ARI)
	Capabilities: [1c0] Single Root I/O Virtualization (SR-IOV)
	Capabilities: [220] #15
	Capabilities: [300] #19
	Kernel driver in use: bnx2x
	Kernel modules: bnx2x

I think the other bnx2x NIC models in our lab(57840 and 57711) are also not using the 7.13.11.0 version. Maybe one of them is using 7.13.1.0 version.
If needed, I can provide the version on other systems.

Comment 10 Tianhao 2019-11-08 08:35:03 UTC
Here is the log in console related to bnx2x or the pci id.

[root@hp-dl380g9-06 ~]# cat console.log | grep bnx2x
[   31.173958] bnx2x: QLogic 5771x/578xx 10/20-Gigabit Ethernet Driver bnx2x 1.713.36-0 (2014/02/10) 
[   31.302607] bnx2x 0000:05:00.0: msix capability found 
[   31.302791] bnx2x 0000:05:00.0: part number 0-0-0-0 
[   31.373427] bnx2x 0000:05:00.1: msix capability found 
[   31.373578] bnx2x 0000:05:00.1: part number 0-0-0-0 
[   23.357268] bnx2x: QLogic 5771x/578xx 10/20-Gigabit Ethernet Driver bnx2x 1.713.36-0 (2014/02/10) 
[   23.457154] bnx2x 0000:05:00.0: msix capability found 
[   23.480045] bnx2x 0000:05:00.0: part number 0-0-0-0 
[   23.581684] bnx2x 0000:05:00.1: msix capability found 
[   23.581817] bnx2x 0000:05:00.1: part number 0-0-0-0 
[   35.419997] bnx2x 0000:05:00.0 ens1f0: using MSI-X  IRQs: sp 78  fp[0] 80 ... fp[7] 87 
[   35.641330] bnx2x 0000:05:00.0 ens1f0: NIC Link is Up, 10000 Mbps full duplex, Flow control: ON - receive & transmit 
[   36.227274] bnx2x 0000:05:00.1 ens1f1: using MSI-X  IRQs: sp 88  fp[0] 90 ... fp[7] 97 
[   36.447010] bnx2x 0000:05:00.1 ens1f1: NIC Link is Up, 10000 Mbps full duplex, Flow control: ON - receive & transmit 
[root@hp-dl380g9-06 ~]#ycat console.log | grep 05:00
[    3.999654] pci 0000:05:00.0: VF(n) BAR0 space: [mem 0x39fffd80000-0x39fffdfffff 64bit pref] (contains BAR0 for 16 VFs) 
[    4.003134] pci 0000:05:00.0: VF(n) BAR4 space: [mem 0x39fffe20000-0x39fffe3ffff 64bit pref] (contains BAR4 for 16 VFs) 
[    4.006751] pci 0000:05:00.1: VF(n) BAR0 space: [mem 0x39fffd00000-0x39fffd7ffff 64bit pref] (contains BAR0 for 16 VFs) 
[    4.010202] pci 0000:05:00.1: VF(n) BAR4 space: [mem 0x39fffe00000-0x39fffe1ffff 64bit pref] (contains BAR4 for 16 VFs) 
[    7.047448] pci 0000:05:00.0: BAR 6: assigned [mem 0x96080000-0x960fffff pref] 
[    7.049708] pci 0000:05:00.1: BAR 6: no space for [mem size 0x00080000 pref] 
[    7.051854] pci 0000:05:00.1: BAR 6: failed to assign [mem size 0x00080000 pref] 
[   13.325039] DMAR: Setting identity map for device 0000:05:00.0 [0x791f4000 - 0x791f7fff] 
[   13.328263] DMAR: Setting identity map for device 0000:05:00.1 [0x791f4000 - 0x791f7fff] 
[   14.819768] iommu: Adding device 0000:05:00.0 to group 26 
[   14.821562] iommu: Adding device 0000:05:00.1 to group 26 
[   19.875978] pci 0000:05:00.0: Signaling PME through PCIe PME interrupt 
[   19.878086] pci 0000:05:00.1: Signaling PME through PCIe PME interrupt 
[   31.302607] bnx2x 0000:05:00.0: msix capability found 
[   31.302791] bnx2x 0000:05:00.0: part number 0-0-0-0 
[   31.373427] bnx2x 0000:05:00.1: msix capability found 
[   31.373578] bnx2x 0000:05:00.1: part number 0-0-0-0 
[    3.992936] pci 0000:05:00.0: VF(n) BAR0 space: [mem 0x39fffd80000-0x39fffdfffff 64bit pref] (contains BAR0 for 16 VFs) 
[    3.996366] pci 0000:05:00.0: VF(n) BAR4 space: [mem 0x39fffe20000-0x39fffe3ffff 64bit pref] (contains BAR4 for 16 VFs) 
[    3.999964] pci 0000:05:00.1: VF(n) BAR0 space: [mem 0x39fffd00000-0x39fffd7ffff 64bit pref] (contains BAR0 for 16 VFs) 
[    4.003346] pci 0000:05:00.1: VF(n) BAR4 space: [mem 0x39fffe00000-0x39fffe1ffff 64bit pref] (contains BAR4 for 16 VFs) 
[    7.045663] pci 0000:05:00.0: BAR 6: assigned [mem 0x96080000-0x960fffff pref] 
[    7.047932] pci 0000:05:00.1: BAR 6: no space for [mem size 0x00080000 pref] 
[    7.050215] pci 0000:05:00.1: BAR 6: failed to assign [mem size 0x00080000 pref] 
[    9.608841] DMAR: Setting identity map for device 0000:05:00.0 [0x791f4000 - 0x791f7fff] 
[    9.611768] DMAR: Setting identity map for device 0000:05:00.1 [0x791f4000 - 0x791f7fff] 
[   10.707076] iommu: Adding device 0000:05:00.0 to group 26 
[   10.708930] iommu: Adding device 0000:05:00.1 to group 26 
[   15.836345] pci 0000:05:00.0: Signaling PME through PCIe PME interrupt 
[pci 0000:05:00.1: Signaling PME through PCIe PME interrupt 
[   23.457154] bnx2x 0000:05:00.0: msix capability found 
[   23.480045] bnx2x 0000:05:00.0: part number 0-0-0-0 
[   23.581684] bnx2x 0000:05:00.1: msix capability found 
[   23.581817] bnx2x 0000:05:00.1: part number 0-0-0-0 
[   35.419997] bnx2x 0000:05:00.0 ens1f0: using MSI-X  IRQs: sp 78  fp[0] 80 ... fp[7] 87 
[   35.641330] bnx2x 0000:05:00.0 ens1f0: NIC Link is Up, 10000 Mbps full duplex, Flow control: ON - receive & transmit 
[   36.227274] bnx2x 0000:05:00.1 ens1f1: using MSI-X  IRQs: sp 88  fp[0] 90 ... fp[7] 97 
[   36.447010] bnx2x 0000:05:00.1 ens1f1: NIC Link is Up, 10000 Mbps full duplex, Flow control: ON - receive & transmit

Comment 11 Manish Chopra (Marvell) 2019-11-11 09:07:09 UTC
Hi,

We didn't plan to update any FW for RHEL7.8. So the observations are expected.

Thanks,
Manish

Comment 12 Manish Chopra (Marvell) 2019-11-11 09:11:44 UTC
Essentially, We requested for new FW for DPDK use case but bnx2x driver will not be using the new FW.

Comment 13 Tianhao 2019-11-11 09:47:53 UTC
(In reply to Manish Chopra (Marvell) from comment #12)
> Essentially, We requested for new FW for DPDK use case but bnx2x driver will
> not be using the new FW.

Does some results are required on DPDK tests on the firmware to verify the bug?

Regards,
Tianhao

Comment 14 Manish Chopra (Marvell) 2019-11-11 10:24:02 UTC
(In reply to Tianhao from comment #13)
> (In reply to Manish Chopra (Marvell) from comment #12)
> > Essentially, We requested for new FW for DPDK use case but bnx2x driver will
> > not be using the new FW.
> 
> Does some results are required on DPDK tests on the firmware to verify the
> bug?
> 
> Regards,
> Tianhao

I think it would be good to have a quick test result for DPDK latest release on rhel7.8 to verify if it is using the expected FW (7.13.11.0)
+ Rasesh (to add more details if required (which DPDK release started using the 7.13.11.0 FW))

Thanks,
Manish

Comment 15 Rasesh Mody 2019-11-14 19:58:28 UTC
We have tested the bnx2x FW 7.13.11.0 with DPDK 19.11.

Thanks!
-Rasesh

Comment 16 Tianhao 2019-11-20 06:56:11 UTC
We(network-qe) do not have any dpdk tests on bnx2x NIC. Just FYI.

Comment 19 errata-xmlrpc 2020-03-31 20:00:30 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:1104