Hi Manish,

What version will the FW be? Any specific test needs to be done besides confirming the correct FW version is included in linux-firmware? Thanks.

Hi,

We need to take below FW commit from linux-firmware.git 

commit 0acd93ea00e8b1b0411063f2391da0d4a52ebaf0
Author: Sudarsana Reddy Kalluru <skalluru>
Date:   Tue Oct 22 07:01:54 2019 -0700

    bnx2x: Add FW 7.13.15.0.

    This patch adds new FW for bnx2x, which addresses the following issues:
    - TCP packet with padding can open TPA aggregation in GRO mode.
    - Tx Silent Drops could cause HW error when statistics is not enabled for client.
    - Transmission of tunneled packets over tx-only clients (with cos>0 in this case) followed by load/unload with DCB update (for instance), resulted in a Tx path halt.
    - FORWARD_SETUP ramrod yielded a FW assert (x_eth_fp_hsi_ver_invalid).

    The FW also adds support for direct update of RSS indirection table entry.

    Signed-off-by: Sudarsana Reddy Kalluru <skalluru>
    Signed-off-by: Ameen Rahman <arahman>
    Signed-off-by: Josh Boyer <jwboyer>

We will be posting corresponding driver changes to use this FW soon.

Thanks,
Manish

For some reason, I am not able to set depends on/blocked.
This BZ blocks BZ #1770797.

Thanks,
Manish

Note that patches has been posted for BZ #1770797

Phillip/Don,

Please make sure that above firmware gets pulled in on which bnx2x driver will have dependency (from BZ #1770797).

Thanks,
Manish

+ John

John, please check if this BZ requires any flags etc. to be set appropriately.

Thanks,
Manish

LGTM...

This bug is on our list for the 8.2 linux-firmware update.  You can look for that sometime near 8.2 beta.

Hi Manish,

Just want to make sure, if the following info shows that the bnx2x NIC is using 7.13.15.0 firmware and the regression tests on the NIC is valid for verification.

 $ ethtool -i ens3f0
driver: bnx2x
version: 1.713.36-0 storm 7.13.15.0
firmware-version: 5.0.12 bc 5.0.13 phy aa0.406
expansion-rom-version: 
bus-info: 0000:5e:00.0
supports-statistics: yes
supports-test: yes
supports-eeprom-access: yes
supports-register-dump: yes
supports-priv-flags: yes

Regards,
Tianhao

There is no response from partner. The bnx2x is using 7.13.15.0 version of firmware through 'ethtool -i' result, from my perspective.
 $ ethtool -i ens3f0
driver: bnx2x
version: 1.713.36-0 storm 7.13.15.0
firmware-version: 5.0.12 bc 5.0.13 phy aa0.406
expansion-rom-version: 
bus-info: 0000:5e:00.0
supports-statistics: yes
supports-test: yes
supports-eeprom-access: yes
supports-register-dump: yes
supports-priv-flags: yes

I have finished the nic basic functional testing with kernel-4.18.0-167.el8 on bnx2x driver, details as below:

Test items include: 
layered-protocol: pass
sanity_check(ip/mac/broadcast/multicast/almulti/mtu/promisc/selftest): pass
Card recognize: pass
basic traffic(ping and netperf): pass
statistics in /proc/net/dev: partly pass
ring buffer setting: pass
driver load and unload: pass
coalesce setting: pass
multiqueue: pass
pause: pass
offload: pass
scaling: pass
link_check: pass
vlan/tier1: pass
bridge/stp_test,sanity_check: pass

The bnx2x NIC is using 7.13.15.0 version on 167 kernel. No other regression has been found, set verified.

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:1887