Description of problem: Cannot remove qos from vNIC profile using API. Version-Release number of selected component (if applicable): Version 4.3.3.1-1.el7 How reproducible: always Steps to Reproduce: 1. Have vNIC profile with qos 2. Send PUT request with: <vnic_profile><qos></qos></vnic_profile> Actual results: Qos is not removed from vNIC. Expected results: To remove qos. Network_filter has this functionality(<vnic_profile><network_filter></network_filter></vnic_profile>). Additional info:
Setting severity to high, it's blocking BZ1597537. Dominik, could you please prioritize?
Why this is a bug at all?? You can't remove QoS, you need to to set 'Unlimited', no option to remove QoS, there is no such thing. In network filter, you can set 'No network filter' , this is why you can remove it. Because you can have a vNIC profile with any network filter, but you can't have a vNIC profile without QoS.
'Unlimited' in UI is represented as no value in API. The bug is about we can't set the "Unlimited" value in API. It should be possible to "Unlimited" value by setting the <qos/> as described in the description of the bug.
mnecas, can you please share an example of how the update works for network_filter in the way you like to have the update for qos? If there is no network_filter example, would you please provide an example request you would prefer to use?
(In reply to Dominik Holler from comment #5) > mnecas, can you please share an example of how the update works for > network_filter in the way you like to have the update for qos? > If there is no network_filter example, would you please provide an example > request you would prefer to use? As Ondra mentioned in Comment 3: if you post a PUT request with empty qos element (<qos/>), the QOS for VNIC profile should be set to Unlimited. If qos element has a name (<qos>NAME</qos>), then the QOS should be set to specified QOS.
(In reply to Martin Perina from comment #6) > (In reply to Dominik Holler from comment #5) > > mnecas, can you please share an example of how the update works for > > network_filter in the way you like to have the update for qos? > > If there is no network_filter example, would you please provide an example > > request you would prefer to use? > > As Ondra mentioned in Comment 3: if you post a PUT request with empty qos > element (<qos/>), the QOS for VNIC profile should be set to Unlimited. If > qos element has a name (<qos>NAME</qos>), then the QOS should be set to > specified QOS. Thanks, I was confused by another problem (fix proposed in https://gerrit.ovirt.org/#/c/102236/ )
Verified using ============== ovirt-engine-4.3.6.1-0.1.el7.noarch
This bugzilla is included in oVirt 4.3.6 release, published on September 26th 2019. Since the problem described in this bug report should be resolved in oVirt 4.3.6 release, it has been closed with a resolution of CURRENT RELEASE. If the solution does not work for you, please open a new bug report.