Bug 1720860 (haystack) - Review Request: haystack - A process heap analysis framework
Summary: Review Request: haystack - A process heap analysis framework
Keywords:
Status: ASSIGNED
Alias: haystack
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: FE-SECLAB
TreeView+ depends on / blocked
 
Reported: 2019-06-15 19:23 UTC by Fabian Affolter
Modified: 2020-09-01 11:58 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed:
Type: ---
zebob.m: fedora-review?


Attachments (Terms of Use)

Description Fabian Affolter 2019-06-15 19:23:09 UTC
Spec URL: https://fab.fedorapeople.org/packages/SRPMS/haystack.spec
SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/haystack-0.42-1.fc30.src.rpm

Project URL: https://github.com/trolldbois/python-haystack

Description:
haystack is an heap analysis framework, focused on searching and reversing
of C structure in allocated memory.

The first function/API is the SEARCH function. It gives the ability
to search for known record types in a process memory dump or live
process's memory. The second function/API is the REVERSE function in the
extension python-haystack-reverse It aims at helping an analyst in reverse
engineering the memory records types present in a process heap. It focuses
on reconstruction, classification of classic C structures from memory. It
attempts to recreate types definition.

Koji scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=35563071

rpmlint output:
$ rpmlint haystack-0.42-1.fc30.src.rpm 
haystack.src:47: W: macro-in-comment %check
haystack.src:48: W: macro-in-comment %{__python3}
1 packages and 0 specfiles checked; 0 errors, 2 warnings.

$ rpmlint haystack-0.42-1.fc30.noarch.rpm 
haystack.noarch: W: no-manual-page-for-binary haystack-find-heap
haystack.noarch: W: no-manual-page-for-binary haystack-live-dump
haystack.noarch: W: no-manual-page-for-binary haystack-live-watch
haystack.noarch: W: no-manual-page-for-binary haystack-rekall-dump
haystack.noarch: W: no-manual-page-for-binary haystack-search
haystack.noarch: W: no-manual-page-for-binary haystack-show
haystack.noarch: W: no-manual-page-for-binary haystack-volatility-dump
1 packages and 0 specfiles checked; 0 errors, 7 warnings.fab

Fedora Account System Username: fab

Comment 1 Robert-André Mauchin 🐧 2019-06-18 20:03:49 UTC
DEBUG util.py:585:  BUILDSTDERR: Error: 
DEBUG util.py:585:  BUILDSTDERR:  Problem: conflicting requests
DEBUG util.py:585:  BUILDSTDERR:   - nothing provides python3.7dist(construct) < 2.8 needed by haystack-0.42-1.fc31.noarch

Python-construct is 2.9.45 in Rawhide.

Try to relax the requirement? Although I doubt it would work.


Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
- Package installs properly.
  Note: Installation errors (see attachment)
  See: https://docs.fedoraproject.org/en-US/packaging-guidelines/


===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "Expat License". 170 files have unknown
     license. Detailed output of licensecheck in
     /home/bob/packaging/review/haystack/review-haystack/licensecheck.txt
[x]: Package does not own files or directories owned by other packages.
     Note: Dirs in package are owned also by: /usr/lib/python3.7/site-
     packages/haystack(python3-django-haystack), /usr/lib/python3.7/site-
     packages/haystack/__pycache__(python3-django-haystack)
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 30720 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
     process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
     packages named with the unversioned python- prefix unless no properly
     versioned package exists. Dependencies on Python packages instead MUST
     use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[!]: Rpmlint is run on all installed packages.
     Note: Mock build failed
     See: https://docs.fedoraproject.org/en-US/packaging-
     guidelines/#_use_rpmlint
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: haystack-0.42-1.fc31.noarch.rpm
          haystack-0.42-1.fc31.src.rpm
haystack.noarch: W: no-manual-page-for-binary haystack-find-heap
haystack.noarch: W: no-manual-page-for-binary haystack-live-dump
haystack.noarch: W: no-manual-page-for-binary haystack-live-watch
haystack.noarch: W: no-manual-page-for-binary haystack-rekall-dump
haystack.noarch: W: no-manual-page-for-binary haystack-search
haystack.noarch: W: no-manual-page-for-binary haystack-show
haystack.noarch: W: no-manual-page-for-binary haystack-volatility-dump
haystack.src:47: W: macro-in-comment %check
haystack.src:48: W: macro-in-comment %{__python3}
2 packages and 0 specfiles checked; 0 errors, 9 warnings.

Comment 2 Robert-André Mauchin 🐧 2019-06-18 20:23:28 UTC
Minidump.py needs to be rewritten for construct 2.8.

https://construct.readthedocs.io/en/latest/transition28.html

Comment 3 Fabian Affolter 2020-09-01 11:58:10 UTC
There is not much action from upstream visible. Looks like that upstream is dead.


Note You need to log in before you can comment on or make changes to this bug.