Bug 1721282 - [osp14] Error validating plan with custom service ERROR: The Resource Type (OS::TripleO::Services::Dummy) could not be found.
Summary: [osp14] Error validating plan with custom service ERROR: The Resource Type (...
Keywords:
Status: CLOSED EOL
Alias: None
Product: Red Hat OpenStack
Classification: Red Hat
Component: openstack-tripleo-common
Version: 14.0 (Rocky)
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ---
: ---
Assignee: Adriano Petrich
QA Contact: Alexander Chuzhoy
URL:
Whiteboard:
Depends On: 1677230
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-06-17 20:20 UTC by Alex Schultz
Modified: 2020-08-26 20:59 UTC (History)
16 users (show)

Fixed In Version: openstack-tripleo-common-9.5.0-7.el7ost
Doc Type: If docs needed, set a value
Doc Text:
Clone Of: 1677230
Environment:
Last Closed: 2020-08-26 20:59:41 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
OpenStack gerrit 665852 0 'None' MERGED Only update parameters once in backup workflow 2021-02-05 11:06:20 UTC

Description Alex Schultz 2019-06-17 20:20:54 UTC
I'm also hitting this on OSP14

+++ This bug was initially created as a clone of Bug #1677230 +++

Description of problem:

We are finding problems when createing a custom service, this is working perfectly with OSP12. I'm testing OSP13 and I'm facing this issue.

$ openstack overcloud deploy --templates -r roles_data_with_dummy.yaml -e dummy.yaml 

Started Mistral Workflow tripleo.validations.v1.check_pre_deployment_validations. Execution ID: bd47c9b7-a7f2-4cb3-bd42-eb391b44a192
Waiting for messages on queue 'tripleo' with no timeout.
Creating Swift container to store the plan
Creating plan from template files in: /tmp/tripleoclient-APWnHt/tripleo-heat-templates
Started Mistral Workflow tripleo.plan_management.v1.create_deployment_plan. Execution ID: 60a55b80-9f06-420c-a26a-002699271c78
Error validating environment for plan overcloud: ERROR: The Resource Type (OS::TripleO::Services::Dummy) could not be found.
Exception creating plan: Error validating environment for plan overcloud: ERROR: The Resource Type (OS::TripleO::Services::Dummy) could not be found.


Similar to:

 https://bugzilla.redhat.com/show_bug.cgi?id=1577536


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:

 -> install OSP13 director
 -> import baremetal servers
 -> create template_test directory 
 -> add dummy service to custom role
 -> deploy # openstack overcloud deploy --templates -r roles_data_with_dummy.yaml -e dummy.yaml 


Actual results:

Started Mistral Workflow tripleo.validations.v1.check_pre_deployment_validations. Execution ID: bd47c9b7-a7f2-4cb3-bd42-eb391b44a192
Waiting for messages on queue 'tripleo' with no timeout.
Creating Swift container to store the plan
Creating plan from template files in: /tmp/tripleoclient-APWnHt/tripleo-heat-templates
Started Mistral Workflow tripleo.plan_management.v1.create_deployment_plan. Execution ID: 60a55b80-9f06-420c-a26a-002699271c78
Error validating environment for plan overcloud: ERROR: The Resource Type (OS::TripleO::Services::Dummy) could not be found.
Exception creating plan: Error validating environment for plan overcloud: ERROR: The Resource Type (OS::TripleO::Services::Dummy) could not be found.

Expected results:
no errors

Additional info:

The same procedure works correctly on OSP12
Similar to [1] but our code is already patched

[1]  https://bugzilla.redhat.com/show_bug.cgi?id=1577536

Comment 4 Alex Schultz 2019-06-18 15:29:21 UTC
It's still failing. It's less verbose with that patch but still it can't find the resource.

(undercloud) [cloud-user@undercloud ~]$ openstack overcloud deploy --templates -e /usr/share/openstack-tripleo-heat-templates/environments/enable-swap.yaml -e /usr/share/openstack-tripleo-heat-templates/environments/disable-telemetry.yaml -e /home/cloud-user/local_images.yaml -e /home/cloud-user/params.yaml -r roles_data.yaml 
Removing the current plan files
Uploading new plan files
Temporary Swift GET/PUT URL parameters have successfully been updated.
Error validating environment for plan overcloud: ERROR: The Resource Type (OS::TripleO::Services::MyService) could not be found.
None
{u'status': u'FAILED', u'message': u'Error validating environment for plan overcloud: ERROR: The Resource Type (OS::TripleO::Services::MyService) could not be found.\nNone', u'result': u'Failure caused by error in tasks: notify_zaqar\n\n  notify_zaqar [task_ex_id=6a07799d-40d9-412b-836b-de509e36a817] -> Workflow failed due to message status\n    [wf_ex_id=46ad2627-8d55-4160-bbef-ea60b636468c, idx=0]: Workflow failed due to message status\n', u'swift_container': u'overcloud_ceph_ansible_fetch_dir'}
Exception updating plan: {u'status': u'FAILED', u'message': u'Error validating environment for plan overcloud: ERROR: The Resource Type (OS::TripleO::Services::MyService) could not be found.\nNone', u'result': u'Failure caused by error in tasks: notify_zaqar\n\n  notify_zaqar [task_ex_id=6a07799d-40d9-412b-836b-de509e36a817] -> Workflow failed due to message status\n    [wf_ex_id=46ad2627-8d55-4160-bbef-ea60b636468c, idx=0]: Workflow failed due to message status\n', u'swift_container': u'overcloud_ceph_ansible_fetch_dir'}
(undercloud) [cloud-user@undercloud ~]$ cat params.yaml 
resource_registry:
  OS::TripleO::Services::MyService: OS::Heat::None

parameter_defaults:
  SELinuxMode: permissive
  NovaComputeLibvirtType: qemu
  DnsServers: ['1.1.1.1', '1.0.0.1']
  ControllerCount: 1
  ComputeCount: 1


Also fails when i set the service to a service file too, so doesn't seem related to that.

Comment 5 Alex Schultz 2019-06-18 16:15:47 UTC
I think it's the update_parameters task definition of tripleo.parameters.update call in the plan_management.yaml. It's lacking the validate input param. I'll try and track that down.

Comment 6 Rabi Mishra 2019-06-18 16:32:34 UTC
I think it fails in the next task[1] now. I've updated the patch upstream if you want to test. We would need it to be fixed in master too.

[1]  https://github.com/openstack/tripleo-common/blob/master/workbooks/plan_management.yaml#L307

Comment 7 Lon Hohberger 2019-09-04 10:44:10 UTC
According to our records, this should be resolved by openstack-tripleo-common-9.5.0-8.el7ost.  This build is available now.


Note You need to log in before you can comment on or make changes to this bug.