Bug 1721353 - Run 'line-coverage' regression runs on a latest fedora machine (say fedora30).
Summary: Run 'line-coverage' regression runs on a latest fedora machine (say fedora30).
Keywords:
Status: CLOSED UPSTREAM
Alias: None
Product: GlusterFS
Classification: Community
Component: project-infrastructure
Version: mainline
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: ---
Assignee: Deepshikha khandelwal
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-06-18 04:49 UTC by Amar Tumballi
Modified: 2020-03-12 12:36 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-03-12 12:36:20 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:


Attachments (Terms of Use)

Description Amar Tumballi 2019-06-18 04:49:37 UTC
Description of problem:

I suspect the code coverage tool with centos7 is not covering all the details.


Check https://build.gluster.org/job/line-coverage/lastCompletedBuild/Line_20Coverage_20Report/libglusterfs/src/glusterfs/stack.h.gcov.html for example, and you can see that it says, 17/41 functions are covered. But if you notice there are only 17 inline functions, and all of them are actually covered.

If it reported it properly, we should have had 100% coverage there.

With that detail, I hope having newer version would get this sorted.

Also note, we recently fixed all the issues with python3 in regression runs too, so moving to fedora should help us identify issues sooner with python3 (if any).

Version-Release number of selected component (if applicable):
master

How reproducible:
100%


Expected results:
Nightly line-coverage runs to run on fedora systems.

Comment 1 Amar Tumballi 2019-06-18 06:23:14 UTC
Ok, when I used the lcov tool with the same commands as that of lcov.sh from build-jobs repo, I got below numbers for stack.h (which I used as an example above).

on current builder :  stack.h - lines(262/497 - 52.7%), functions(17/41 - 41.5%) 
on fedora29 (local):  stack.h - lines(94/111  - 84.7%), functions(6/7 - 85.7%)

I hope just by running the regression on fedora, we would get more up-to-date information, and more coverage details. Just note that I suspect this to be more of an header file specific details, and even then, up-to-date information is better than stale info.

Comment 2 Kotresh HR 2019-06-18 07:31:30 UTC
I have also witnessed the small difference when I was working to improve lcov of glusterd-georep.c. On fedora 30, I used to see 70.1 % but on centos 69.9 %. 
I didn't spend time debugging that though. Didn't expect it was platform dependent.

Comment 3 Worker Ant 2020-03-12 12:36:20 UTC
This bug is moved to https://github.com/gluster/project-infrastructure/issues/19, and will be tracked there from now on. Visit GitHub issues URL for further details


Note You need to log in before you can comment on or make changes to this bug.