Bug 1721443 - ISOs in data domain displayed with ID in import dialog
Summary: ISOs in data domain displayed with ID in import dialog
Keywords:
Status: CLOSED DUPLICATE of bug 1721438
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: Frontend.WebAdmin
Version: 4.3.0
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ovirt-4.4.0
: ---
Assignee: Steven Rosenberg
QA Contact: meital avital
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-06-18 10:13 UTC by Tomáš Golembiovský
Modified: 2019-07-01 13:31 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2019-07-01 13:31:08 UTC
oVirt Team: Virt
Embargoed:
pm-rhel: ovirt-4.4+


Attachments (Terms of Use)
List containing ID (16.89 KB, image/png)
2019-06-18 10:13 UTC, Tomáš Golembiovský
no flags Details
Run Once (10.00 KB, image/png)
2019-06-27 14:37 UTC, Tomáš Golembiovský
no flags Details
ISO File Name fix with sorting has been already implemented. (42.60 KB, image/png)
2019-06-30 14:45 UTC, Steven Rosenberg
no flags Details

Description Tomáš Golembiovský 2019-06-18 10:13:31 UTC
Created attachment 1581626 [details]
List containing ID

In the second dialog of VM Import, the list of ISOs shows disk ID instead of name for ISOs that are stored in data domain. See the last entry in the attached screenshot.

Comment 1 Steven Rosenberg 2019-06-27 12:14:04 UTC
There are design issues with this request, namely if we change the displaying of the Image GUID for the file with the actual file name, it might be more user friendly except that then there would be no way of knowing whether the iso file resides on a Data Domain or the iso repository.

Our approaches may be as follows:

1. Being that there are a few issues in this area and that the current implementation does not work to only display iso files residing on the ISO repository and then address all of these issues as part of one new development process.

2. Display the name and an indicator of the iso file source in the current column which may require more effort in parsing the actual names.

3. Adding a separate column to the drop down which would be a much more complicated UI effort.

These are some consideration to consider with this issue and related iso issues as well.

Comment 2 Tomáš Golembiovský 2019-06-27 12:48:27 UTC
Before we start redesigning the UI, could you please check how Run Once dialog handles this case? It also allows you to pick ISO from data domain.

Comment 3 Ryan Barry 2019-06-27 12:50:14 UTC
+1 to this

I'd suggest not adding separate columns or dropdowns, but instead pulling the storage domain name out and prepending it, so it looks like "iscsimultipath/CentOS-7.6-...iso"

Matching the RunOnce dialog is ideal

Comment 4 Steven Rosenberg 2019-06-27 13:25:25 UTC
(In reply to Tomáš Golembiovský from comment #2)
> Before we start redesigning the UI, could you please check how Run Once
> dialog handles this case? It also allows you to pick ISO from data domain.

I do not see any functionality in the VM run once dialog that supports iso files. Maybe you can provide a screen shot, section, drop down, etc.

Comment 5 Steven Rosenberg 2019-06-27 13:29:37 UTC
(In reply to Ryan Barry from comment #3)
> +1 to this
> 
> I'd suggest not adding separate columns or dropdowns, but instead pulling
> the storage domain name out and prepending it, so it looks like
> "iscsimultipath/CentOS-7.6-...iso"
> 
> Matching the RunOnce dialog is ideal

It is not clear what iscsimultipath stands for. I assume we need to be more descriptive concerning whether it is an ISO Repo or which Data Domain we are referring to (there maybe multiples), while whether it is NFS or Block is not as important.

Comment 6 Tomáš Golembiovský 2019-06-27 14:36:12 UTC
(In reply to Steven Rosenberg from comment #4)
> (In reply to Tomáš Golembiovský from comment #2)
> > Before we start redesigning the UI, could you please check how Run Once
> > dialog handles this case? It also allows you to pick ISO from data domain.
> 
> I do not see any functionality in the VM run once dialog that supports iso
> files. Maybe you can provide a screen shot, section, drop down, etc.

In 'Boot Options' section you tick the 'Attach CD' box and then pick ISO from the list.

Comment 7 Tomáš Golembiovský 2019-06-27 14:37:12 UTC
Created attachment 1585188 [details]
Run Once

Comment 8 Ryan Barry 2019-06-27 16:22:20 UTC
This is exactly the dialog I had in mind.

In my example. "iscsimultipath" is an arbitrary data domain, but it could be named whatever. Just an example for formattting

Comment 9 Steven Rosenberg 2019-06-30 08:26:25 UTC
(In reply to Ryan Barry from comment #8)
> This is exactly the dialog I had in mind.
> 
> In my example. "iscsimultipath" is an arbitrary data domain, but it could be
> named whatever. Just an example for formattting

Well it will be too long in the combo box so one will not be able to see the actual file name until it is dropped down (when then has more real estate).

First step will be to fix the file name, as per Daniel Erez the user only cares about which iso to use, not where it comes from. Then maybe we can add a different formate such as: "fileName - StorageDomainName" so one can see the chose file name.

Comment 10 Steven Rosenberg 2019-06-30 14:26:11 UTC
(In reply to Steven Rosenberg from comment #9)
> (In reply to Ryan Barry from comment #8)
> > This is exactly the dialog I had in mind.
> > 
> > In my example. "iscsimultipath" is an arbitrary data domain, but it could be
> > named whatever. Just an example for formattting
> 
> Well it will be too long in the combo box so one will not be able to see the
> actual file name until it is dropped down (when then has more real estate).
> 
> First step will be to fix the file name, as per Daniel Erez the user only
> cares about which iso to use, not where it comes from. Then maybe we can add
> a different formate such as: "fileName - StorageDomainName" so one can see
> the chose file name.

Upon further investigation, this issue has already been resolved in the following issue:

https://bugzilla.redhat.com/show_bug.cgi?id=1721438

The iso data domain files are differentiated by displaying the file name and then a portion of the ID in parenthesis to the right of the file name.

Therefore this issue has become a duplicate and should be closed (being that the sorting was performed in parallel with the file name format change.

Comment 11 Steven Rosenberg 2019-06-30 14:45:52 UTC
Created attachment 1586022 [details]
ISO File Name fix with sorting has been already implemented.

Comment 12 Steven Rosenberg 2019-07-01 13:31:08 UTC

*** This bug has been marked as a duplicate of bug 1721438 ***


Note You need to log in before you can comment on or make changes to this bug.