Bug 1721487 - Review Request: codespell - Fix common misspellings in text files
Summary: Review Request: codespell - Fix common misspellings in text files
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Yanko Kaneti
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-06-18 11:46 UTC by Bastien Nocera
Modified: 2019-06-18 16:00 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2019-06-18 16:00:52 UTC
Type: ---
Embargoed:
yaneti: fedora-review+


Attachments (Terms of Use)

Description Bastien Nocera 2019-06-18 11:46:43 UTC
Spec URL: https://hadess.fedorapeople.org/codespell/codespell.spec
SRPM URL: https://hadess.fedorapeople.org/codespell/codespell-1.15.0-1.fc30.src.rpm
Description: codespell fixes common misspellings in text files. It's designed primarily for checking misspelled words in source code, but it can be used with other files as well.

Fedora Account System Username: hadess

Comment 1 Yanko Kaneti 2019-06-18 13:12:55 UTC
- "GPL v2" > "GPLv2 and CC-BY-SA 3.0"   for the dictionary.txt

- I don't think anything needs codespell_lib/tests  at runtime

- Are you sure it "Requires:       python3dist(setuptools)" ?

Comment 2 Bastien Nocera 2019-06-18 13:49:23 UTC
(In reply to Yanko Kaneti from comment #1)
> - "GPL v2" > "GPLv2 and CC-BY-SA 3.0"   for the dictionary.txt

Fixed.

> - I don't think anything needs codespell_lib/tests  at runtime

Fixed

> - Are you sure it "Requires:       python3dist(setuptools)" ?

Probably not, fixed.

(the original spec file was created with pyp2rpm, that's why there were some weird things)

Updated spec and SRPM:
https://hadess.fedorapeople.org/codespell/codespell.spec
https://hadess.fedorapeople.org/codespell/codespell-1.15.0-2.fc30.src.rpm

Comment 3 Yanko Kaneti 2019-06-18 13:55:30 UTC
Name matches. Source matches. License matches. Doesn't conflict

APPROVED

Comment 4 Gwyn Ciesla 2019-06-18 14:31:15 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/codespell

Comment 5 Bastien Nocera 2019-06-18 16:00:52 UTC
Built in rawhide, updates filed for f29 and f30. Thanks for the review!


Note You need to log in before you can comment on or make changes to this bug.