Bug 1721619

+++ This bug was initially created as a clone of Bug #1716548 +++

Description of problem:
IPI installation with AWS. If you change the default configuration to increase the number of workers, the installer chooses an AZ that doesnt support the instance type.

Version-Release number of the following components:
rpm -q openshift-ansible
rpm -q ansible
ansible --version

How reproducible:
can be reproduced

Steps to Reproduce:

1. Create an install config
Example: ./openshift-install create install-config --dir=second
select us-west-2 as the region.

2.Edit install-config.yaml and change the number of workers from 3 to 4
compute:
- hyperthreading: Enabled
  name: worker
  platform: {}
  replicas: 4

3. Run the installation
./openshift-install create cluster --dir=second

4. It only creates 3 workers and not 4.

Actual results:

oc get machinesets -n openshift-machine-api
NAME                             DESIRED   CURRENT   READY   AVAILABLE   AGE
second-hb7vq-worker-us-west-2a   1         1         1       1           87m
second-hb7vq-worker-us-west-2b   1         1         1       1           87m
second-hb7vq-worker-us-west-2c   1         1         1       1           87m
second-hb7vq-worker-us-west-2d   1         1                             87m


$ oc get machines -n openshift-machine-api
NAME                                   INSTANCE              STATE     TYPE        REGION      ZONE         AGE
second-hb7vq-master-0                  i-0ba4c5c0a949af07b   running   m4.xlarge   us-west-2   us-west-2a   99m
second-hb7vq-master-1                  i-0a1ed6818c4091dda   running   m4.xlarge   us-west-2   us-west-2b   99m
second-hb7vq-master-2                  i-0c100e6e76d64c8fa   running   m4.xlarge   us-west-2   us-west-2c   99m
second-hb7vq-worker-us-west-2a-5qwgp   i-01a26741af6e0dac5   running   m4.large    us-west-2   us-west-2a   97m
second-hb7vq-worker-us-west-2b-qt7mx   i-09bdde677ace6cfd8   running   m4.large    us-west-2   us-west-2b   97m
second-hb7vq-worker-us-west-2c-fb9vh   i-03dfe21426a3a029f   running   m4.large    us-west-2   us-west-2c   97m
second-hb7vq-worker-us-west-2d-xm6dh                                   m4.large    us-west-2   us-west-2d   97m


Machine is not running. Here is the status

      Message:               error launching instance: error creating EC2 instance: Unsupported: Your requested instance type (m4.large) is not supported in your requested Availability Zone (us-west-2d). Please retry your request by not specifying an Availability Zone or choosing us-west-2c, us-west-2b, us-west-2a.
                             status code: 400, request id: 7809acda-2740-460b-a807-d1a9a6db12be
      Reason:                MachineCreationFailed
      Status:                True
      Type:                  MachineCreation
    Kind:                    AWSMachineProviderStatus


So, the installer is ending up selecting availability zones where the instance type i not available


Expected results:

Installer should not select the AZs that support the machine types that it plans to use. 

Additional info:
Please attach logs from ansible-playbook with the -vvv flag