Bug 1721814 - Validating the format in service order page even after disabling the validation button in service dialog
Summary: Validating the format in service order page even after disabling the validati...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: UI - OPS
Version: 5.10.6
Hardware: Unspecified
OS: Unspecified
medium
high
Target Milestone: GA
: 5.11.0
Assignee: Martin Hradil
QA Contact: Niyaz Akhtar Ansari
Red Hat CloudForms Documentation
URL:
Whiteboard:
Depends On:
Blocks: 1726438
TreeView+ depends on / blocked
 
Reported: 2019-06-19 06:17 UTC by Niyaz Akhtar Ansari
Modified: 2019-12-13 15:01 UTC (History)
9 users (show)

Fixed In Version: 5.11.0.14
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1726438 (view as bug list)
Environment:
Last Closed: 2019-12-13 15:01:10 UTC
Category: Bug
Cloudforms Team: CFME Core
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Description Niyaz Akhtar Ansari 2019-06-19 06:17:04 UTC
Description of problem:


Version-Release number of selected component (if applicable):
5.10.6.0

How reproducible:
100%

Steps to reproduce.

1. Create a dialog. Set regex_validation in text box ->  ^[0-9]*$ 
2. Save the dialog
3. Edit the dialog and disable the validation button of text box 
2. Use the dialog in a catalog.
3. In catalog order page


Actual results:

except the format " ^[0-9]*$ " you input anything else it gives below validation error 
--> Entered text should match the format: ^[0-9]*$



Expected results:


Additional info:

Comment 3 Martin Hradil 2019-06-25 14:27:58 UTC
https://github.com/ManageIQ/ui-components/pull/397

Comment 5 CFME Bot 2019-07-02 20:29:55 UTC
New commit detected on ManageIQ/ui-components/master:

https://github.com/ManageIQ/ui-components/commit/f6205b2b04cc5fa61d978f1c6db5056ec880b89a
commit f6205b2b04cc5fa61d978f1c6db5056ec880b89a
Author:     Martin Hradil <mhradil>
AuthorDate: Tue Jun 25 10:16:23 2019 -0400
Commit:     Martin Hradil <mhradil>
CommitDate: Tue Jun 25 10:16:23 2019 -0400

    DialogData spec - validator_type is 'f' when disabled

    we're saving `false` now in `validator_type` when validation is disabled, which gets serialized as `"f"`

    adding a spec that no regex validation is attempted unless `validator_type` is explicitly `regex`

    https://bugzilla.redhat.com/show_bug.cgi?id=1721814

 src/dialog-user/services/dialogData.spec.ts | 20 +
 1 file changed, 20 insertions(+)


https://github.com/ManageIQ/ui-components/commit/fa4b5c93ddf4fc3627cd5361c8b79ee0c59c38ea
commit fa4b5c93ddf4fc3627cd5361c8b79ee0c59c38ea
Author:     Martin Hradil <mhradil>
AuthorDate: Tue Jun 25 10:23:11 2019 -0400
Commit:     Martin Hradil <mhradil>
CommitDate: Tue Jun 25 10:23:11 2019 -0400

    dialog user - only run regex validation when validator_type=regex

    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1721814

 src/dialog-user/services/dialogData.ts | 3 +-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comment 7 Niyaz Akhtar Ansari 2019-07-15 12:17:48 UTC
Verified in Version 5.11.0.14.20190710225033_cb17ff0


Note You need to log in before you can comment on or make changes to this bug.