Bug 1722413 - [RFE] Add support for virt-who-plugin through satellite-installer
Summary: [RFE] Add support for virt-who-plugin through satellite-installer
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Red Hat Satellite
Classification: Red Hat
Component: Virt-who Configure Plugin
Version: 6.6.0
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: Unspecified
Assignee: Marek Hulan
QA Contact: Kunxin Huang
satellite-doc-list
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-06-20 10:02 UTC by Kunxin Huang
Modified: 2019-09-05 08:08 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-09-05 08:08:48 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Comment 3 Marek Hulan 2019-06-24 13:25:41 UTC
AFAIK plugins uninstalling or disabling is generally not supported and know to be problematic (with 1 exception IIRC). What is the use case for implementing this?

Comment 5 Sachin Ghai 2019-06-27 09:09:10 UTC
Hey Mirek, The intent behind this RFE is to have a parity between UI and CLI for enabling or disabling the virt-who plugin like we have the same option for other plugins like oscap. Now I see your comment "AFAIK plugins uninstalling or disabling is generally not supported and know to be problematic", so how it is problematic ?

Comment 6 Marek Hulan 2019-07-23 15:53:31 UTC
I think there are some misunderstandings here

1) this plugin has a rake task to clean up DB, which is handy if someone uninstalls the plugin in upstream
2) plugins uninstallation is not supported in Satellite in general at least as far as I know, e.g. you can't uninstall foreman_openscap, foreman_ansible or katello. I believe satellite rpm has a hard dependency on these plugins. Today, there's no way to disable plugin.
3) satellite-installer --no-enable-$whatever does not uninstall anything, it just disables configuration of the plugin, once you install the plugin and run the installer with this option, it does not touch this part configuration
4) Given the above, this plugin is no exception and disabling/uninstallation is not possible

To give you a bit more background for what I referred to as problematic - uninstalling means removal of the code that defines classes, the data still remains in DB, also structures are already changed. When later Satellite see such data, it's missing a class definition for it, resulting in 500. Also in rare cases, the remaining code does not know how to worked with modified DB schema.

Do you need more information or can we close this as not a bug? Also not sure what you mean by UI and CLI for enabling/disabling plugin. There's no UI or CLI for this.

Comment 7 Sachin Ghai 2019-09-05 08:08:48 UTC
Thanks Marek.

I understand that the enable/disable options doesn't uninstall plugins and plugin uninstall is not supported in general. I can close this as not a bug.


Note You need to log in before you can comment on or make changes to this bug.