Spec URL: http://sham1.sinervo.fi/files/rpm-review/herbstluftwm/herbstluftwm.spec SRPM URL: http://sham1.sinervo.fi/files/rpm-review/herbstluftwm/herbstluftwm-0.7.2-1.fc30.src.rpm Description: herbstluftwm is a manual tiling window manager for X11 using Xlib and Glib. Its main features can be described with: - The layout is based on splitting frames into subframes which can be split again or can be filled with windows; - Tags (or workspaces or virtual desktops or …) can be added/removed at runtime. Each tag contains an own layout exactly one tag is viewed on each monitor. The tags are monitor independent; - It is configured at runtime via ipc calls from herbstclient. So the configuration file is just a script which is run on startup. Fedora Account System Username: sham1 This is an unretiring of this package, and as per the procedure, any package that has been retired for 8 or more weeks needs to be re-reviewed. A koji scract build: https://koji.fedoraproject.org/koji/taskinfo?taskID=35659379
# Set the proper build flags export CFLAGS+="%{optflags}" CPPFLAGS+="%{optflags}" \ CXXFLAGS+="%{optflags}" LDFLAGS="%{__global_ldflags}" - Use %set_build_flags - Capitalize summaries: herbstluftwm-zsh.noarch: W: summary-not-capitalized C herbstluftwm zsh completion support herbstluftwm-fish.noarch: W: summary-not-capitalized C herbstluftwm fish completion support - Fix the shebangs for: herbstluftwm.x86_64: E: wrong-script-interpreter /usr/share/doc/herbstluftwm/scripts/dmenu.sh /usr/bin/env bash herbstluftwm.x86_64: E: wrong-script-interpreter /usr/share/doc/herbstluftwm/scripts/dumpbeautify.sh /usr/bin/env bash herbstluftwm.x86_64: E: wrong-script-interpreter /usr/share/doc/herbstluftwm/scripts/exec_on_tag.sh /usr/bin/env bash herbstluftwm.x86_64: E: wrong-script-interpreter /usr/share/doc/herbstluftwm/scripts/execwith.sh /usr/bin/env bash herbstluftwm.x86_64: E: wrong-script-interpreter /usr/share/doc/herbstluftwm/scripts/float-maximize.sh /usr/bin/env bash herbstluftwm.x86_64: E: wrong-script-interpreter /usr/share/doc/herbstluftwm/scripts/floatmon.sh /usr/bin/env bash herbstluftwm.x86_64: E: wrong-script-interpreter /usr/share/doc/herbstluftwm/scripts/herbstcommander.sh /usr/bin/env bash herbstluftwm.x86_64: E: wrong-script-interpreter /usr/share/doc/herbstluftwm/scripts/keychain.sh /usr/bin/env bash herbstluftwm.x86_64: E: wrong-script-interpreter /usr/share/doc/herbstluftwm/scripts/lasttag.sh /usr/bin/env bash herbstluftwm.x86_64: E: wrong-script-interpreter /usr/share/doc/herbstluftwm/scripts/layout.sh /usr/bin/env bash herbstluftwm.x86_64: E: wrong-script-interpreter /usr/share/doc/herbstluftwm/scripts/loadstate.sh /usr/bin/env bash herbstluftwm.x86_64: E: wrong-script-interpreter /usr/share/doc/herbstluftwm/scripts/maximize.sh /usr/bin/env bash herbstluftwm.x86_64: E: wrong-script-interpreter /usr/share/doc/herbstluftwm/scripts/q3terminal.sh /usr/bin/env bash herbstluftwm.x86_64: E: wrong-script-interpreter /usr/share/doc/herbstluftwm/scripts/savestate.sh /usr/bin/env bash herbstluftwm.x86_64: E: wrong-script-interpreter /usr/share/doc/herbstluftwm/scripts/scratchpad.sh /usr/bin/env bash herbstluftwm.x86_64: E: wrong-script-interpreter /usr/share/doc/herbstluftwm/scripts/toggledualhead.sh /usr/bin/env bash herbstluftwm.x86_64: E: wrong-script-interpreter /usr/share/doc/herbstluftwm/scripts/windowmenu.sh /usr/bin/env bash herbstluftwm.x86_64: E: wrong-script-interpreter /usr/share/doc/herbstluftwm/scripts/wselect.sh /usr/bin/env bash # Change the shebangs of the upstream files to be proper for f in "%{buildroot}%{_pkgdocdir}/scripts/*.sh" do sed -i -e "s|#!/usr/bin/env bash|#!/usr/bin/bash|" $f done Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= Note: A package with this name already exists. Please check https://src.fedoraproject.org/rpms/herbstluftwm See: https://docs.fedoraproject.org/en-US/packaging- guidelines/Naming/#_conflicting_package_names ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "BSD 2-clause "Simplified" License". 115 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/herbstluftwm/review- herbstluftwm/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 348160 bytes in 48 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in herbstluftwm-zsh , herbstluftwm-fish [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: herbstluftwm-0.7.2-1.fc31.x86_64.rpm herbstluftwm-zsh-0.7.2-1.fc31.noarch.rpm herbstluftwm-fish-0.7.2-1.fc31.noarch.rpm herbstluftwm-debuginfo-0.7.2-1.fc31.x86_64.rpm herbstluftwm-debugsource-0.7.2-1.fc31.x86_64.rpm herbstluftwm-0.7.2-1.fc31.src.rpm herbstluftwm.x86_64: W: spelling-error %description -l en_US subframes -> sub frames, sub-frames, frames herbstluftwm.x86_64: W: spelling-error %description -l en_US workspaces -> work spaces, work-spaces, works paces herbstluftwm.x86_64: W: spelling-error %description -l en_US ipc -> pic, inc herbstluftwm.x86_64: W: spelling-error %description -l en_US startup -> start up, start-up, upstart herbstluftwm.x86_64: E: wrong-script-interpreter /usr/share/doc/herbstluftwm/scripts/dmenu.sh /usr/bin/env bash herbstluftwm.x86_64: E: wrong-script-interpreter /usr/share/doc/herbstluftwm/scripts/dumpbeautify.sh /usr/bin/env bash herbstluftwm.x86_64: E: wrong-script-interpreter /usr/share/doc/herbstluftwm/scripts/exec_on_tag.sh /usr/bin/env bash herbstluftwm.x86_64: E: wrong-script-interpreter /usr/share/doc/herbstluftwm/scripts/execwith.sh /usr/bin/env bash herbstluftwm.x86_64: E: wrong-script-interpreter /usr/share/doc/herbstluftwm/scripts/float-maximize.sh /usr/bin/env bash herbstluftwm.x86_64: E: wrong-script-interpreter /usr/share/doc/herbstluftwm/scripts/floatmon.sh /usr/bin/env bash herbstluftwm.x86_64: E: wrong-script-interpreter /usr/share/doc/herbstluftwm/scripts/herbstcommander.sh /usr/bin/env bash herbstluftwm.x86_64: E: wrong-script-interpreter /usr/share/doc/herbstluftwm/scripts/keychain.sh /usr/bin/env bash herbstluftwm.x86_64: E: wrong-script-interpreter /usr/share/doc/herbstluftwm/scripts/lasttag.sh /usr/bin/env bash herbstluftwm.x86_64: E: wrong-script-interpreter /usr/share/doc/herbstluftwm/scripts/layout.sh /usr/bin/env bash herbstluftwm.x86_64: E: wrong-script-interpreter /usr/share/doc/herbstluftwm/scripts/loadstate.sh /usr/bin/env bash herbstluftwm.x86_64: E: wrong-script-interpreter /usr/share/doc/herbstluftwm/scripts/maximize.sh /usr/bin/env bash herbstluftwm.x86_64: E: wrong-script-interpreter /usr/share/doc/herbstluftwm/scripts/q3terminal.sh /usr/bin/env bash herbstluftwm.x86_64: E: wrong-script-interpreter /usr/share/doc/herbstluftwm/scripts/savestate.sh /usr/bin/env bash herbstluftwm.x86_64: E: wrong-script-interpreter /usr/share/doc/herbstluftwm/scripts/scratchpad.sh /usr/bin/env bash herbstluftwm.x86_64: E: wrong-script-interpreter /usr/share/doc/herbstluftwm/scripts/toggledualhead.sh /usr/bin/env bash herbstluftwm.x86_64: E: wrong-script-interpreter /usr/share/doc/herbstluftwm/scripts/windowmenu.sh /usr/bin/env bash herbstluftwm.x86_64: E: wrong-script-interpreter /usr/share/doc/herbstluftwm/scripts/wselect.sh /usr/bin/env bash herbstluftwm.x86_64: W: no-manual-page-for-binary dmenu_run_hlwm herbstluftwm-zsh.noarch: W: summary-not-capitalized C herbstluftwm zsh completion support herbstluftwm-zsh.noarch: W: no-documentation herbstluftwm-fish.noarch: W: summary-not-capitalized C herbstluftwm fish completion support herbstluftwm-fish.noarch: W: no-documentation herbstluftwm.src: W: spelling-error %description -l en_US subframes -> sub frames, sub-frames, frames herbstluftwm.src: W: spelling-error %description -l en_US workspaces -> work spaces, work-spaces, works paces herbstluftwm.src: W: spelling-error %description -l en_US ipc -> pic, inc herbstluftwm.src: W: spelling-error %description -l en_US herbstclient -> herbalist herbstluftwm.src: W: spelling-error %description -l en_US startup -> start up, start-up, upstart 6 packages and 0 specfiles checked; 18 errors, 14 warnings.
> - Use %set_build_flags > - Capitalize summaries Done and done. > - Fix the shebangs Done. Removed the entire scripts-directory as redundant from %doc. Spec URL: http://sham1.sinervo.fi/files/rpm-review/herbstluftwm/herbstluftwm.spec SRPM URL: http://sham1.sinervo.fi/files/rpm-review/herbstluftwm/herbstluftwm-0.7.2-1.fc30.src.rpm A koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=35693845
Package approved.
I've unretired package and built latest src.rpm from this bug for you.
FEDORA-2019-ea33f7ce32 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-ea33f7ce32
herbstluftwm-0.7.2-1.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-ea33f7ce32
I wonder if this would be a good use case for Boolean weak dependencies. "Recommends: (herbstluftwm-zsh if zsh)" would install completion automatically if zsh is installed, wouldn't it?
herbstluftwm-0.7.2-1.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report.