Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: https://fab.fedorapeople.org/packages/SRPMS/python-acora.spec SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/python-acora-2.2-1.fc30.src.rpm Project URL: https://github.com/scoder/acora Description: Acora is 'fgrep' for Python, a fast multi-keyword text search engine. Based on a set of keywords and the Aho-Corasick algorithm, it generates a search automaton and runs it over string input, either unicode or bytes. Acora comes with both a pure Python implementation and a fast binary module written in Cython. However, note that the current construction algorithm is not suitable for really large sets of keywords (i.e. more than a couple of thousand). Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=35663432 rpmlint output: $ rpmlint python-acora-2.2-1.fc30.src.rpm python-acora.src: W: spelling-error %description -l en_US fgrep -> grep, f grep python-acora.src: W: spelling-error %description -l en_US unicode -> Unicode, uni code, uni-code 1 packages and 0 specfiles checked; 0 errors, 2 warnings. $ rpmlint *acora* python3-acora.x86_64: W: spelling-error %description -l en_US fgrep -> grep, f grep python3-acora.x86_64: W: spelling-error %description -l en_US unicode -> Unicode, uni code, uni-code 3 packages and 0 specfiles checked; 0 errors, 2 warnings. Fedora Account System Username: fab
- Tests are failing, please notify upstream BUILDSTDERR: ====================================================================== BUILDSTDERR: ERROR: test_binary_data_search (__main__.BytesAcoraTest) BUILDSTDERR: ---------------------------------------------------------------------- BUILDSTDERR: Traceback (most recent call last): BUILDSTDERR: File "test.py", line 412, in test_binary_data_search BUILDSTDERR: ac = self._build(pattern) BUILDSTDERR: File "test.py", line 92, in _build BUILDSTDERR: machine = builder.build(acora=self.acora) BUILDSTDERR: File "/builddir/build/BUILD/acora-acora-2.2/acora/__init__.py", line 280, in build BUILDSTDERR: return acora(_build_trie(self.tree, ignore_case=self.ignore_case)) BUILDSTDERR: File "/builddir/build/BUILD/acora-acora-2.2/acora/__init__.py", line 91, in __init__ BUILDSTDERR: ch = convert(ch) BUILDSTDERR: TypeError: ord() expected string of length 1, but int found BUILDSTDERR: ============================================================ and so on for the rest of the tests - Package approved anyway. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "BSD 3-clause "New" or "Revised" License". 16 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/python-acora/review-python- acora/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python3-acora [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python3-acora-2.2-1.fc31.x86_64.rpm python-acora-debugsource-2.2-1.fc31.x86_64.rpm python-acora-2.2-1.fc31.src.rpm python3-acora.x86_64: W: spelling-error %description -l en_US fgrep -> grep, f grep python3-acora.x86_64: W: spelling-error %description -l en_US unicode -> Unicode, uni code, uni-code python-acora.src: W: spelling-error %description -l en_US fgrep -> grep, f grep python-acora.src: W: spelling-error %description -l en_US unicode -> Unicode, uni code, uni-code 3 packages and 0 specfiles checked; 0 errors, 4 warnings.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-acora
FEDORA-2019-dcbf644eeb has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-dcbf644eeb
python-acora-2.2-1.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-dcbf644eeb
python-acora-2.2-1.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report.