Bug 1722813 - Review Request: php-pecl-redis5 - Extension for communicating with the Redis key-value store
Summary: Review Request: php-pecl-redis5 - Extension for communicating with the Redis ...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Robert-André Mauchin
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-06-21 11:51 UTC by Remi Collet
Modified: 2019-06-21 14:28 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-06-21 14:28:49 UTC
zebob.m: fedora-review+


Attachments (Terms of Use)

Description Remi Collet 2019-06-21 11:51:36 UTC
Spec URL: https://git.remirepo.net/cgit/rpms/php/pecl/php-pecl-redis5.git/plain/php-pecl-redis5.spec?h=fedora&id=e5c369d4facbfd77601c6475e7a9f342f573ae50
SRPM URL: http://rpms.remirepo.net/SRPMS/php-pecl-redis5-5.0.0~RC1-1.fedora.src.rpm
Description: 
The phpredis extension provides an API for communicating
with the Redis key-value store.

This Redis client implements most of the latest Redis API.
As method only only works when also implemented on the server side,
some doesn't work with an old redis server version.


Fedora Account System Username: remi



---

The plan is to give the choice to F29/F30 users between API v4 and v5
And only maintain v5 in F31+
As it was done for php-pecl-redis => php-pecl-redis4


NOTICE: fedora-review is unable to download the right spec file.

Comment 1 Remi Collet 2019-06-21 11:52:02 UTC
Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=35681375

Comment 2 Remi Collet 2019-06-21 11:54:04 UTC
@Robert-André this one shlould be trivial, same than #1542902

Comment 3 Robert-André Mauchin 2019-06-21 13:14:11 UTC
Package approved.



Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
     Note: Unversioned so-files in private %_libdir subdirectory (see
     attachment). Verify they are not in ld path.
[x]: If your application is a C or C++ application you must list a
     BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "BSD 3-clause "New" or "Revised"
     License". 37 files have unknown license. Detailed output of
     licensecheck in /home/bob/packaging/review/php-pecl-redis5/review-php-
     pecl-redis5/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package does not own files or directories owned by other packages.
     Note: Dirs in package are owned also by:
     /usr/share/doc/pecl/redis(php-pecl-redis4)
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 153600 bytes in 4 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Fully versioned dependency in subpackages if applicable.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Uses parallel make %{?_smp_mflags} macro.
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on debuginfo package(s).
     Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.

PHP:
[ ]: Run phpci static analyze on all php files.
     Note: Test run failed


Rpmlint
-------
Checking: php-pecl-redis5-5.0.0~RC1-1.fc31.x86_64.rpm
          php-pecl-redis5-debuginfo-5.0.0~RC1-1.fc31.x86_64.rpm
          php-pecl-redis5-debugsource-5.0.0~RC1-1.fc31.x86_64.rpm
          php-pecl-redis5-5.0.0~RC1-1.fc31.src.rpm
php-pecl-redis5.x86_64: W: spelling-error %description -l en_US phpredis -> predispose
php-pecl-redis5.src: W: spelling-error %description -l en_US phpredis -> predispose
php-pecl-redis5.src: E: specfile-error warning: line 50: Possible unexpanded macro in: Requires:      php(zend-abi) = %{php_zend_api}
php-pecl-redis5.src: E: specfile-error warning: line 51: Possible unexpanded macro in: Requires:      php(api) = %{php_core_api}
4 packages and 0 specfiles checked; 2 errors, 2 warnings.

Comment 5 Gwyn Ciesla 2019-06-21 14:14:56 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/php-pecl-redis5

Comment 6 Remi Collet 2019-06-21 14:28:49 UTC
Built in rawhide.

Closing now, as I don't plan to push to stable repo (f29/f30) before 5.0.0GA (in a few days / weeks)


Note You need to log in before you can comment on or make changes to this bug.