Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1723299

Summary: Upload is broken on ssh
Product: [oVirt] ovirt-iso-uploader Reporter: Gal Zaidman <gzaidman>
Component: CoreAssignee: Gal Zaidman <gzaidman>
Status: CLOSED DUPLICATE QA Contact: Lukas Svaty <lsvaty>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 4.3.2CC: bugs
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-06-24 11:14:24 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Integration RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Gal Zaidman 2019-06-24 08:15:31 UTC
Description of problem:
When uploading to RHV ISO storage domains by SSH we get:

Running the command threw errors:

root> engine-iso-uploader --ssh-user=root --key-file=/etc/pki/ovirt-engine/keys/engine_id_rsa -i LON-DB_ISO upload CentOS-7-x86_64-Minimal-1810.iso
Please provide the REST API password for the admin@internal oVirt Engine user (CTRL+D to abort):
Uploading, please wait...
INFO: Start uploading CentOS-7-x86_64-Minimal-1810.iso
ERROR: Unable to copy CentOS-7-x86_64-Minimal-1810.iso to ISO storage domain on LON-DB_ISO.
ERROR: Error message is "unable to test the available space on /rhev/data/iso"

Running the command with the '-v' argument reveals more detail:

root> engine-iso-uploader -v --ssh-user=root --key-file=/etc/pki/ovirt-engine/keys/engine_id_rsa -i LON-DB_ISO upload CentOS-7-x86_64-Minimal-1810.iso
Please provide the REST API password for the admin@internal oVirt Engine user (CTRL+D to abort):
DEBUG: API Vendor(None) API Version(4.3.0)
DEBUG: id=2143f6d1-d622-4384-adfc-2196430dfa2e address=aflc08.on.bell.ca path=/rhev/data/iso
Uploading, please wait...
INFO: Start uploading CentOS-7-x86_64-Minimal-1810.iso
DEBUG: file (CentOS-7-x86_64-Minimal-1810.iso)
DEBUG: /usr/bin/ssh-p22-i /etc/pki/ovirt-engine/keys/engine_id_rsa  root.bell.ca "/usr/bin/test -e /rhev/data/iso/2143f6d1-d622-4384-adfc-2196430dfa2e/images/11111111-1111-1111-1111-111111111111/CentOS-7-x86_64-Minimal-1810.iso"
DEBUG: /usr/bin/ssh-p22-i /etc/pki/ovirt-engine/keys/engine_id_rsa  root.bell.ca "/usr/bin/test -e /rhev/data/iso/2143f6d1-d622-4384-adfc-2196430dfa2e/images/11111111-1111-1111-1111-111111111111/CentOS-7-x86_64-Minimal-1810.iso"
DEBUG: _cmds(['/usr/bin/ssh-p22-i', '/etc/pki/ovirt-engine/keys/engine_id_rsa', 'root.bell.ca', '/usr/bin/test -e /rhev/data/iso/2143f6d1-d622-4384-adfc-2196430dfa2e/images/11111111-1111-1111-1111-111111111111/CentOS-7-x86_64-Minimal-1810.iso'])
DEBUG: exists returning false
DEBUG: Mount point size test command is /usr/bin/ssh-p22-i /etc/pki/ovirt-engine/keys/engine_id_rsa  {root@}{aflc08.on.bell.ca} "{/usr/bin/python} -c 'import os;dir_stat = os.statvfs(\"{/rhev/data/iso}\"); print (dir_stat.f_bavail * dir_stat.f_frsize)'"
ERROR: Unable to copy CentOS-7-x86_64-Minimal-1810.iso to ISO storage domain on LON-DB_ISO.
ERROR: Error message is "unable to test the available space on /rhev/data/iso"

The following DEBUG message reveals the trouble:

DEBUG: Mount point size test command is /usr/bin/ssh-p22-i /etc/pki/ovirt-engine/keys/engine_id_rsa  {root@}{aflc08.on.bell.ca} "{/usr/bin/python} -c 'import os;dir_stat = os.statvfs(\"{/rhev/data/iso}\"); print (dir_stat.f_bavail * dir_stat.f_frsize)'"

The executed file is: /usr/bin/ssh-p22-i ...

The executed file should be: /usr/bin/ssh -p 22 -i ...

You can also see that the ssh user and destination are: {root@}{aflc08.on.bell.ca} 

They should be: root.bell.ca

The same {} problem occurs with {/usr/bin/python} and {/rhev/data/iso}  (the curly braces should not surround the strings).

Comment 1 Gal Zaidman 2019-06-24 11:14:24 UTC

*** This bug has been marked as a duplicate of bug 1722933 ***