Bug 1723575 - Review Request: python-insights-core - data collection and processing framework
Summary: Review Request: python-insights-core - data collection and processing framework
Keywords:
Status: NEW
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1723570 1723572
Blocks: FE-NEEDSPONSOR
TreeView+ depends on / blocked
 
Reported: 2019-06-24 20:29 UTC by Dylan Stephano-Shachter
Modified: 2020-02-06 03:07 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed:
Type: ---


Attachments (Terms of Use)

Description Dylan Stephano-Shachter 2019-06-24 20:29:33 UTC
Spec URL: https://copr-be.cloud.fedoraproject.org/results/dstathis/insights-core/fedora-30-x86_64/00944257-insights-core/python-insights-core.spec
SRPM URL: https://copr-be.cloud.fedoraproject.org/results/dstathis/insights-core/fedora-30-x86_64/00944257-insights-core/insights-core-3.0.100.974-1.fc30.src.rpm
Description: Insights Core is a data collection and analysis framework that is built for extensibility and rapid development. Included are a set of reusable components for gathering data in myriad ways and providing a reliable object model for commonly useful unstructured and semi-structured data.
https://github.com/RedHatInsights/insights-core

ps: This is my first batch of Review requests and I am seeking a packaging sponsor.
Fedora Account System Username: dstathis

Comment 1 Elliott Sales de Andrade 2019-06-24 22:18:37 UTC
New Python packages must receive an exception to contain Python 2 version, or just not bother with it. Please fill out the Summary and Description in the spec to something more substantial than just repeating the name.

Comment 3 Dylan Stephano-Shachter 2019-06-26 19:59:15 UTC
Sorry that one is for cachecontrol. I'll get the ones for insights-core up momentarily.

Comment 5 Robert-André Mauchin 🐧 2019-07-12 00:08:08 UTC
 - Use a bcond_without for this

%if 0%{?rhel} == 7
%bcond_without python2
%endif

And then:

%if %{with python2}
blah blah
%endif

 - Xour descriptions must be wrapped to 80 characters per line

- Name should be:

Name:		python-%{pkgname}

 - Comments at the end of line are not supported officially by rpm:

%endif # with_python2

  This will fail with rpm 4.15


 - Install the examples with %doc

%files -n python%{python3_pkgversion}-%{pkgname}
%doc examples

 - Build the docs with Sphinx and install them with %doc

# generate html docs
sphinx-build-3 docs html
# remove the sphinx-build leftovers
rm -rf html/.{doctrees,buildinfo}

 -Install the misc docs markdown files:

%files -n python%{python3_pkgversion}-%{pkgname}
%doc examples
%doc CHANGELOG.md CONTRIBUTING.md README.rst

 - you *must* install the LICENSE file with %license in %files for any subpackage compination:

%files -n python2-%{pkgname}
%license LICENSE

%files -n python%{python3_pkgversion}-%{pkgname}
%license LICENSE

 - You are missing the Python provide macro:

%package -n python2-%{pkgname}
Summary:	Data collection and processing framework
%{?python_provide:%python_provide python2-%{pkgname}}

%package -n python%{python3_pkgversion}-%{pkgname}
Summary:	Data collection and processing framework
%{?python_provide:%python_provide python3-%{pkgname}}

See https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_the_python_provide_macro

 - add a space between your name and email in you changelog entry

Comment 6 Dylan Stephano-Shachter 2019-07-12 18:02:18 UTC
I am having a bit of difficulty properly building the docs. It could be done easily withing a virtualenv. Would that be an reasonable thing to do inside an rpm build given that it is only used to build the docs?

Comment 7 Dylan Stephano-Shachter 2019-07-12 18:21:04 UTC
I realized that building the docs with a virtualenv requires "--enable-networking" which I think is not ideal. I will try to figure out how to get the docs without it.

Comment 8 Robert-André Mauchin 🐧 2019-07-12 19:08:04 UTC
Usually it's just something like:

# generate html docs
sphinx-build-3 docs html
# remove the sphinx-build leftovers
rm -rf html/.{doctrees,buildinfo}


What problem are you encountering?

Comment 9 Dylan Stephano-Shachter 2019-07-12 19:55:11 UTC
After adding a number of build dependencies and removing the -W from sphinx-build-3 I have gotten it to build the docs. There are, however, two warning messages that concern me.

/usr/lib/python3.7/site-packages/nbsphinx.py:1174: RuntimeWarning: You are using an unsupported version of pandoc (2.2.1).
Your version must be at least (1.12.1) but less than (2.0.0).
Refer to http://pandoc.org/installing.html.
Continuing with doubts...
  nbconvert.utils.pandoc.check_pandoc_version()


and 


WARNING: Pygments lexer name 'ipython2' is not known


Each one is repeated numerous times and the packages required don't seem to exist in the fedora repos. Pandoc is too new and python2-ipython is no longer packaged


Note: There is a further concern that many of the build dependencies don't exist for python 2 on Centos 7 but that is an issue I will deal with when I submit to EPEL

Comment 10 Elliott Sales de Andrade 2020-02-06 03:07:10 UTC
There's not much you can do about the first one, except wait for a new nbshinx package. I think for the latter, it's also about nbshinx, so you might have to wait for an update there too.


Note You need to log in before you can comment on or make changes to this bug.