Bug 172388 - mhshow crashes on empty Content-Type
mhshow crashes on empty Content-Type
Status: CLOSED ERRATA
Product: Fedora
Classification: Fedora
Component: nmh (Show other bugs)
4
i386 Linux
medium Severity medium
: ---
: ---
Assigned To: Josh Bressers
Fedora Extras Quality Assurance
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2005-11-03 12:36 EST by Joel Uckelman
Modified: 2007-11-30 17:11 EST (History)
1 user (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2005-11-03 14:38:43 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)
show crash output (1.94 KB, text/plain)
2005-11-03 12:43 EST, Joel Uckelman
no flags Details
sample crash-causing message (620 bytes, text/plain)
2005-11-03 12:44 EST, Joel Uckelman
no flags Details
Fix for this issue (463 bytes, patch)
2005-11-03 14:37 EST, Josh Bressers
no flags Details | Diff

  None (edit)
Description Joel Uckelman 2005-11-03 12:36:53 EST
From Bugzilla Helper:
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.12) Gecko/20050920 Firefox/1.0.7

Description of problem:
When a multipart/mixed message has a part with an empty Content-Type, show crashes , apparently due to some memory being double-freed.

Version-Release number of selected component (if applicable):
nmh-1.1-9.fc4

How reproducible:
Always

Steps to Reproduce:
1. Put the example message in a folder.
2. show it.

Actual Results:  show crashes

Expected Results:  show should do something graceful, like assume that the faulty part is text/plain or notify the user that the part is being skipped.

Additional info:
Comment 1 Joel Uckelman 2005-11-03 12:43:07 EST
Created attachment 120694 [details]
show crash output
Comment 2 Joel Uckelman 2005-11-03 12:44:15 EST
Created attachment 120695 [details]
sample crash-causing message
Comment 3 Joel Uckelman 2005-11-03 12:50:53 EST
Incidentally, leaving a Content-Type empty violates RFC 1521. Whatever email
client which is generating these is seriously broken.
Comment 4 Josh Bressers 2005-11-03 14:37:01 EST
Created attachment 120701 [details]
Fix for this issue

The problem here is that when something goes wrong during mime processing, nmh
will try to close a file stream twice.	This patch removes the spurious
fclose().
Comment 5 Josh Bressers 2005-11-03 14:38:43 EST
This issue is fixed in nmh-1.1-10.fc3, nmh-1.1-10.fc4 and nmh-1.1-10.fc5.

Note You need to log in before you can comment on or make changes to this bug.