Spec Name or Url: http://www.cora.nwra.com/~orion/fedora/kdesvn.spec SRPM Name or Url: http://www.cora.nwra.com/~orion/fedora/kdesvn-0.6.3-1.src.rpm Description: KDESvn is a frontend to the subversion vcs. In difference to most other tools it uses the subversion C-Api direct via a c++ wrapper made by Rapid SVN and doesn't parse the output of the subversion client. So it is a real client itself instead of a frontend to the command line tool. It is designed for the K-Desktop environment and uses all of the goodies it has. It is planned for future that based on the native client some plugins for konqueror and/or kate will made. URL: http://www.alwins-world.de/programs/kdesvn/
Needs work: * Use of buildroot is not consistant (wiki: PackagingGuidelines#UsingBuildRootOptFlags) * Just BuildRequires the "desktop-file-utils" package, not /usr/bin/desktop-file-install. * Scriptlets: missing update-desktop-database (wiki: ScriptletSnippets) * Desktop file: the Categories tag should contain Application (wiki: PackagingGuidelines#desktop) * Scriptlets: missing "gtk-update-icon-cache" in %post and %postun (wiki: ScriptletSnippets) * Why patch out the icon in the desktop file ?
(In reply to comment #1) > Needs work: > * Use of buildroot is not consistant > (wiki: PackagingGuidelines#UsingBuildRootOptFlags) oops, fixed. > * Just BuildRequires the "desktop-file-utils" package, not > /usr/bin/desktop-file-install. okay, fixed. > * Scriptlets: missing update-desktop-database (wiki: ScriptletSnippets) Hmm, didn't think it had a MimeType entry, but I guess it does. Added. > * Desktop file: the Categories tag should contain Application > (wiki: PackagingGuidelines#desktop) Added. > * Scriptlets: missing "gtk-update-icon-cache" in %post and %postun > (wiki: ScriptletSnippets) > * Why patch out the icon in the desktop file ? There are two Icon entries in the upstream version. I'm removing the duplicate. http://www.cora.nwra.com/~orion/fedora/kdesvn-0.6.3-2.src.rpm
Please replace the call to "/usr/bin/desktop-file-install" in the spec file by a simple "desktop-file-install" (without the path). Everything else looks OK.
(In reply to comment #3) > Please replace the call to "/usr/bin/desktop-file-install" in the spec file by a > simple "desktop-file-install" (without the path). Everything else looks OK. Re-released -2 without the path. Can you mark as approved? Thanks for the review!
Review for release 2: * RPM name is OK * Source kdesvn-0.6.3.tar.gz is the same as upstream * Builds fine in mock * rpmlint of kdesvn looks OK * File list of kdesvn looks OK * Works fine APPROVED
Build succeeded on devel.