SRPM Name or Url: fttp://www.environnement.ens.fr/perso/dumas/fc-srpms/acpitool-0.3.0-2.src.rpm Description: AcpiTool is a Linux ACPI client. It's a small command line application, intended to be a replacement for the apm tool. The primary target audience are laptop users, since these people are most interested in things like battery status, thermal status and the ability to suspend (sleep mode). The program simply accesses the /proc/acpi or /sysfs entries to get/set acpi values. Hence, a computer running a Linux kernel from the 2.4.x or 2.6.x series with ACPI enabled is needed.
The correct url is in fact: http://www.environnement.ens.fr/perso/dumas/fc-srpms/acpitool-0.3.0-2.src.rpm
`-mcpu=' is deprecated. Use `-mtune=' or '-march=' instead. Specify CXXFLAGS to configure, like %configure CXXFLAGS=%{_optflags} Good: - package meets naming guidelines - package meets packaging guidelines - license (GPL) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream - package compiles on FC4 i386 - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file Have not tested yet.
%configure allready defines CXXFLAGS to the right value; the issue is in the upstream configure.in script where compiler flags are setting although they shouldn't. I have patched the configure script, now it uses the optflags. See the srpm here: http://www.environnement.ens.fr/perso/dumas/fc-srpms/acpitool-0.3.0-3.src.rpm I also have contacted the upstream.
Clean build now. APPROVED
Normalize summary field for easy parsing