Bug 172476 - netpoll: avoid kfree_skb on packets with destructors
netpoll: avoid kfree_skb on packets with destructors
Product: Red Hat Enterprise Linux 4
Classification: Red Hat
Component: kernel (Show other bugs)
All Linux
medium Severity medium
: ---
: ---
Assigned To: Neil Horman
Brian Brock
Depends On:
  Show dependency treegraph
Reported: 2005-11-04 18:07 EST by Jeff Moyer
Modified: 2007-11-30 17:07 EST (History)
3 users (show)

See Also:
Fixed In Version: RHBA-2007-0304
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2007-05-01 19:57:20 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---

Attachments (Terms of Use)
don't call __kfree_skb on skb's with destructors (460 bytes, patch)
2005-11-04 18:07 EST, Jeff Moyer
no flags Details | Diff

External Trackers
Tracker ID Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2007:0304 normal SHIPPED_LIVE Updated kernel packages available for Red Hat Enterprise Linux 4 Update 5 2007-04-28 14:58:50 EDT

  None (edit)
Description Jeff Moyer 2005-11-04 18:07:53 EST
Description of problem:

Netpoll will generate an unwanted printk when __kfree_skb is called with a
destructor from interrupt context.  Here is a discussion of the patch:

The version for RHEL will also have a conditional based upon whether or not we
are in netdump_mode.  If in netdump_mode, always do __kfree_skb, as we otherwise
have no way of freeing the skb.

Version-Release number of selected component (if applicable):

How reproducible:

Steps to Reproduce:
Actual results:

Expected results:

Additional info:
Comment 1 Jeff Moyer 2005-11-04 18:07:53 EST
Created attachment 120746 [details]
don't call __kfree_skb on skb's with destructors
Comment 2 Neil Horman 2006-12-06 08:57:28 EST
built, verified and posted.  Thanks!
Comment 3 Jason Baron 2007-01-05 11:27:23 EST
committed in stream U5 build 42.38. A test kernel with this patch is available
from http://people.redhat.com/~jbaron/rhel4/
Comment 4 RHEL Product and Program Management 2007-01-18 11:27:47 EST
This request was evaluated by Red Hat Product Management for inclusion in a Red
Hat Enterprise Linux maintenance release.  Product Management has requested
further review of this request by Red Hat Engineering, for potential
inclusion in a Red Hat Enterprise Linux Update release for currently deployed
products.  This request is not yet committed for inclusion in an Update
Comment 5 Jay Turner 2007-01-18 15:46:49 EST
QE ack for RHEL4.5.
Comment 8 Red Hat Bugzilla 2007-05-01 19:57:20 EDT
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on the solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.


Note You need to log in before you can comment on or make changes to this bug.