Bug 1724961 - [v2v][UI] Turn "VMs" Field into "VMs & Templates"
Summary: [v2v][UI] Turn "VMs" Field into "VMs & Templates"
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Console Kubevirt Plugin
Version: unspecified
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ---
: 4.6.0
Assignee: Marek Libra
QA Contact: Maayan Hadasi
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-06-28 07:38 UTC by Ilanit Stein
Modified: 2020-06-24 18:49 UTC (History)
9 users (show)

Fixed In Version: 4.2.0-0.ci-2019-08-02-184554/
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-01-30 16:27:11 UTC
Target Upstream Version:
Embargoed:
mlibra: needinfo-


Attachments (Terms of Use)
Screenshot (fixed) (63.13 KB, image/png)
2019-12-11 11:16 UTC, Maayan Hadasi
no flags Details


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHEA-2020:0307 0 None None None 2020-01-30 16:27:21 UTC

Description Ilanit Stein 2019-06-28 07:38:03 UTC
Description of problem:

In Create VM wizard dialog, Import, under VMs field, VMware VMs, as well as Templates are listed.
Therefore, it is more reasonable to name the field something like: 
"VMs & Templates".

Version-Release number of selected component (if applicable):
bundle-registry:v2.0.0-33

Comment 1 Marek Libra 2019-07-30 08:33:17 UTC
Please correct me, but I think the proposed fix could be confusing for the user, since we are in "Create VM" dialog.
If source object is a VMware template (not a VM), the user could expect a "VM Template" to be imported.

To fully close the gap, we should differentiate between these two by adding the "Import" to the "Create Template" wizard.
That would need extra work and thinking, so I doubt such a change would be acked as bugfix, means it's out of 2.1 scope. But I might be wrong ....


As a good enough fix for 2.1, we can list only VMware VMs (excluding templates). This can be filtered out on the "kubevirt-vmware" operator level.

Comment 2 Marek Libra 2019-07-30 10:34:05 UTC
On the second thought, recent combination of VMs and templates has been documented and removing would cause a regression.
The user is in "Create Virtual Machine" wizard, so a VM is expected as a result.

Comment 3 Marek Libra 2019-07-30 10:50:41 UTC
Patch: https://github.com/kubevirt/web-ui-components/pull/529

Comment 4 Tomas Jelinek 2019-09-30 15:05:47 UTC
Since the v2v has been removed from 2.1.0, retargeting bugs to 2.1.1 to make sure they will be verified on the right version.

Comment 5 Brett Thurber 2019-10-21 19:12:10 UTC
Mooving to ON_QA.

Comment 6 Nelly Credi 2019-11-11 12:27:37 UTC
please add fixed in version

Comment 7 Marek Libra 2019-11-12 09:25:46 UTC
Merged on Jul 30, so should be included in 4.2.0-0.ci-2019-08-02-184554/

Comment 8 Maayan Hadasi 2019-12-11 11:16:46 UTC
Created attachment 1643844 [details]
Screenshot (fixed)

Comment 9 Maayan Hadasi 2019-12-11 11:17:20 UTC
Verified as fixed in version: CNV 2.2.0-10

VMs and templates are listed in list named: "VM or Template to Import"

Attached screenshot.

Comment 11 errata-xmlrpc 2020-01-30 16:27:11 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2020:0307


Note You need to log in before you can comment on or make changes to this bug.