Bug 1724977 - Negative setting for console customization keeps refreshing newer versions and yaml can not be updated again.
Summary: Negative setting for console customization keeps refreshing newer versions an...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Management Console
Version: 4.2.0
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ---
: 4.2.0
Assignee: Jakub Hadvig
QA Contact: Yadan Pei
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-06-28 07:55 UTC by XiaochuanWang
Modified: 2019-10-16 06:32 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-10-16 06:32:46 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
versions keep refreshing with error message (104.09 KB, image/png)
2019-06-28 07:55 UTC, XiaochuanWang
no flags Details


Links
System ID Private Priority Status Summary Last Updated
Github openshift console-operator pull 253 0 None None None 2019-07-09 14:38:11 UTC
Red Hat Product Errata RHBA-2019:2922 0 None None None 2019-10-16 06:32:57 UTC

Description XiaochuanWang 2019-06-28 07:55:44 UTC
Created attachment 1585480 [details]
versions keep refreshing with error message

Description of problem:
Cluster admin set some negative values for console.operator.openshift.io accessed from CRD Instance. Save the setting and try to update it back. It keeps reloading new version and can not get user update it. However oc command line can update it.

Version-Release number of selected component (if applicable):
4.2.0-0.nightly-2019-06-27-204704
image: quay.io/openshift-release-dev/ocp-v4.0-art-dev@sha256:47a0200aff7c9d4db5fb03d915220080939ebbce272b09c5c149bb6a774d7175

How reproducible:
Always

Steps to Reproduce:
1. Cluster admin goes to console.operator.openshift.io detail page accessed from CRD Instance. (url: k8s/cluster/operator.openshift.io~v1~Console/cluster/yaml)
2. Try to set customization some invalid value:
  customization:
    brand: ocp
    customLogoFile:
      key: invalid
      name: myconfig-ngtv
    customProductName: my-custom-name
3. Save and check
4. Try to set it back.

Actual results:
3. After save, it pops up the error message "his object has been updated. Click reload to see the new version."
4. It keeps refreshing newer version, user can not set it back unless use "oc edit console.operator.openshift.io".
Refer to the screenshot.

Expected results:
4. Should stop keeps refreshing newer versions.

Additional info:
1) This could be correctly set:
  customization:
    brand: ocp
    customProductName: my-custom-name
2) CLI works using "oc edit console.operator.openshift.io"

Comment 1 Samuel Padgett 2019-07-03 19:05:20 UTC
Sounds like the operator is hot looping on bad config

Comment 2 Jakub Hadvig 2019-07-12 08:59:10 UTC
Fixing PR: https://github.com/openshift/console-operator/pull/253

Comment 4 XiaochuanWang 2019-08-19 06:13:05 UTC
Thanks Jakub!

Tested on 4.2.0-0.nightly-2019-08-18-054211. There is no loop refreshing for versions now. 

However the invalid value won't show any error message and it could be saved "successfully".
So is there any plan to fix for the error message?

Comment 5 Jakub Hadvig 2019-08-20 09:59:18 UTC
So the message should be shown but you need to bump logging for the console-operator.
Otherwise just the 'CustomLogoConfigMapDegraded' condition will be shown:
----
    - lastTransitionTime: '2019-08-20T09:37:18Z'
      message: custom logo file myconfig-ngtv not found
      reason: CustomLogoConfigMapError
      status: 'True'
      type: CustomLogoConfigMapDegraded
----

Comment 6 Samuel Padgett 2019-08-20 13:26:30 UTC
The message is correct since the config itself was in fact saved successfully. As long as the console is correctly reporting degraded when the config map key doesn't exist, this is working as intended.

Comment 7 XiaochuanWang 2019-08-22 07:13:18 UTC
Thanks for the confirm. This could be Verified.

Comment 8 errata-xmlrpc 2019-10-16 06:32:46 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2019:2922


Note You need to log in before you can comment on or make changes to this bug.