Bug 1724981 - nodectl info fails on python3 / fc29
Summary: nodectl info fails on python3 / fc29
Keywords:
Status: CLOSED DUPLICATE of bug 1728998
Alias: None
Product: ovirt-node
Classification: oVirt
Component: General
Version: master
Hardware: Unspecified
OS: Unspecified
high
urgent
Target Milestone: ovirt-4.4.0
: ---
Assignee: Nir Levy
QA Contact: cshao
URL:
Whiteboard:
Depends On:
Blocks: oVirt_on_Fedora
TreeView+ depends on / blocked
 
Reported: 2019-06-28 08:00 UTC by Sandro Bonazzola
Modified: 2019-10-22 06:28 UTC (History)
11 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2019-07-31 09:21:41 UTC
oVirt Team: Node
Embargoed:
sbonazzo: ovirt-4.4?
sbonazzo: planning_ack?
sbonazzo: devel_ack+
cshao: testing_ack+

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 102255 0 master POST Fix: nodectl info does not work. python3 regexp behaviour for non greedy fixed causing the term r'\n?(?=\w) to m... 2019-07-30 10:41:41 UTC

Description Sandro Bonazzola 2019-06-28 08:00:35 UTC 
Installed fc29 iso from: https://jenkins.ovirt.org/job/ovirt-node-ng-image_standard-check-patch/61/artifact/check-patch.fc29.x86_64/ovirt-node-ng-installer-4.4.0-2019062608.fc29.iso

# rpm -qvf `which nodectl`
ovirt-node-ng-nodectl-4.4.0-0.20190614.0.fc29.noarch


# nodectl info
Traceback (most recent call last):
  File "/usr/lib64/python3.7/runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "/usr/lib64/python3.7/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/usr/lib/python3.7/site-packages/nodectl/__main__.py", line 42, in <module>
    CliApplication()
  File "/usr/lib/python3.7/site-packages/nodectl/__init__.py", line 200, in CliApplication
    return cmdmap.command(args)
  File "/usr/lib/python3.7/site-packages/nodectl/__init__.py", line 118, in command
    return self.commands[command](**kwargs)
  File "/usr/lib/python3.7/site-packages/nodectl/__init__.py", line 76, in info
    Info(self.imgbased, self.machine).write()
  File "/usr/lib/python3.7/site-packages/nodectl/info.py", line 46, in __init__
    self._fetch_information()
  File "/usr/lib/python3.7/site-packages/nodectl/info.py", line 49, in _fetch_information
    self._get_bootloader_info()
  File "/usr/lib/python3.7/site-packages/nodectl/info.py", line 62, in _get_bootloader_info
    bootinfo["entries"][k] = v.__dict__
AttributeError: 'list' object has no attribute '__dict__'
Comment 1 Yuval Turgeman 2019-07-30 10:16:13 UTC 
What version is this ? I think it was fixed in https://gerrit.ovirt.org/#/c/101731/
Comment 2 Yuval Turgeman 2019-07-30 10:25:45 UTC 
yes pretty sure this is a duplicate of bug 1728998
Comment 3 Yuval Turgeman 2019-07-31 09:21:41 UTC 

*** This bug has been marked as a duplicate of bug 1728998 ***
Comment 4 Sandro Bonazzola 2019-10-22 06:28:37 UTC 
(In reply to Yuval Turgeman from comment #1)
> What version is this ? I think it was fixed in
> https://gerrit.ovirt.org/#/c/101731/

ovirt-node-ng-nodectl-4.4.0-0.20190614.0.fc29.noarch
fix was merged in July, so yes, it's fixed now.
Note You need to log in before you can comment on or make changes to this bug.