Red Hat Bugzilla – Bug 172579
Review Request: gtkwave - Waveform Viewer
Last modified: 2007-11-30 17:11:16 EST
Spec Name or Url: http://www.city-fan.org/~paul/extras/gtkwave/gtkwave.spec
SRPM Name or Url: http://www.city-fan.org/~paul/extras/gtkwave/gtkwave-1.3.76-3.src.rpm
GTKWave is a waveform viewer that can view VCD files produced by most Verilog
simulation tools, as well as LXT files produced by certain Verilog simulation
This package includes support for reading .ghw files as produced by ghdl.
This review request follows on from Bug 172547, which was a combined ghdl/gtkwave submission.
Thanks, looks good. Compiled and tested against a GHDL ghw file, works.
rpmlint gives me these:
E: gtkwave unknown-key GPG#b56a8bac
E: gtkwave configure-without-libdir-spec
I've sent the ghw patch to the gtkwave author, no answer yet, but we'll see...
(In reply to comment #1)
> Thanks, looks good. Compiled and tested against a GHDL ghw file, works.
> rpmlint gives me these:
> E: gtkwave unknown-key GPG#b56a8bac
This is normal since I signed the package and rpmlint doesn't recognise my key.
> E: gtkwave configure-without-libdir-spec
This is to be expected since gtkwave's configure script is not an
autotools-generated one and does not expect a --libdir= parameter.
> I've sent the ghw patch to the gtkwave author, no answer yet, but we'll see...
Hopefully it'll get included upstream, since it doesn't (I think) break any
Are you able to approve the package?
Package now updated to 1.3.77, which includes the ghw support upstream so the
patches are dropped.
Package now updated to 1.3.78.
Package now updated to 1.3.79.
Looks good - there's an rpmlint errors:
[mpeters@utility result]$ ls *.rpm
[mpeters@utility result]$ rpmlint *.rpm
E: gtkwave configure-without-libdir-spec
E: gtkwave-debuginfo script-without-shellbang
First can be ignored, second probably can be fixed.
I'll work on formal review, with the rpmlint debuginfo noted.
[mpeters@utility gtkwave-1.3.79]$ ls -l src/helpers/ |grep "h$"
-rw-r--r-- 1 mpeters family 8608 Jan 18 2004 lxt2_read.h
-rw-r--r-- 1 mpeters family 9684 Feb 4 2004 lxt2_write.h
-rwxr-xr-x 1 mpeters family 7863 Oct 26 22:17 lxt_write.h
-rw-r--r-- 1 mpeters family 3689 Feb 4 2004 v2l_analyzer.h
-rw-r--r-- 1 mpeters family 3615 Feb 22 2004 v2l_analyzer_lxt2.h
-rw-r--r-- 1 mpeters family 2654 Nov 3 2002 v2l_debug.h
-rw-r--r-- 1 mpeters family 2654 Feb 11 2003 v2l_debug_lxt2.h
-rw-r--r-- 1 mpeters family 8149 Mar 26 2005 vzt_read.h
-rw-r--r-- 1 mpeters family 9014 Feb 27 2005 vzt_write.h
removing the execution bit on that header file should fix the debuginfo rpmlint
Review per http://fedoraproject.org/wiki/PackageReviewGuidelines
See rpmlint comment #6 and #7
* With above noted exception, rpmlint clean
- error on configure ignorable as explained in comment #2
* Package properly named according to guidelines
* Spec file name matches src.rpm name
* Package meets packaging guidelines
* Package license (GPL & MIT) matches src
* License files in %doc
* Written in American English, legible
* Source matches upstream timestamp and md5sum
* Package succesfully builds on x86 (fc4)
* No BuildRequires in exceptions section of packaging guidelines
* All other BuildRequires properly specified
* No locale files that need find_lang
* No shared libraries
* No use of Prefix
* Package owns all directories it creates
* Proper Permissions
* Proper %clean
* consistent use of macros
* contains permissable code
* does not need docs subpackage
* Works without files in %doc
* No devel package concerns
** Desktop File -
- 'Twould be nice if it had one, but as explained in specfile:
# Note that GTKWave is a GUI application but no desktop entry is provided for it.
# This is because the application requires at least one mandatory parameter (file
# to view) and cannot be opened in a "no file" mode from a menu.
- Hopefully upstream will decide to change that at some point.
* Package builds in mock
Fix the rpmlint warning on debuginfo package and I'll approve.
Updated package fixes debuginfo rpmlint issue. I also added a comment in the
spec file about the configure script not being an autotools-generated one and
hence not supporting --libdir.
Build on target fedora-development-extras succeeded.