Bug 1726249 - subscriptions disappear after saving changes
Summary: subscriptions disappear after saving changes
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: UI - OPS
Version: 5.10.6
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: GA
: 5.11.0
Assignee: Milan Zázrivec
QA Contact: Md Nadeem
Red Hat CloudForms Documentation
URL:
Whiteboard:
Depends On:
Blocks: 1740228
TreeView+ depends on / blocked
 
Reported: 2019-07-02 12:25 UTC by Ievgen Zapolskyi
Modified: 2020-02-17 13:09 UTC (History)
11 users (show)

Fixed In Version: 5.11.0.19
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1740228 (view as bug list)
Environment:
Last Closed: 2019-12-13 14:58:07 UTC
Category: Bug
Cloudforms Team: CFME Core
Target Upstream Version:
Embargoed:
mfeifer: mirror+


Attachments (Terms of Use)
screenshot (427.98 KB, image/png)
2019-07-02 12:25 UTC, Ievgen Zapolskyi
no flags Details
second screenshot (119.61 KB, image/png)
2019-07-02 15:10 UTC, Ievgen Zapolskyi
no flags Details

Description Ievgen Zapolskyi 2019-07-02 12:25:06 UTC
Created attachment 1586674 [details]
screenshot

Description of problem:
When click save after editing some remote region subscription in settings of global region appliance, the rest of existing subscriptions disappear until refresh. look at screenshot

Version-Release number of selected component (if applicable):
5.10.6

How reproducible:
100%

Steps to Reproduce:
1. Set up 3 appliances, first and second appliances are in different remote regions, third one in global region.
2. add subscription to remote region appliances in global region appliance
3. Go to Configuration->Region-> Replication tab in global region appliance
4. click Update button on any existing subscription
5. type 5432 port to port edit field in order to cause some changes
6. click Accept button
7. click Save button

Actual results:
other existing subscriptions except edited out disappeared


Expected results:
no such issue

Additional info:

Comment 2 Ievgen Zapolskyi 2019-07-02 15:04:40 UTC
there are also issues with updating subscription list after deleting one of subscriptions and etc.

look at second screenshot.

Comment 3 Ievgen Zapolskyi 2019-07-02 15:10:32 UTC
Created attachment 1586743 [details]
second screenshot

Comment 5 Ievgen Zapolskyi 2019-07-02 16:23:01 UTC
This is UI issue. view looks correctly after refresh.

Comment 7 Milan Zázrivec 2019-07-17 06:14:28 UTC
(In reply to Marianne Feifer from comment #6)
> Hey, Milan.  Dennis is on PTO and asked me to just check in on 5.10.8 BZs
> that are in NEW or ASSIGNED just to be sure that you are aware.

I don't think messages like this belong to a bug report.

I'm also canceling the needinfo here, since no information was requested.

Comment 9 CFME Bot 2019-08-07 10:56:14 UTC
New commits detected on ManageIQ/manageiq-ui-classic/master:

https://github.com/ManageIQ/manageiq-ui-classic/commit/76f768c12032fdaa20807c0eff92d4bc5167f441
commit 76f768c12032fdaa20807c0eff92d4bc5167f441
Author:     Milan Zazrivec <mzazrivec>
AuthorDate: Wed Jul 17 10:25:56 2019 -0400
Commit:     Milan Zazrivec <mzazrivec>
CommitDate: Wed Jul 17 10:25:56 2019 -0400

    Don't modify original model value for form submission

    Here we need to remove non-edited (non-changed) items from the model
    so that we submit only things that changed. We cannot modify the orignal
    model though, since that would be reflected in the replication screen
    (i.e. the non-edited items would disappear from the screen after hitting
    Save).

    https://bugzilla.redhat.com/show_bug.cgi?id=1726249

 app/assets/javascripts/controllers/ops/pglogical_replication_form_controller.js | 5 +-
 1 file changed, 3 insertions(+), 2 deletions(-)


https://github.com/ManageIQ/manageiq-ui-classic/commit/ce3fd44cfd0968a73998cd53390a732c5c279982
commit ce3fd44cfd0968a73998cd53390a732c5c279982
Author:     Milan Zazrivec <mzazrivec>
AuthorDate: Wed Jul 17 12:18:15 2019 -0400
Commit:     Milan Zazrivec <mzazrivec>
CommitDate: Wed Jul 17 12:18:15 2019 -0400

    Fix 'Cancel Delete' styling and popup menu

    - style fix for the delete button
    - disable kebab button for cancel delete row

    https://bugzilla.redhat.com/show_bug.cgi?id=1726249

 app/views/ops/_settings_replication_tab.html.haml | 17 +-
 1 file changed, 9 insertions(+), 8 deletions(-)


https://github.com/ManageIQ/manageiq-ui-classic/commit/0e1ccd943545f273d56d6c3602b06c460a8acdc6
commit 0e1ccd943545f273d56d6c3602b06c460a8acdc6
Author:     Milan Zazrivec <mzazrivec>
AuthorDate: Tue Jul 23 07:55:55 2019 -0400
Commit:     Milan Zazrivec <mzazrivec>
CommitDate: Tue Jul 23 07:55:55 2019 -0400

    Cleaner way of constructing list of modified resources

    https://bugzilla.redhat.com/show_bug.cgi?id=1726249

 app/assets/javascripts/controllers/ops/pglogical_replication_form_controller.js | 17 +-
 1 file changed, 13 insertions(+), 4 deletions(-)

Comment 10 CFME Bot 2019-08-07 22:37:37 UTC
New commit detected on ManageIQ/manageiq-ui-classic/ivanchuk:

https://github.com/ManageIQ/manageiq-ui-classic/commit/b69330d2ae559f91888161a08455be0747ed06ff
commit b69330d2ae559f91888161a08455be0747ed06ff
Author:     Martin Hradil <mhradil>
AuthorDate: Wed Aug  7 06:55:32 2019 -0400
Commit:     Martin Hradil <mhradil>
CommitDate: Wed Aug  7 06:55:32 2019 -0400

    Merge pull request #5825 from mzazrivec/replication_form_fixes

    Don't modify original model value for form submission

    (cherry picked from commit 7ae36c6b2addf464a33cdec17d76114c1635b8e4)

    https://bugzilla.redhat.com/show_bug.cgi?id=1726249

 app/assets/javascripts/controllers/ops/pglogical_replication_form_controller.js | 18 +-
 app/views/ops/_settings_replication_tab.html.haml | 17 +-
 2 files changed, 23 insertions(+), 12 deletions(-)


Note You need to log in before you can comment on or make changes to this bug.