Spec URL: https://github.com/dmsimard/python-box-distgit/blob/master/box.spec SRPM URL: https://github.com/dmsimard/python-box-distgit/raw/master/python-box-3.4.1-1.fc30.src.rpm Description: Python dictionaries with advanced dot notation access Fedora Account System Username: dmsimard
Please make sure the spec name == package name and that the links here are to the actual content and not HTML pages. FedoraReview tries to download them and fails.
Spec URL: https://raw.githubusercontent.com/dmsimard/python-box-distgit/master/box.spec SRPM URL: https://github.com/dmsimard/python-box-distgit/raw/master/python-box-3.4.1-1.fc30.src.rpm Description: Python dictionaries with advanced dot notation access Fedora Account System Username: dmsimard
Spec URL: https://raw.githubusercontent.com/dmsimard/python-box-distgit/master/python-box.spec SRPM URL: https://github.com/dmsimard/python-box-distgit/raw/master/python-box-3.4.1-1.fc30.src.rpm Description: Python dictionaries with advanced dot notation access Fedora Account System Username: dmsimard
%{?python_provide:%python_provide python3-%{srcname}} This will eventually provide python-python-box. is that intended? ------ I suggest using tagged license source: https://raw.githubusercontent.com/cdgriffith/Box/%{version}/LICENSE Have you asked upstream to include it in sdist? ------ BuildRequires: python3-pytest-runner But no %check, why?
Checking: python3-box-3.4.1-1.fc31.noarch.rpm python-box-3.4.1-1.fc31.src.rpm python3-box.noarch: W: summary-ended-with-dot C Python dictionaries with advanced dot notation access. Please remove the dot. python3-box.noarch: E: no-changelogname-tag Please add %changelog. python3-box.noarch: E: wrong-script-interpreter /usr/lib/python3.7/site-packages/box.py /usr/bin/env python python3-box.noarch: E: non-executable-script /usr/lib/python3.7/site-packages/box.py 644 /usr/bin/env python Please remove that shebang. python3-box.noarch: W: no-manual-page-for-binary box.py Feel free to ignore that. python-box.src: W: summary-ended-with-dot C Python dictionaries with advanced dot notation access. python-box.src: E: no-changelogname-tag 2 packages and 0 specfiles checked; 4 errors, 3 warnings.
(In reply to Miro Hrončok from comment #4) > %{?python_provide:%python_provide python3-%{srcname}} > > This will eventually provide python-python-box. is that intended? > It's not. The project on PyPi is python-box and on GitHub it's box. I suppose we don't need a "box" package and only a "python3-box" package. > > I suggest using tagged license source: > https://raw.githubusercontent.com/cdgriffith/Box/%{version}/LICENSE Sure. > > Have you asked upstream to include it in sdist? > I had not but I just opened an issue about it: https://github.com/cdgriffith/Box/issues/92 > > BuildRequires: python3-pytest-runner > > But no %check, why? Because the project won't install without it: https://github.com/cdgriffith/Box/blob/3d221d7b33c1138a6c732a45ac943b201bd7fea2/setup.py#L36 I would like to add a %check macro eventually but I have time constraints right now.
Just noticed that in the last revision, the shebangs are not translated properly -- from "#!/usr/bin/env python" to "#!/usr/bin/python3 -s -s". Trying to figure that out.
(In reply to David Moreau Simard from comment #8) > Just noticed that in the last revision, the shebangs are not translated > properly -- from "#!/usr/bin/env python" to "#!/usr/bin/python3 -s -s". > > Trying to figure that out. Dropping "%{py3_shbang_opts}" fixed it for me -- it turns out that "%{__python3}" already supplied a "-s" and py3_shbang_opts was adding a second one.
Spec URL: https://raw.githubusercontent.com/dmsimard/python-box-distgit/master/python-box.spec SRPM URL: https://github.com/dmsimard/python-box-distgit/raw/master/python-box-3.4.2-1.fc30.src.rpm Description: Python dictionaries with advanced dot notation access Fedora Account System Username: dmsimard
> it turns out that "%{__python3}" already supplied a "-s" In fact, %{__python3} doesn't have -s, but %py3_build is trying to add -s and errors liek this, as is tracked in bz1335203. I'm back at this, sorry for the delay... running automated checks.
Anyway the shebang must be removed, not chnaged: python3-box.noarch: E: non-executable-script /usr/lib/python3.7/site-packages/box.py 644 /usr/bin/python3
@Miro, box.py ends up in /usr/bin too: . So I guess we need to keep the shebang for the script in /usr/bin and take out the one from site-packages.
I'm 75% sure the pathfix.py call is redundant an %py3_build and %py3_install will handle that. Running automated checks once more.
Package Review ============== This package is APPROVED. I strongly suggest to add a %check section that runs the upstream test suite. Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "Expat License". [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [-]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [?]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [?]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [?]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python3-box-3.4.2-1.fc31.noarch.rpm python-box-3.4.2-1.fc31.src.rpm python3-box.noarch: W: no-manual-page-for-binary box.py 2 packages and 0 specfiles checked; 0 errors, 1 warnings. Source checksums ---------------- https://files.pythonhosted.org/packages/source/p/python-box/python-box-3.4.2.tar.gz : CHECKSUM(SHA256) this package : 48dbb429347c0e5deb55fc71b993a5d54f8110cd39165b9a971cfab83504b34c CHECKSUM(SHA256) upstream package : 48dbb429347c0e5deb55fc71b993a5d54f8110cd39165b9a971cfab83504b34c Requires -------- python3-box (rpmlib, GLIBC filtered): /usr/bin/python3 python(abi) Provides -------- python3-box: python3-box python3.7dist(python-box) python3dist(python-box)
Thanks Miro, new package request is in https://pagure.io/releng/fedora-scm-requests/issue/13297
I've reset the fedora-review flag, otherwise that ticket would get closed as invalid. Please leave it at +.
I was not fast enough, you need to reopen that ticket.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-box
Built successfully for rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=36325647