Bug 1727013 - Add the libssh transport in the error info about wrong url
Summary: Add the libssh transport in the error info about wrong url
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux Advanced Virtualization
Classification: Red Hat
Component: libvirt
Version: 8.1
Hardware: Unspecified
OS: Unspecified
unspecified
low
Target Milestone: rc
: 8.0
Assignee: Pino Toscano
QA Contact: Yanqiu Zhang
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-07-04 09:15 UTC by yafu
Modified: 2020-11-14 08:42 UTC (History)
7 users (show)

Fixed In Version: libvirt-5.6.0-1.el8
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-11-06 07:17:18 UTC
Type: Bug
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2019:3723 0 None None None 2019-11-06 07:17:38 UTC

Description yafu 2019-07-04 09:15:05 UTC
Description of problem:
Add the libssh transport in the error info about wrong url

Version-Release number of selected component (if applicable):
libvirt-5.5.0-1.module+el8.1.0+3580+d7f6488d.x86_64

How reproducible:
100%

Steps to Reproduce:
1.# virsh -c qemu+libssh://10.73.73.110/system
Accept SSH host key with hash '8b:c6:2b:0b:a2:8f:ac:ff:dc:db:16:69:8a:5f:4f:4c:3f:2b:f5:72' for host '10.73.73.110:22' (y/n)?: y
Enter root's password for 10.73.73.110: 
Welcome to virsh, the virtualisation interactive terminal.

Type:  'help' for help with commands
       'quit' to quit

virsh # 


2.#virsh -c qemu+libssh3://10.73.73.110/system
error: failed to connect to the hypervisor
error: invalid argument: remote_open: transport in URL not recognised (should be tls|unix|ssh|ext|tcp|libssh2)

Actual results:
no libssh transport in the error info about wrong url

Expected results:
Since libssh is supported, so it's better to add the libssh transport in the error info about wrong url, such as:
error: invalid argument: remote_open: transport in URL not recognised (should be tls|unix|ssh|ext|tcp|libssh2|libssh)


Additional info:

Comment 1 Pino Toscano 2019-07-04 10:41:24 UTC
Patch sent:
https://www.redhat.com/archives/libvir-list/2019-July/msg00157.html

Comment 2 Pino Toscano 2019-07-04 11:24:32 UTC
Fixed upstream with:

commit cfec206e84d6151007a38a9228e10a23b8df57a8 (HEAD -> master, origin/master, origin/HEAD)
Author:     Pino Toscano <ptoscano>
AuthorDate: Thu Jul 4 12:38:26 2019 +0200
Commit:     Pino Toscano <ptoscano>
CommitDate: Thu Jul 4 13:16:46 2019 +0200

    remote: mention libssh in error message
    
    Mention libssh as possible transport in the error message of an
    unrecognized transport.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1727013
    
    Signed-off-by: Pino Toscano <ptoscano>
    Reviewed-by: Daniel P. Berrangé <berrange>

Comment 4 Yanqiu Zhang 2019-08-08 07:43:56 UTC
Verify this bug with:
libvirt-daemon-5.6.0-1.module+el8.1.0+3890+4d3d259c.x86_64
qemu-kvm-4.0.0-6.module+el8.1.0+3736+a2aefea3.x86_64

Steps:
# virsh -c qemu+abc://10.73.*.*/system
error: failed to connect to the hypervisor
error: invalid argument: remote_open: transport in URL not recognised (should be tls|unix|ssh|ext|tcp|libssh2|libssh)

'libssh' is included in error info now.

Since the result is as expected, mark this bug as verified.

Comment 6 errata-xmlrpc 2019-11-06 07:17:18 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2019:3723


Note You need to log in before you can comment on or make changes to this bug.