+++ This bug was initially created as a clone of Bug #1650995 +++

Tested and confirmed in Fedora 30 as well.

firewalld-0.6.4-1.fc30.noarch

Description of problem:

firewalld adds extra single quotes to log message configured in rich rules:

Chain IN_public_log (1 references)
target     prot opt source               destination         
LOG        tcp  --  anywhere             anywhere             tcp dpts:rfb:5903 ! match-set home src ctstate NEW,UNTRACKED LOG level warning prefix "'TL0G_VNC: '"
LOG        tcp  --  anywhere             anywhere             tcp dpt:ssh ! match-set home src ctstate NEW,UNTRACKED LOG level warning prefix "'TL0G_SSH: '"

From /etc/firewalld/zones/public.xml:
  <rule family="ipv4">
    <source ipset="home" invert="True"/>
    <service name="vnc-server"/>
    <log prefix="TL0G_VNC: " level="warning"/>
    <reject type="host-unreach"/>
  </rule>
  <rule family="ipv4">
    <source ipset="home" invert="True"/>
    <service name="ssh"/>
    <log prefix="TL0G_SSH: " level="warning"/>
    <reject type="host-unreach"/>
  </rule>

Single quotes inside double quotes didn't exist prior to upgrade from Fedora 28. I cannot confirm if single quotes were there with initial version of firewalld shipped with Fedora 29 as my rich rules broke firewalld, and wasn't resolved until 0.6.3 was released.


Version-Release number of selected component (if applicable):
Name         : firewalld
Version      : 0.6.3
Release      : 1.fc29
Arch         : noarch
Size         : 1.8 M
Source       : firewalld-0.6.3-1.fc29.src.rpm
Repo         : @System
From repo    : updates
Summary      : A firewall daemon with D-Bus interface providing a dynamic firewall
URL          : http://www.firewalld.org
License      : GPLv2+
Description  : firewalld is a firewall service daemon that provides a dynamic customizable
             : firewall with a D-Bus interface.


How reproducible:
Create rich rule, configure a log message prefix.

Steps to Reproduce:
1.
2. 
3.

Actual results:

From iptables -L:
LOG        tcp  --  anywhere             anywhere             tcp dpts:rfb:5903 ! match-set home src ctstate NEW,UNTRACKED LOG level warning prefix "'TL0G_VNC: '"

From syslog:
Nov 18 10:25:59 daw kernel: 'TL0G_SSH: 'IN=ens3 OUT= MAC=52:54:3c:0e:7c:89:00:12:f2:91:b8:00:08:00 SRC=205.185.121.253 DST=162.35.145.51 LEN=44 TOS=0x00 PREC=0x00 TTL=247 ID=54321 PROTO=TCP SPT=39303 DPT=22 WINDOW=65535 RES=0x00 SYN URGP=0


Expected results:
From iptables -L
LOG        tcp  --  anywhere             anywhere             tcp dpts:rfb:5903 ! match-set home src ctstate NEW,UNTRACKED LOG level warning prefix "TL0G_VNC: "

From syslog:
Nov 18 10:25:59 daw kernel: TL0G_SSH: IN=ens3 OUT= MAC=52:54:3c:0e:7c:89:00:12:f2:91:b8:00:08:00 SRC=205.185.121.253 DST=162.35.145.51 LEN=44 TOS=0x00 PREC=0x00 TTL=247 ID=54321 PROTO=TCP SPT=39303 DPT=22 WINDOW=65535 RES=0x00 SYN URGP=0

Additional info:

--- Additional comment from Zdenek Dohnal on 2019-03-12 13:45:39 UTC ---

If the report was created on demand in https://bugzilla.redhat.com/show_bug.cgi?id=1644432#c24 , then I encountered the same error - firewalld was running, but several errors were reported at the start - it was connected to my created rich rules for machines in virtual network and one of them was for mdns communication, so the issue had an outcome as blocking all mdns communication for me.

--- Additional comment from Zdenek Dohnal on 2019-03-12 14:12:28 UTC ---

It is not, as Rick said in https://bugzilla.redhat.com/show_bug.cgi?id=1644432#c26 , sorry for the noise.

--- Additional comment from Rick Dicaire on 2019-07-04 17:24:06 UTC ---

Hi, is this being ignored, or was it fixed in Fedora 30?