Bug 1727493

Description of problem:
When updating the CDN url, Satellite will trigger a foreman task to update the feed url of all the Red Hat repositories to reflect the new base url. If any of the Red Hat repositories is used by any content view, Satellite will update its feed url X(number of CVs used it) + 1 times. Thus, break the feed url. The path of the feed url will be replaced with an empty string.

For example, If I change my CDN repo to "http://satellite.example.com/pub/exports"

Before updating:
https://cdn.redhat.com/content/dist/rhel/server/7/7Server/x86_64/os

After updating, the feed url will become:
http://satellite.example.com/pub/exports


In '/opt/theforeman/tfm/root/usr/share/gems/gems/katello-3.10.0.48/app/lib/actions/katello/provider/update.rb'

        def update_repository_urls(product, current_base_url, new_base_url)
          product.repositories.each do |repository|    <===============  "product.repositories" will include "library_instance_id != nil" repos.
            next unless repository.url
            path = repository.url.split(current_base_url)[1]  <========== Path will be ""(empty string) when updating the 2nd times.
            url = "#{new_base_url}#{path}"
            plan_action(::Actions::Katello::Repository::Update, repository.root, :url => url)  <===== Root repository will be updated multiple times
          end
        end


Due to this issue, it also caused many duplicate RegenerateMetadata for the same repositories. This may cause serious performance impact for large environment.


Version-Release number of selected component (if applicable):
6.5

Steps to Reproduce:
1. Enable any Red Hat Repository
2. Create a CV and add that repository to the CV, publish and promote the CV.
3. Change the CDN url and wait for the task to finish.
4. Check the feed url of the repository in the web ui.