Test on qemu-kvm-4.0.0-4.module+el8.1.0+3523+b348b848.x86_64, don't hit this issue.

Hi,

It looks like this was fixed by 5e771752a1ffba3a99d7d75b6d492b4a86b59e1b.  Now I don’t know what we should do about this BZ.  Said commit is included in 4.0.0 (as you say in comment 1), so it will be fixed in 8.1.0.  Should we fix it in z-stream for 8.0.1?  (It looks like it would be a trivial backport.)

Max

(In reply to Max Reitz from comment #3)
> Hi,
> 
> It looks like this was fixed by 5e771752a1ffba3a99d7d75b6d492b4a86b59e1b. 
> Now I don’t know what we should do about this BZ.  Said commit is included
> in 4.0.0 (as you say in comment 1), so it will be fixed in 8.1.0.  Should we
> fix it in z-stream for 8.0.1?  (It looks like it would be a trivial
> backport.)

It will be fixed in 8.1 Advanced Virt (RHEL-AV, which rebases qemu and libvirt) and this BZ was open for RHEL, which is still stuck with qemu-2.12 and libvirt-4.5.

But I see the test was done with qemu from RHEL-AV, so the product is wrong.

Aihua: please retest with qemu from RHEL (not RHEL-AV).

(In reply to Ademar Reis from comment #4)
> (In reply to Max Reitz from comment #3)
> > Hi,
> > 
> > It looks like this was fixed by 5e771752a1ffba3a99d7d75b6d492b4a86b59e1b. 
> > Now I don’t know what we should do about this BZ.  Said commit is included
> > in 4.0.0 (as you say in comment 1), so it will be fixed in 8.1.0.  Should we
> > fix it in z-stream for 8.0.1?  (It looks like it would be a trivial
> > backport.)
> 
> It will be fixed in 8.1 Advanced Virt (RHEL-AV, which rebases qemu and
> libvirt) and this BZ was open for RHEL, which is still stuck with qemu-2.12
> and libvirt-4.5.
> 
> But I see the test was done with qemu from RHEL-AV, so the product is wrong.
> 
> Aihua: please retest with qemu from RHEL (not RHEL-AV).

Hi, Ademar

   Make some correction:

       The feature is in back list on RHEL, so i just run test on RHEL-AV.
 
       I found the bug on 8.0.1-av, and it works ok on 8.1.0-av as i commented in #c1

   Have changed product label to "Red Hat Enterprise Linux Advanced Virtualization"
   Sorry for the confusing..

aliang

Verified on qemu-kvm-4.1.0-1.module+el8.1.0+3966+4a23dca1.x86_64, the problem has been resolved, set bug's status to "Verified".

Test Steps:
  1.Create an empty image and start dst guest with virtio_blk device and dataplane enabled.
   /usr/libexec/qemu-kvm \
    -name 'avocado-vt-vm1' \
    -machine pc  \
    -nodefaults \
    -device VGA,bus=pci.0,addr=0x2  \
    -chardev socket,id=qmp_id_qmpmonitor1,path=/var/tmp/monitor-qmpmonitor1-20190602-221944-MrlxVzib,server,nowait \
    -mon chardev=qmp_id_qmpmonitor1,mode=control  \
    -chardev socket,id=qmp_id_catch_monitor,path=/var/tmp/monitor-catch_monitor-20190602-221944-MrlxVzia,server,nowait \
    -mon chardev=qmp_id_catch_monitor,mode=control \
    -device pvpanic,ioport=0x505,id=idn20piu  \
    -chardev socket,id=serial_id_serial0,path=/var/tmp/serial-serial0-20190602-221944-MrlxVzia,server,nowait \
    -device isa-serial,chardev=serial_id_serial0  \
    -chardev socket,id=seabioslog_id_20190602-221944-MrlxVzia,path=/var/tmp/seabios-20190602-221944-MrlxVzia,server,nowait \
    -device isa-debugcon,chardev=seabioslog_id_20190602-221944-MrlxVzia,iobase=0x402 \
    -device qemu-xhci,id=usb1,bus=pci.0,addr=0x3 \
    -object iothread,id=iothread0 \
    -drive id=drive_image1,if=none,snapshot=off,aio=threads,cache=none,file=/home/kvm_autotest_root/images/mirror.qcow2 \
    -device virtio-blk-pci,id=image1,drive=drive_image1,bus=pci.0,addr=0x4,iothread=iothread0 \
    -device virtio-net-pci,mac=9a:33:34:35:36:37,id=idj01pFr,vectors=4,netdev=idMgbx8B,bus=pci.0,addr=0x5  \
    -netdev tap,id=idMgbx8B,vhost=on \
    -m 4096  \
    -smp 4,maxcpus=4,cores=2,threads=1,sockets=2  \
    -cpu 'Skylake-Client',+kvm_pv_unhalt \
    -device usb-tablet,id=usb-tablet1,bus=usb1.0,port=1  \
    -vnc :1  \
    -rtc base=utc,clock=host,driftfix=slew  \
    -boot order=cdn,once=c,menu=off,strict=off \
    -enable-kvm \
    -monitor stdio \
    -qmp tcp:0:3001,server,nowait \
    -incoming tcp:0:5000 

2.Start src guest with qemu cmds:
   /usr/libexec/qemu-kvm \
    -name 'avocado-vt-vm1' \
    -machine pc  \
    -nodefaults \
    -device VGA,bus=pci.0,addr=0x2  \
    -chardev socket,id=qmp_id_qmpmonitor1,path=/var/tmp/monitor-qmpmonitor1-20190602-221944-MrlxVzia,server,nowait \
    -mon chardev=qmp_id_qmpmonitor1,mode=control  \
    -chardev socket,id=qmp_id_catch_monitor,path=/var/tmp/monitor-catch_monitor-20190602-221944-MrlxVzia,server,nowait \
    -mon chardev=qmp_id_catch_monitor,mode=control \
    -device pvpanic,ioport=0x505,id=idn20piu  \
    -chardev socket,id=serial_id_serial0,path=/var/tmp/serial-serial0-20190602-221944-MrlxVzia,server,nowait \
    -device isa-serial,chardev=serial_id_serial0  \
    -chardev socket,id=seabioslog_id_20190602-221944-MrlxVzia,path=/var/tmp/seabios-20190602-221944-MrlxVzia,server,nowait \
    -device isa-debugcon,chardev=seabioslog_id_20190602-221944-MrlxVzia,iobase=0x402 \
    -device qemu-xhci,id=usb1,bus=pci.0,addr=0x3 \
    -object iothread,id=iothread0 \
    -drive id=drive_image1,if=none,snapshot=off,aio=threads,cache=none,file=/home/kvm_autotest_root/images/rhel801-64-virtio.qcow2 \
    -device virtio-blk-pci,id=image1,drive=drive_image1,bus=pci.0,addr=0x4,iothread=iothread0 \
    -device virtio-net-pci,mac=9a:33:34:35:36:37,id=idj01pFr,vectors=4,netdev=idMgbx8B,bus=pci.0,addr=0x5  \
    -netdev tap,id=idMgbx8B,vhost=on \
    -m 4096  \
    -smp 4,maxcpus=4,cores=2,threads=1,sockets=2  \
    -cpu 'Skylake-Client',+kvm_pv_unhalt \
    -device usb-tablet,id=usb-tablet1,bus=usb1.0,port=1  \
    -vnc :0  \
    -rtc base=utc,clock=host,driftfix=slew  \
    -boot order=cdn,once=c,menu=off,strict=off \
    -enable-kvm \
    -monitor stdio \
    -qmp tcp:0:3000,server,nowait \

3. Do mirror from src to dst
   { "execute": "drive-mirror", "arguments": { "device": "drive_image1","target":"/home/kvm_autotest_root/images/mirror.qcow2","sync":"full","mode":"existing"}}

4. Set migration capabilities
   {"execute":"migrate-set-capabilities","arguments":{"capabilities":[{"capability":"pause-before-switchover","state":true}]}}

5. Migrate from src to dst
   { "execute": "migrate", "arguments": { "uri": "tcp:localhost:5000"}}
   {"timestamp": {"seconds": 1565943473, "microseconds": 568457}, "event": "STOP"}

6. Cancel block job:
   {"execute":"block-job-cancel","arguments":{"device":"drive_image1"}}
{"return": {}}
{"timestamp": {"seconds": 1565943683, "microseconds": 388539}, "event": "JOB_STATUS_CHANGE", "data": {"status": "waiting", "id": "drive_image1"}}
{"timestamp": {"seconds": 1565943683, "microseconds": 388572}, "event": "JOB_STATUS_CHANGE", "data": {"status": "pending", "id": "drive_image1"}}
{"timestamp": {"seconds": 1565943683, "microseconds": 388872}, "event": "BLOCK_JOB_COMPLETED", "data": {"device": "drive_image1", "len": 4905172992, "offset": 4905172992, "speed": 0, "type": "mirror"}}
{"timestamp": {"seconds": 1565943683, "microseconds": 388901}, "event": "JOB_STATUS_CHANGE", "data": {"status": "concluded", "id": "drive_image1"}}
{"timestamp": {"seconds": 1565943683, "microseconds": 388936}, "event": "JOB_STATUS_CHANGE", "data": {"status": "null", "id": "drive_image1"}}

7. Migrate continue
   {"execute":"migrate-continue","arguments":{"state":"pre-switchover"}}

8. In src, check vm status
  (qemu)info status
VM status: paused (postmigrate)

9. In dst, check vm status
  (qemu) info status 
VM status: running

10. In dst, reset vm
  (qemu)system_reset

After step10, vm restart successfully.

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2019:3723